Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20220804165317.29086-1-ddrokosov@sberdevices.ru>
User-agent: mu4e 1.8.7; emacs 27.1
From:   Jerome Brunet <jbrunet@baylibre.com>
To:     Dmitry Rokosov <DDRokosov@sberdevices.ru>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "narmstrong@baylibre.com" <narmstrong@baylibre.com>,
        "khilman@baylibre.com" <khilman@baylibre.com>,
        "martin.blumenstingl@googlemail.com" 
        <martin.blumenstingl@googlemail.com>
Cc:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-amlogic@lists.infradead.org" 
        <linux-amlogic@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        kernel <kernel@sberdevices.ru>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] arm64: dts: meson-axg: reserve memory region for
 Amlogic TrustOS
Date:   Fri, 05 Aug 2022 10:03:34 +0200
In-reply-to: <20220804165317.29086-1-ddrokosov@sberdevices.ru>
Message-ID: <1jfsibqfez.fsf@starbuckisacylon.baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


On Thu 04 Aug 2022 at 16:52, Dmitry Rokosov <DDRokosov@sberdevices.ru> wrote:

> For the all AXG SoC based boards, which run Amlogic vendor ATF and
> TrustOS this memory region 0x5300000-0x6300000 is reserved by BL32,
> so tag it as no-map in the kernel iomem.

This may be true for the boards you have seen so far but not all ship
with this specific AML TEE. Some don't have TEE at all, other may have
different TEE regions.

16 MB may be a significant part of the available memory on some AXG
devices. Reserving that memory on all AXG devices, regardless of what is
actually running does not seem appropriate.

I know the same has been done for other devices but I don't think we should
continue to do so. This should be set either
* per device if it is fixed
* dynamically by the bootloader depending on the ATF (which is probably better)

>
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> ---
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 3f5254eeb47b..1fa0d3805969 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -142,6 +142,12 @@ secmon_reserved: secmon@5000000 {
>  			reg = <0x0 0x05000000 0x0 0x300000>;
>  			no-map;
>  		};
> +
> +		/* 16 MiB reserved for Amlogic Trust OS (BL32) */
> +		secos_reserved: secos@5300000 {
> +			reg = <0x0 0x05300000 0x0 0x1000000>;
> +			no-map;
> +		};
>  	};
>  
>  	scpi {