Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ea108115-f2dd-5767-1f86-34cdfdedc2a5@huawei.com>
Date:   Fri, 5 Aug 2022 09:11:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v3 00/17] Compress the pmu_event tables
From:   John Garry <john.garry@huawei.com>
To:     Ian Rogers <irogers@google.com>
CC:     Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
        "Mike Leach" <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        "Arnaldo Carvalho de Melo" <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        "Zhengjun Xing" <zhengjun.xing@linux.intel.com>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-perf-users@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>
References: <20220729074351.138260-1-irogers@google.com>
 <d8356ddc-56e7-7324-5330-ff2bd54bcba4@huawei.com>
 <CAP-5=fV0CMpBGkNOBMRjbdZfdw1mQjrDhLVG38jLtpsdWXtQ_Q@mail.gmail.com>
 <3d0c1ec0-42ec-8c51-743b-5d93cabb53fb@huawei.com>
In-Reply-To: <3d0c1ec0-42ec-8c51-743b-5d93cabb53fb@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 02/08/2022 10:08, John Garry wrote:
> 
> 
>> we can ignore the costs of the strings as
>> they should be fully shared, especially for BDW-DE.
> 
> Are you sure about this? I did not think that the compiler would have 
> the intelligence to try to share strings. That is the basis of the size 
> optimisation which I was proposing (that the compiler would not share 
> strings).

JFYI, I am finding that all identical strings are shared, which is good.

Thanks,
John