Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp1457932rwb; Fri, 5 Aug 2022 02:12:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR7dA9tZUftt75ruNvbG6srHk2LPsWBPmtro7ZWtStJobjJR+8c5xZSqNAHH43UNk8H3MASS X-Received: by 2002:a17:902:700c:b0:16f:1064:a126 with SMTP id y12-20020a170902700c00b0016f1064a126mr5784935plk.51.1659690761610; Fri, 05 Aug 2022 02:12:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659690761; cv=none; d=google.com; s=arc-20160816; b=ovvBALsBQvTO/Ae5YiZ/GmZvIbbbOzWPZVNAV6FlRemmybc1TFz6614zqg9Mcvs/D5 VJUOa3e1mTlaIxIYzplAFnZmalUDae3ygGAjnIuceqRnTZN7APL5SEHmEFJU+/PvyCQa hvgouTGgcFrTGL4FGh1koMqAOU3ikPwedrv/pnyzTC6lfYFcbiWiX+ZhZrK5rFPRjQmL v+8mt48RPCjgwMWTx3Z0pf9xLwVSliiVUChM5ZqL2S+YAqRDkPnfG62MtiY/5U2vHmJD MU1xiHs9/v61Hov8CI0bM0jXQi2lO4JjMu6eZDhvJj8v+BeLdfJH1aIR3/CYLcYwyGig YQBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0V2XcXTNZOnS6i2T1ocboK5hlXYwZjdsSG0fu5Zt4Xk=; b=jrG73GTPahEUjSANmE/Krrvjklue3/thq8+6K9hp/QLGyISUZ27puXUSUlEkUPZNSS 0PSs2LDgBYdqdcnF2vjhyzHaFupDSG+fsPm+Fm25DyWuIBnJI/7MEFZqg0UJg+XnsWCW /+ii+705IPWPhMZAs3i5NgDEVkv313S/TQBfEBcMrI+19zw8op7ZIwIakuz7CXYIB7UC AGYVfr3eapTUJ6SN+FkPVptxa9l42BondNm+EKJwjhnWQk/OtHMHMKh5P4C7Vr5+H4A9 yZh4sLO46R8pRRMgWYFMXtgNHu5fk+nsEWGgIH90grV83jelwtYQLT+6EApJ495sjOrA n2lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=biSEyLDp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q19-20020a170902bd9300b0016d43e38858si3122584pls.605.2022.08.05.02.12.27; Fri, 05 Aug 2022 02:12:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=biSEyLDp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240442AbiHEJIQ (ORCPT + 99 others); Fri, 5 Aug 2022 05:08:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235839AbiHEJIO (ORCPT ); Fri, 5 Aug 2022 05:08:14 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BC9F21E10; Fri, 5 Aug 2022 02:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659690493; x=1691226493; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VCbk/q9Wd0lGTGIEGbC69VxKX0QDmTy8SvpJ1KoCfF0=; b=biSEyLDpCGbC085vqq4/C7VcR++Gz//BsrGNyI6UYr4FpmOL3E1o6lR2 TikNhO5QuSbvVNEFVIt3KNTiCwKRxvcBluqyClmMyYPHpmwrRFoX/RW+V LHG6mD4MDTWoUi+QO5WBxylKaYOYMmZ6VrZjCKzU2tZzrHq9ZKFgZWTuD obUhfGUVuGRwjMrTy5OsaY4LS/Tw66zzFebJOax3Qcx9rAylKisq2lMIt zdnjoxFDc3BGrF+hES5qwMEnAbaVJQw0HJYF20W9ldCk6senONYh1/dLk 9nECiHfPoOE/fadh/BNwz0PQbZ6uqc5+kg7o0xtvw/Sp9Nl5WXIJBIg1F Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10429"; a="316045584" X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="316045584" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2022 02:08:13 -0700 X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="631945398" Received: from mborg-mobl1.ger.corp.intel.com (HELO intel.com) ([10.251.214.158]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2022 02:08:07 -0700 Date: Fri, 5 Aug 2022 11:08:05 +0200 From: Andi Shyti To: Randy Dunlap Cc: Mauro Carvalho Chehab , Jonathan Corbet , Niranjana Vishwanathapura , Andi Shyti , Tvrtko Ursulin , Chris Wilson , Daniel Vetter , David Airlie , Jani Nikula , Joonas Lahtinen , Maarten Lankhorst , Maxime Ripard , Rodrigo Vivi , Thomas Zimmermann , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] drm/i915/gt: document TLB cache invalidation functions Message-ID: References: <0698c5a5-3bf2-daa4-e10e-2715f9b0d080@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0698c5a5-3bf2-daa4-e10e-2715f9b0d080@infradead.org> X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, > > +/** > > + * intel_gt_invalidate_tlb_full - do full TLB cache invalidation > > + * @gt: GT structure > > In multiple places (here and below) it would be nice to know what a > GT structure is. I looked thru multiple C and header files yesterday > and didn't find any comments about it. > > Just saying that @gt is a GT structure isn't very helpful, other > than making kernel-doc shut up. the 'gt' belongs to the drivers/gpu/drm/i915/gt/ subsystem and it's widely used a throughout i915. I think it's inappropriate to describe it just here. On the other hand I agree that a better documentation is required for the GT itself where other parts can point to. Andi