Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 5 Aug 2022 12:08:37 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Mikulas Patocka <mpatocka@redhat.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, Mike Snitzer <snitzer@redhat.com>
Subject: drivers/md/dm-writecache.c:1554 writecache_map() warn: inconsistent
 returns '&wc->lock'.
Message-ID: <202208050301.roHRxc6O-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xbGx1zh4MsVPGxxcA2p2t/xvYerTTeA/LEJl05REPYh5TYJyXl1ETHGyb8w/?=
 =?us-ascii?Q?21HzwdtCSvV9BiVyiW/kCBSoeC0atNW2u4R3v0/zEIxOCjADvcsvjTUWTAhM?=
 =?us-ascii?Q?2hFE0H9DNH5G+ylZ/ZC7cBqq3u1ruCPB8Z9ClvGOcTl1uZN7/U1FZMyTtAmL?=
 =?us-ascii?Q?TxQiOxurVgjx0Pm4gkGW8ymlRSFrdkhu2SY+P4dTFQaNmZE+/aNfGLJs4MZ7?=
 =?us-ascii?Q?2s8jaJG9uIH904g3GsijfyCBAWY2iUGOW/sUsmgDrWNIUuNtCTDuTFft8ACL?=
 =?us-ascii?Q?ChplYRz4yPYjnvqxHB0ThhJJfJlTrPbwIeWGIM4r5iQ6zkYB7yuqd0kpR4Wg?=
 =?us-ascii?Q?6+hEci+vH6hMA7sz4IsCDm3XUxkhVhee/lyaRCrmVunTtw7fNE/VxdJg+W3F?=
 =?us-ascii?Q?pnyy4Q77z6cWvfOrCa8vqP1ZSbms4sXrz9zdGPQBtBT+0hLVkJADXjht28/+?=
 =?us-ascii?Q?BlUG04c29Tu4NUmm/cEyl1JVBeDPyoI8RMPwU7hKorM1/W1/+aw4UUWBEIYD?=
 =?us-ascii?Q?FA87Q1ZOD3w0IqsaJJpLu8GvIATVynme2sl7VGYqOU/W3h9jIt5/c1DewgO1?=
 =?us-ascii?Q?CnI4RlVXmRLVTSOO4IvGjSoWpKuGCfv7/NfupHljDnl6x7+reTG+qn/hCHIH?=
 =?us-ascii?Q?0FEmaUbMDWwNZpa22jn6sWwtw2VtJJFZgwLlSYBjtaks5TOCiN20W+liJ1NR?=
 =?us-ascii?Q?+zTepwPI4TtqmhvAWFrCw06KKkm9xnsbHxgfCwQSMhs8QIpJIBITjvx4AtXb?=
 =?us-ascii?Q?S2oV4lYQYKmwfxN5UciNrHTNii6mf03efjy9U85Z1CmxNUwk2iPscG4XioNZ?=
 =?us-ascii?Q?NIx9Gqe76oKod96wjwSBaVaAmR/LWZV6ncTIJdKec0tdHwq3/eEYOfz25eiz?=
 =?us-ascii?Q?BlFxrpBEmlUSP7OHYYLB/qyxuIpgk824n3pXExZCpO2bD7JXB/U+iWy49Hqj?=
 =?us-ascii?Q?GOtYcczQ1rUJ7uA5zPcaeZbcdKbMRYOihFK3BmQzw3qvyqlJTO5B9Sal7bqy?=
 =?us-ascii?Q?3OWZ/NTNv2gZKZIDNR1/J39hYkr9eDRJJ/8p1ELpR+XNXRXtDgUyHCJXgnwz?=
 =?us-ascii?Q?JYlfWyAkqodaxD2SBwgeW2zwxCfwJUsslFFnMwk2cKCrXFpU06FB3wqJ/zDt?=
 =?us-ascii?Q?DB3cwqeOp3spRhyUMSp87eHRmIJq0FjdB06HBcsbrGluJmENgkug4zBCfmub?=
 =?us-ascii?Q?hkvu9gmnE4SYblJVywCWcxKI89uklGm45xdkKv3FRcbTSdJads7fx+NT7cCi?=
 =?us-ascii?Q?9sc4aPvFLWcalNOY0yOy0cdQ0HZXZ+Oo/Zn8sK+B5WpUbzVq83JbkZledVVg?=
 =?us-ascii?Q?Dt1Q1dNFvii6dpaMmZ9hpZrgRbzyEOpM5+P1Mq86j1Rb+GmHSYgFhbiqUSRe?=
 =?us-ascii?Q?ra70KT7D7wN8QIV0oPipnOZ5HpaYET/RxT0N/QPzMRO9stH+6nNQ37spm2tU?=
 =?us-ascii?Q?Rc7mYxSESrAO3FwnvBssGHIdlSZ34yiO/75WMTMWvAmKEGNfDkSf+UBi2dvw?=
 =?us-ascii?Q?9UaypCAkpuu0K8IRaEeJj9S8jFoVLukd6esYZ/SbIOfUKJ+0BjswVW87dTI8?=
 =?us-ascii?Q?bhBh5RVU4f5IJsG+ijbdM3oPOYFWvbYkPvaQYI/XyiVeGdNG1bom23f34iru?=
 =?us-ascii?Q?Iw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46555cbd-6488-4a33-437e-08da76c21fda
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2022 09:08:56.0070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: chuWL3fDoz4YrYSoiKDF/oeG8SstNtJK2zI6S9J8yZwfWn6fmvQKq05C4LExAZ3YQKmvXdCVt084T5ltFz/gtFbuNyWcmKD0pQGanlsu6GY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5458
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-05_03,2022-08-04_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2208050045
X-Proofpoint-ORIG-GUID: MLPSMzjc_3Wsz-3UiczQ31GRGF2g3QF8
X-Proofpoint-GUID: MLPSMzjc_3Wsz-3UiczQ31GRGF2g3QF8
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1
commit: df699cc16ea5ef93a917676dcdd4376e02860ad5 dm writecache: report invalid return from writecache_map helpers
config: arc-randconfig-m041-20220804 (https://download.01.org/0day-ci/archive/20220805/202208050301.roHRxc6O-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/md/dm-writecache.c:1554 writecache_map() warn: inconsistent returns '&wc->lock'.

vim +1554 drivers/md/dm-writecache.c

cdd4d7832d51e0 Mike Snitzer    2021-07-12  1484  static int writecache_map(struct dm_target *ti, struct bio *bio)
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1485  {
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1486  	struct dm_writecache *wc = ti->private;
15cb6f39dbaf39 Mike Snitzer    2021-07-12  1487  	enum wc_map_op map_op;
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1488  
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1489  	bio->bi_private = NULL;
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1490  
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1491  	wc_lock(wc);
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1492  
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1493  	if (unlikely(bio->bi_opf & REQ_PREFLUSH)) {
15cb6f39dbaf39 Mike Snitzer    2021-07-12  1494  		map_op = writecache_map_flush(wc, bio);
15cb6f39dbaf39 Mike Snitzer    2021-07-12  1495  		goto done;
dcd195071f22d4 Mikulas Patocka 2020-01-15  1496  	}
dcd195071f22d4 Mikulas Patocka 2020-01-15  1497  
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1498  	bio->bi_iter.bi_sector = dm_target_offset(ti, bio->bi_iter.bi_sector);
dcd195071f22d4 Mikulas Patocka 2020-01-15  1499  
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1500  	if (unlikely((((unsigned)bio->bi_iter.bi_sector | bio_sectors(bio)) &
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1501  				(wc->block_size / 512 - 1)) != 0)) {
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1502  		DMERR("I/O is not aligned, sector %llu, size %u, block size %u",
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1503  		      (unsigned long long)bio->bi_iter.bi_sector,
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1504  		      bio->bi_iter.bi_size, wc->block_size);
15cb6f39dbaf39 Mike Snitzer    2021-07-12  1505  		map_op = WC_MAP_ERROR;
15cb6f39dbaf39 Mike Snitzer    2021-07-12  1506  		goto done;
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1507  	}
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1508  
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1509  	if (unlikely(bio_op(bio) == REQ_OP_DISCARD)) {
15cb6f39dbaf39 Mike Snitzer    2021-07-12  1510  		map_op = writecache_map_discard(wc, bio);
15cb6f39dbaf39 Mike Snitzer    2021-07-12  1511  		goto done;
48debafe4f2fea Mikulas Patocka 2018-03-08  1512  	}
48debafe4f2fea Mikulas Patocka 2018-03-08  1513  
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1514  	if (bio_data_dir(bio) == READ)
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1515  		map_op = writecache_map_read(wc, bio);
48debafe4f2fea Mikulas Patocka 2018-03-08  1516  	else
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1517  		map_op = writecache_map_write(wc, bio);
15cb6f39dbaf39 Mike Snitzer    2021-07-12  1518  done:
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1519  	switch (map_op) {
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1520  	case WC_MAP_REMAP_ORIGIN:
5c0de3d72f8c05 Mikulas Patocka 2021-06-28  1521  		if (likely(wc->pause != 0)) {
5c0de3d72f8c05 Mikulas Patocka 2021-06-28  1522  			if (bio_op(bio) == REQ_OP_WRITE) {
95b88f4d71cb95 Mikulas Patocka 2021-06-25  1523  				dm_iot_io_begin(&wc->iot, 1);
95b88f4d71cb95 Mikulas Patocka 2021-06-25  1524  				bio->bi_private = (void *)2;
95b88f4d71cb95 Mikulas Patocka 2021-06-25  1525  			}
5c0de3d72f8c05 Mikulas Patocka 2021-06-28  1526  		}
48debafe4f2fea Mikulas Patocka 2018-03-08  1527  		bio_set_dev(bio, wc->dev->bdev);
48debafe4f2fea Mikulas Patocka 2018-03-08  1528  		wc_unlock(wc);
48debafe4f2fea Mikulas Patocka 2018-03-08  1529  		return DM_MAPIO_REMAPPED;
48debafe4f2fea Mikulas Patocka 2018-03-08  1530  
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1531  	case WC_MAP_REMAP:
48debafe4f2fea Mikulas Patocka 2018-03-08  1532  		/* make sure that writecache_end_io decrements bio_in_progress: */
48debafe4f2fea Mikulas Patocka 2018-03-08  1533  		bio->bi_private = (void *)1;
48debafe4f2fea Mikulas Patocka 2018-03-08  1534  		atomic_inc(&wc->bio_in_progress[bio_data_dir(bio)]);
48debafe4f2fea Mikulas Patocka 2018-03-08  1535  		wc_unlock(wc);
48debafe4f2fea Mikulas Patocka 2018-03-08  1536  		return DM_MAPIO_REMAPPED;
48debafe4f2fea Mikulas Patocka 2018-03-08  1537  
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1538  	case WC_MAP_SUBMIT:
48debafe4f2fea Mikulas Patocka 2018-03-08  1539  		wc_unlock(wc);
48debafe4f2fea Mikulas Patocka 2018-03-08  1540  		bio_endio(bio);
48debafe4f2fea Mikulas Patocka 2018-03-08  1541  		return DM_MAPIO_SUBMITTED;
48debafe4f2fea Mikulas Patocka 2018-03-08  1542  
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1543  	case WC_MAP_RETURN:
48debafe4f2fea Mikulas Patocka 2018-03-08  1544  		wc_unlock(wc);
48debafe4f2fea Mikulas Patocka 2018-03-08  1545  		return DM_MAPIO_SUBMITTED;
48debafe4f2fea Mikulas Patocka 2018-03-08  1546  
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1547  	case WC_MAP_ERROR:
48debafe4f2fea Mikulas Patocka 2018-03-08  1548  		wc_unlock(wc);
48debafe4f2fea Mikulas Patocka 2018-03-08  1549  		bio_io_error(bio);
48debafe4f2fea Mikulas Patocka 2018-03-08  1550  		return DM_MAPIO_SUBMITTED;
df699cc16ea5ef Mikulas Patocka 2021-07-27  1551  
df699cc16ea5ef Mikulas Patocka 2021-07-27  1552  	default:
df699cc16ea5ef Mikulas Patocka 2021-07-27  1553  		BUG();
df699cc16ea5ef Mikulas Patocka 2021-07-27 @1554  		return -1;

This only warning only happens if you CONFIG_ the BUG() away.  Hard to
tell how far we really care about dealing with impossible situations...

48debafe4f2fea Mikulas Patocka 2018-03-08  1555  	}
cdd4d7832d51e0 Mike Snitzer    2021-07-12  1556  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp