Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b36d1ddc-c2db-501c-1e37-17aaefc2b271@linux.alibaba.com>
Date:   Fri, 5 Aug 2022 17:07:27 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH v3 0/3] drivers/perf: add DDR Sub-System Driveway PMU
 driver for Yitian 710 SoC
Content-Language: en-US
To:     Will Deacon <will@kernel.org>
Cc:     baolin.wang@linux.alibaba.com, yaohongbo@linux.alibaba.com,
        nengchen@linux.alibaba.com, zhuo.song@linux.alibaba.com,
        Jonathan.Cameron@Huawei.com, rdunlap@infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        will@kernel.org, mark.rutland@arm.com
References: <20220617111825.92911-1-xueshuai@linux.alibaba.com>
 <20220720065815.60772-1-xueshuai@linux.alibaba.com>
From:   Shuai Xue <xueshuai@linux.alibaba.com>
In-Reply-To: <20220720065815.60772-1-xueshuai@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi, Will,

I was wondering that do you have any comments to this patch set?

Thank you.

Best Regards,
Shuai

在 2022/7/20 PM2:58, Shuai Xue 写道:
> This patchset adds support for Yitian 710 DDR Sub-System Driveway PMU driver,
> which custom-built by Alibaba Group's chip development business, T-Head.
> 
> Changes since v2:
> - relaxe build constraints and add COMPILE_TEST
> - explicitly include dependent headers
> - add Reviewed-by, thanks Jonathan Cameron and Randy Dunlap for their valuable review and comments
> - Link: https://lore.kernel.org/linux-arm-kernel/20220715151310.90091-4-xueshuai@linux.alibaba.com/T/#m1116abc4b0bda1943ab436a45d95359f9bbe0858
> 
> Changes since v1:
> - add high level workflow about DDRC so that user cloud better understand the
>   PMU hardware mechanism
> - rewrite patch description and add interrupt sharing constraints
> - delete event perf prefix
> - add a condition to fix bug in ali_drw_pmu_isr
> - perfer CPU in the same Node when migrating irq
> - use FIELD_PREP and FIELD_GET to make code more readable
> - add T-Head HID and leave ARMHD700 as CID for compatibility
> - Link: https://lore.kernel.org/linux-arm-kernel/eb50310d-d4a0-c7ff-7f1c-b4ffd919b10c@linux.alibaba.com/T/
> 
> Shuai Xue (3):
>   docs: perf: Add description for Alibaba's T-Head PMU driver
>   drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710
>     SoC
>   MAINTAINERS: add maintainers for Alibaba' T-Head PMU driver
> 
>  .../admin-guide/perf/alibaba_pmu.rst          | 100 +++
>  Documentation/admin-guide/perf/index.rst      |   1 +
>  MAINTAINERS                                   |   7 +
>  drivers/perf/Kconfig                          |   7 +
>  drivers/perf/Makefile                         |   1 +
>  drivers/perf/alibaba_uncore_drw_pmu.c         | 810 ++++++++++++++++++
>  6 files changed, 926 insertions(+)
>  create mode 100644 Documentation/admin-guide/perf/alibaba_pmu.rst
>  create mode 100644 drivers/perf/alibaba_uncore_drw_pmu.c
>