Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp1506919rwb; Fri, 5 Aug 2022 03:16:40 -0700 (PDT) X-Google-Smtp-Source: AA6agR56baCN24Kn/wx74l03Sg63GMXai5kpY2K8+g6JPKaXhewTHi5xVzyAkPa5Iqdut0pJlWf0 X-Received: by 2002:a05:6402:42d3:b0:435:2c49:313d with SMTP id i19-20020a05640242d300b004352c49313dmr5904467edc.86.1659694600703; Fri, 05 Aug 2022 03:16:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659694600; cv=none; d=google.com; s=arc-20160816; b=ueicffOo/8cBgcFjgl1Gga6xZx04F2FJz36qG3AvbkfhxApNDQ/LtkAEJ9JPwaAaBg yfphwDAuv0OjYJK+os3C/QfllfpkcaT7MWwcP4tbUNI8lLwNEqKnVDWrvk8UyRToqaBE cJTDMHYYrCJDK60PMlZsY7GuJAYuIeJDmFuxrrBNsXlzlKOnRW2D6m4TQp04G+45Jc15 rghr96RpZQT4e08qp4ICMN1zyUnAeD29ktGZEy50o+MfGwlq+WO9zwuivfByOCjFIebR 5ovz2IWQ8W4OyJ/r95Mr0VH2h9994CY9rZ3FZ0C1aLY9kJJ1DOXThtzI0IDcoWBaJ8N5 2P9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=2UcIHnOQq+acozLBblnqxrMwyWmP0rd/4WNiicBcbp8=; b=NUxzhs9uXxjqImAuN/KL16un9YTlMmaiRF08SgLOQlQrcEfGuSITe0s9vpF5dBpiEc IzjoU/2njkim/2qpFU2iWa98JtOBiwbL5Y9Q22JQmrp55wOluKaFCUKyqYd04Ka/kbAO CtzngzB2xu/3UpjkF9OBkawMy6kDyCGos2NatrTGJUhvWt4K2SRdYe6DJ7+jKpb3N7si nYYPgBgdEEObyVZfzkWM4EcDJ1wsOhuXb7bSzkqTXKgjaCe/BG+LjvNmIJ1/U4E64G0i mA6DhOzqC6xAJ92/fhIy7CwPpS6InkMk29yzgUO78B0e/Y0jkH2QzTfyNVjAv/q3rS31 ig9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw18-20020a170906479200b0072ee50dd4e6si3560317ejc.470.2022.08.05.03.16.15; Fri, 05 Aug 2022 03:16:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230370AbiHEKBB (ORCPT + 99 others); Fri, 5 Aug 2022 06:01:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235995AbiHEKAi (ORCPT ); Fri, 5 Aug 2022 06:00:38 -0400 Received: from mail-sz.amlogic.com (mail-sz.amlogic.com [211.162.65.117]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D8495A896; Fri, 5 Aug 2022 03:00:34 -0700 (PDT) Received: from [10.88.19.200] (10.88.19.200) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server id 15.1.2507.6; Fri, 5 Aug 2022 18:00:31 +0800 Message-ID: <880842a1-a769-f228-7c91-5402e6d9391e@amlogic.com> Date: Fri, 5 Aug 2022 18:00:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH v4 4/4] dt-binding: perf: Add Amlogic DDR PMU Content-Language: en-US To: Krzysztof Kozlowski , , , , CC: Rob Herring , Krzysztof Kozlowski , Will Deacon , Mark Rutland , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Chris Healy References: <20220805071426.2598818-1-jiucheng.xu@amlogic.com> <20220805071426.2598818-4-jiucheng.xu@amlogic.com> From: Jiucheng Xu In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.88.19.200] X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/8/5 16:21, Krzysztof Kozlowski wrote: > [ EXTERNAL EMAIL ] > > On 05/08/2022 09:14, Jiucheng Xu wrote: >> Add binding documentation for the Amlogic G12 series DDR >> performance monitor unit. >> > Bindings go first in the series, before their implementation. > >> Signed-off-by: Jiucheng Xu >> --- >> Changes v3 -> v4: >> - Fix "$id: relative path/filename doesn't match actual path or >> filename" warning >> >> Changes v2 -> v3: >> - Remove oneOf >> - Add descriptions >> - Fix compiling warning >> >> Changes v1 -> v2: >> - Rename file, from aml_ddr_pmu.yaml to amlogic,g12_ddr_pmu.yaml >> - Delete "model", "dmc_nr", "chann_nr" new properties >> - Fix compiling error >> --- >> .../bindings/perf/amlogic,g12-ddr-pmu.yaml | 52 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 53 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml >> >> diff --git a/Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml b/Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml >> new file mode 100644 >> index 000000000000..4d018574ffd1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml >> @@ -0,0 +1,52 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/perf/amlogic,g12-ddr-pmu.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic G12 DDR performance monitor >> + >> +maintainers: >> + - Jiucheng Xu >> + >> +description: | >> + Amlogic G12 series SoC integrate DDR bandwidth monitor. >> + A timer is inside and can generate interrupt when timeout. >> + The bandwidth is counted in the timer ISR. Different platform >> + has different subset of event format attribute. >> + >> +properties: >> + compatible: >> + items: > You have only one item, so remove "items". > >> + - enum: >> + - amlogic,g12b-ddr-pmu >> + - amlogic,g12a-ddr-pmu >> + - amlogic,sm1-ddr-pmu >> + >> + reg: >> + items: >> + - description: Physical address of DMC bandwidth register >> + and size of the configuration address space. > Skip obvious pieces, so only: > > description: DMC bandwidth register space > >> + - description: Physical address of DMC PLL register and >> + size of the configuration address space. > description: DMC PLL bandwidth register space > > >> + >> + interrupts: >> + items: >> + - description: The IRQ of the inside timer timeout. >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + ddr_pmu@ff638000 { > No underscores in node names, generic node names, so just "pmu". > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > >> + compatible = "amlogic,g12a-ddr-pmu"; >> + reg = <0xff638000 0x100 >> + 0xff638c00 0x100>; > This is still not fixed. Binding says you have two items, but you > declared here only one item. Okay, I will change it as your comments. > Best regards, > Krzysztof > -- Thanks, Jiucheng