Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 5 Aug 2022 11:42:03 +0200
From:   Borislav Petkov <bp@suse.de>
To:     Can Sun <cansun@arista.com>
Cc:     Kevin Mitchell <kevmitch@arista.com>,
        Ivan Delalande <colona@arista.com>,
        weidonghui <weidonghui@allwinnertech.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/decodecode: add the ability to find code sequence
Message-ID: <Yuzl64bME7GUWo10@zn.tnic>
References: <20220804214616.71419-1-cansun@arista.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220804214616.71419-1-cansun@arista.com>
Precedence: bulk

On Thu, Aug 04, 2022 at 04:46:16PM -0500, Can Sun wrote:
>  It adds a tool to search code sequence from vmlinux. If additional
>  parameters (vmlinux and kernel build path) are provided to decodecode
>  command, it will try to search the code sequence in the binary, and
>  provide a code block surrounding the target.

The use case being?

objdump -d vmlinux and searching for the rIP is too much typing?

Besides, with the kernel being more and more runtime-patched and
rewritten, the live code differs more and more from the actual compiled
opcode bytes in vmlinux, as you noticed yourself with restoredcode
below.

So maybe I'm missing some important use case but right now this looks
pointless to me.

Thx.

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
(HRB 36809, AG Nürnberg)