Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2c6161058d1253c1eabec274ca8c1c98bdc6d490.camel@nxp.com>
Subject: Re: [PATCH v3 3/3] dt-bindings: bus: Add Freescale i.MX8qxp pixel
 link MSI bus binding
From:   Liu Ying <victor.liu@nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, saravanak@google.com,
        gregkh@linuxfoundation.org, geert+renesas@glider.be,
        robh@kernel.org
Date:   Fri, 05 Aug 2022 18:18:34 +0800
In-Reply-To: <258c3ed7-2247-d4c3-73be-ddcddee3a3a0@linaro.org>
References: <20220804061133.4110734-1-victor.liu@nxp.com>
         <20220804061133.4110734-4-victor.liu@nxp.com>
         <258c3ed7-2247-d4c3-73be-ddcddee3a3a0@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1FaVkx2S1ZGWC9MV2RjMHR4ekhWekZXSjNxUUFhWXVNcnM1YmhCZERpa3o1?=
 =?utf-8?B?VUd3RThXZFo0V0s5aFJzdWhUUVVqcnduL1NEUEp5Q0JKYkE2TlZWdExXV3A2?=
 =?utf-8?B?d0lNSHRJRHl4UFFhcTU0NitqMjA5UXQ4aGZ6aVl5T0x1ZDN2Vmh5TEZ1V2FH?=
 =?utf-8?B?aUUzNEJ1U3R1WW51V1FzTWIwTFNyVnFacWV0SmIzS0hkNW9DL1dyK3JZclRx?=
 =?utf-8?B?T2c5N3FVVFczRHhGVnlucTRxSmhtZ2xzUG9WU1oyRjhxSHlHblkyTTE4d2FQ?=
 =?utf-8?B?MkNYNHVJcm9FdUNWbldxUkN5bUpJeGxLWGM4VTR1UkRpVkFCT0FVMy9wOUVB?=
 =?utf-8?B?bndqaGRTSGRualhuRzlJVjNobk5DTGxEUVhIWFhFcEhVaEU3ZGRreU9FbHg0?=
 =?utf-8?B?Y0pEUlEycnpaUE1id2IrRFlnWFBxelJheTlXMDhqNnFLRVpPeHltVzJxcGxN?=
 =?utf-8?B?UUtYK3h5QlF0MnloTFQwNWtRVXlvREFkTUcvaG43eHNzU0ZLNm9oYTAyVFlL?=
 =?utf-8?B?UWRXUEkyODZEQTJVeEpjOWt2dlB2UGkxWFFCSG96aFVhUUthZ0VQeXpHNmlt?=
 =?utf-8?B?WXl4ZmpkNURGSDBLSVBBWXV3Sis4cVVrdG8yZXRsL1p5MFlNSWdIRFE0T3N1?=
 =?utf-8?B?YnQ4V2RzbjVVeGpkWmh0UmxIOVY5MTYyQlBFalpCcTJEcDFNU3diVDdhbEUw?=
 =?utf-8?B?NU9UWGNNNjduL2tRQzA1SVVzYWZTUytpS3NMcXpNWjB0R253bGs2bVI3R0Yx?=
 =?utf-8?B?QVVncGUvN0JMQ2NtRi9saG5rTVl6Vzd6YTltTDhMSmNHMlZZQk5iZ0pIc3Fq?=
 =?utf-8?B?NXlIMi9PYTZhQkFFbFFMbTB6VklDdlMvaUFSZS9DVmZBajNnTzJzazgrbmRt?=
 =?utf-8?B?OHBZK2NIcUw1OWdKSHRueGUwRlY5M2RwSnpBZ0J1YWlGSG5yQWtHUlVxM3JD?=
 =?utf-8?B?MExEMDlNNUNqTEswTWpmbHhvVm5CdFVSSG03V1puTG9KUERWck5jU0t0M1B0?=
 =?utf-8?B?N29DSDRYMm1uYVpVOUJFUDZHcnNxUUJSazdMSVR4RHlyZEFDZUxNUTVVbVVK?=
 =?utf-8?B?MHBRVGJZYWdMbldkaDlzc1FTQUs2SjRhbWFXeE1BOS9WOUFLZGFDbytiRjVI?=
 =?utf-8?B?dXBwdXNNOERkdGJIdXBEQVAzY2VjVUtnR041bmYreTZaS3VrdCsyNlRvbjgz?=
 =?utf-8?B?enhQVE1jZW9ZY2NkMHJCbWpsY0Z0VG5yKzYyR3BzS1Z0YnR3Z2M4SUcyb0U5?=
 =?utf-8?B?dS8yZ1hJUG9mNnlTNFp4SExmZDFITkx0ZkJUeWdKSkM1T044amxEdGp5Z3VL?=
 =?utf-8?B?ME5xSGE2L1pEb3NpbnhmZUs5bmtpTVBHbmNxd3JtVndDczF1cUh4YmRyNWFo?=
 =?utf-8?B?cERCVDB0dUpzU1VWd0hBZ3FtY2wwVkZ0Ymc2TlZlWWZaZy84RldvL2tVcElt?=
 =?utf-8?B?aEV4bi8rTFc0UExKeEVSL0NaRGZpZDRyME00dmZaanZZQ1FjRC9ka1hqTDNC?=
 =?utf-8?B?cWZ1T1psb0p2cnBtL0JnUXlHTGRkYytHYVpiTWl3YTFKUzFHZzg4MFZqbkpv?=
 =?utf-8?B?QmxQK3puVmhvNEVuYy8zeTdwdkhDd1NRYXV2MlI5NEdNZ2JoMDJTUWVwWVNZ?=
 =?utf-8?B?K3RsQVVjMldUMUNYekNHaVBFQ2IzUTRuOVBSYXNGQXRnZXl6QUkvdFJPZlhZ?=
 =?utf-8?B?cXBpQU5ZbzM0L0dvSU9lMXdVeTlsRFlVQmdWT0svUnBkM1hNYlYybWtrdjRV?=
 =?utf-8?B?S0hGYmUwY0owQzh3MkVUMjZraDBHTjhPcE5lU3luUVVxZVFXZE5mQmQ5SDZl?=
 =?utf-8?B?T0VBUHNzYmxKbnpkVW1iR2pLTHVwOXhzYkMvNlgrOFArZWVBUmZBQWZNWXNK?=
 =?utf-8?B?Vk1MdGoydGlDNSsyMVN1dGpiWnBoaU02YTFhOVU4dzlCNUVTRW1sTGFPL21r?=
 =?utf-8?B?Y1VWOGtwcTRVOUEwY2wwa2Z0UHEvVlBpRTlDa0NyMmRCWGROaVU1d2VBVG1U?=
 =?utf-8?B?bkEwYnh2cHlub0huVGpyMnN6d2lWd25mdGpDUVV1bk9GWEc5YTBYYktZRUgx?=
 =?utf-8?B?SUdxK3d6dTArM2hoaVJuYmUxYXpYMU90TGFvV2NVTUFlRnQrbHhmeG9oYjlO?=
 =?utf-8?Q?YdiyJwJEQ7NSlHWpCxQsDCFEy?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5df765d8-c3c3-4402-8b8c-08da76cbdfba
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2022 10:18:43.2360
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zhi/CWljJdEP8A6+YWQ9EKPcDR/Phx21kVku4olFCQTWuqCPByu6OV9BiltXpjr7NpY98HRFgNL5P0fbUBW4cw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7881
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2022-08-04 at 13:17 +0200, Krzysztof Kozlowski wrote:
> On 04/08/2022 08:11, Liu Ying wrote:
> > Freescale i.MX8qxp pixel link MSI bus is a simple memory-mapped
> > bus.
> > It is used to access peripherals in i.MX8qm/qxp imaging, LVDS, MIPI
> > DSI and HDMI TX subsystems, like I2C controller, PWM controller,
> > MIPI DSI controller and Control and Status Registers (CSR) module.
> > 
> > Reference simple-pm-bus bindings and add Freescale i.MX8qxp pixel
> > link MSI bus specific bindings.
> > 
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> 
> Thank you for your patch. There is something to discuss/improve.

Thanks for the review.

> 
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/imx8-lpcg.h>
> > +    #include <dt-bindings/firmware/imx/rsrc.h>
> > +    bus@56200000 {
> > +        compatible = "fsl,imx8qxp-display-pixel-link-msi-bus",
> > "simple-pm-bus";
> > +        reg = <0x56200000 0x20000>;
> > +        #address-cells = <1>;
> > +        #size-cells = <1>;
> > +        interrupt-parent = <&dc0_irqsteer>;
> > +        interrupts = <320>;
> > +        ranges;
> > +        clocks = <&dc0_disp_ctrl_link_mst0_lpcg IMX_LPCG_CLK_4>,
> > +                 <&dc0_disp_ctrl_link_mst0_lpcg IMX_LPCG_CLK_4>;
> > +        clock-names = "msi", "ahb";
> > +        power-domains = <&pd IMX_SC_R_DC_0>;
> 
> The example should be complete, so you should have here children.
> Otherwise it is not a bus.

I may add some children whose compatible strings are in-tree for
i.MX8qxp. It seems that simple-pm-bus driver part(patch 1) will be
changed due to comments, so maybe I'll respin when it's ready.

Regards,
Liu Ying

> 
> Best regards,
> Krzysztof