Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <03f115b0-74ae-7793-5248-61df76ab184b@somainline.org>
Date:   Fri, 5 Aug 2022 13:02:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH 0/7] arm64: dts: qcom: sc8280xp: HID wakeup sources and
 alt. touchpad
Content-Language: en-US
To:     Johan Hovold <johan+linaro@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220805092317.4985-1-johan+linaro@kernel.org>
From:   Konrad Dybcio <konrad.dybcio@somainline.org>
In-Reply-To: <20220805092317.4985-1-johan+linaro@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5.08.2022 11:23, Johan Hovold wrote:
> This series clean up the sc8280xp CRD and X13s HID nodes somewhat and
> marks the keyboard and touchpad as wakeup sources.
> 
> Included is also support for the alternate (second-source) touchpad
> found on some X13s laptops. Note that the node is disabled for now as
> ideally the boot firmware should be determining which touchpad is
> actually populated.
Interesting, what bootloader is used on these? Are you chainloading
something on top of Qualcomm's XBL UEFI?

Konrad
> 
> With some additional fixes it is possible to have both nodes enabled and
> letting Linux do the probing, but let's wait for a conclusion to the
> discussion about whether that is desirable before enabling them both:
> 
> 	https://lore.kernel.org/all/YuJXMHoT4ijUxnRb@hovoldconsulting.com
> 
> Johan
> 
> 
> Johan Hovold (7):
>   arm64: dts: qcom: sc8280xp-crd: disable touchscreen pull-up
>   arm64: dts: qcom: sc8280xp-crd: move HID pin config
>   arm64: dts: qcom: sc8280xp-crd: mark HID wakeup sources
>   arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: disable touchscreen
>     pull-up
>   arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: move HID pin config
>   arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: mark HID wakeup
>     sources
>   arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate
>     touchpad
> 
>  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 22 +++++++++--
>  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    | 38 +++++++++++++++++--
>  2 files changed, 54 insertions(+), 6 deletions(-)
>