Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 5 Aug 2022 11:51:39 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>
Cc:     Stephen Boyd <swboyd@chromium.org>,
        Mark Brown <broonie@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_collinsd@quicinc.com,
        quic_subbaram@quicinc.com, quic_jprakash@quicinc.com,
        Lee Jones <lee@kernel.org>
Subject: Re: [PATCH V15 6/9] mfd: pm8008: Use i2c_new_dummy_device() API
Message-ID: <Yuz2O+lZ5W7RviuA@google.com>
References: <Yr6oLlmfWRkiAZG7@google.com>
 <52c6ab15-1cd8-324e-4bcc-c449d8bceb19@quicinc.com>
 <Yr66ZZqEnBApHYMA@google.com>
 <0481d3cc-4bb9-4969-0232-76ba57ff260d@quicinc.com>
 <YsLhxx+L3+GJDRyO@google.com>
 <bcc5f059-b991-296a-bba6-9cb1236097f2@quicinc.com>
 <Ys1tYAO39LKzEAOE@google.com>
 <dc737abb-041b-491a-14f1-a584f9e64a3d@quicinc.com>
 <CAE-0n528QaTtZFp=WAaHShegFRpKVN_67jQfUJTtsRPr6s--zA@mail.gmail.com>
 <52039cd1-4390-7abb-d296-0eb7ac0c3b15@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <52039cd1-4390-7abb-d296-0eb7ac0c3b15@quicinc.com>
Precedence: bulk

On Tue, 02 Aug 2022, Satya Priya Kakitapalli (Temp) wrote:

> 
> On 7/27/2022 6:49 AM, Stephen Boyd wrote:
> > Quoting Satya Priya Kakitapalli (Temp) (2022-07-21 23:31:16)
> > >               regulator-name = "pm8008_l6";
> > >           };
> > > 
> > >           pm8008_l7: ldo7@4600 {
> > >               reg = <0x4600>;
> > >               regulator-name = "pm8008_l7";
> > >           };
> > >       };
> > > };
> > > 
> > > 
> > > Stephen/Mark, Please do let me know if you are OK with this design.
> > > 
> > I was happy with the previous version of the DT node. That had one node
> > for the "pm8008 chip", which is important because it really is one
> > package. Why isn't that possible to implement and also register i2c
> > devices on the i2c bus for the second address?

If devices have different addresses, they should have their own nodes, no?

> If we add everything under single DT node i.e., 0x8 device, then, we have to
> use i2c_new_dummy_device() to register 0x9 device, and pass regmap etc to
> child(which Lee is not OK with). Even if I register the regulators as i2c
> devices, I am not sure how we can retrieve the 0x9 regmap in the LDO probe,
> because when I use dev->parent there, it refers to 0x8, as I am adding
> everything under 0x8.
> 
> 
> To implement what Lee suggested here [1], I will have to add two devices
> separately in the DT.
> 
> [V15,6/9] mfd: pm8008: Use i2c_new_dummy_device() API - Patchwork
> (kernel.org) <https://patchwork.kernel.org/project/linux-arm-msm/patch/1655200111-18357-7-git-send-email-quic_c_skakit@quicinc.com/#24933901>

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog