Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp1621873rwb; Fri, 5 Aug 2022 05:19:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR5vquZFwuw2qYHPpZr7wcH8qWKyWny8aLbP6y95EtLDUENZVxFhxAt9M9E41d1RAkYOuGqG X-Received: by 2002:a05:6402:4301:b0:43e:4d31:6ec0 with SMTP id m1-20020a056402430100b0043e4d316ec0mr6638747edc.69.1659701970630; Fri, 05 Aug 2022 05:19:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659701970; cv=none; d=google.com; s=arc-20160816; b=JF7T5GGuTIDnoOaTMdKey0VU/5nG/nTiHEqYluXTAxXICvRzANy/cd8oFoWoBBaF/3 rMwRzubP5EOzBCUwKzwkd37JXbn2lc3ba34txQR3+GMZa4mtJbk0NIBgiVQSG3XjAtd3 AYw+pdB1+GhdSovCsLVH61pGKTqeGRzV6D8HG0OtVACkZnnmXFqbpAbZ288tHi0D0CQT XOZbh4/XI4oPDlKnz7Vdse0oy0b2NI6MQin1U2dLdSn6nUFekpdxExrNjIpDXgsdWTXK 5+FRLtpONS/ETefm4/u43egCifzeiChLCAAg7r3sUQHREJqiElCoApV0TF4cmvHTGEfi 8mnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KDSpTeRa8VFUkCTQ464v8hru0+MimQzZySyXbnHjnv8=; b=y6QjkeYmUkSBJfiGFOnQ4GGcwMR0DZmP34ffUnMyEwdnu4Zb8qsSBfhsNcPkag5Uea F9rHiBpvn1JCnHstK3a/bhvzwpi2/zV6MXzaq8II6ZHhD2Wxcs7uxXfxj1V/THxpHALH d43Xn8SRz0kECSKXIbj5WsqFpFa2SnzTDIrz+z6FS5bJ7GaJWDPKwgeXQ/VfbH2AaC4B s8jRvQitTb3ZDFKiCYqtrB9G/Pg+R8qjW6zk9wgMH90dfzXxmpxQgygrDsCLC6Bz+2DF 043Z3vhxLQpue13e7YVq9o720IQPhx0TUPZA5Ef9seOLNPBNr2wqN7I/jMfIfQLSQ+6C bdPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ppfklYZL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c12-20020a05640227cc00b0043cdddef31dsi826258ede.303.2022.08.05.05.19.05; Fri, 05 Aug 2022 05:19:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ppfklYZL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237742AbiHELr5 (ORCPT + 99 others); Fri, 5 Aug 2022 07:47:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233062AbiHELr4 (ORCPT ); Fri, 5 Aug 2022 07:47:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D27B231238; Fri, 5 Aug 2022 04:47:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 913C2B82884; Fri, 5 Aug 2022 11:47:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35365C433C1; Fri, 5 Aug 2022 11:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659700073; bh=JMMJeixBs3l9ubdtNRBE7DXk1PsGjT8Uuky1AgfqSc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ppfklYZLyx6qK75yBrHA6LYRgkcnNugJOsJPgFXVl1oESd225AcOJiQUjBSJErSh7 Nr7eLrI1Izyj+wsSCjb70hLOIgovFxqfcbnNvRTzIOx5A8JhQukJESNoHLFwJYFN29 pFFgWqs1m4VUPVbIkEIYLwpj4+tXPBCx1cuwljDLRurGUntZ3gEZUTZfsGEeEtVpM/ O1IDYP2ShQNUF0bOlWOoSPlbedqgeF+Q6QrldusqfsbIsPh2KszsgCAuUvg2106tvL 10+x9xMMk09P6Nr+ay6dAmdyupB4+aIim2OtUj6Z9dbOIWB/UvZeCmGi2LmORIWcW/ nZzfAUgLelbZQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oJvoO-0002Nk-Uk; Fri, 05 Aug 2022 13:48:17 +0200 Date: Fri, 5 Aug 2022 13:48:16 +0200 From: Johan Hovold To: Amireddy mallikarjuna reddy Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, malliamireddy009@gmail.com, arun.pappan@ftdichip.com, sowjanya.reddy@ftdichip.com Subject: Re: [PATCH v1] USB: serial: ftdi_sio: add IDs for NEW FTDI Products Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2022 at 03:02:44PM +0800, Amireddy mallikarjuna reddy wrote: > Add the product IDs for the USB-to-Serial devices FT2233HP, FT2233HP, > FT4233HP, FT4232HP, FT233HP, FT232HP, and FT4232HAQ. > Also include BCD values so that the chiptype can be determined. > > Signed-off-by: Amireddy mallikarjuna reddy > --- > v1: > - Initial version. Thanks for the patch. This looks mostly good even I should revisit some clean-up patches I have laying around that gets rid of the unnecessary device-type conditionals that you're now extending. I'll either rebase this patch on top or the other way around, but either way I'll get this in in some form in a few weeks (e.g. after the merge window closes). Johan