Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6556c478-976c-27f1-ad9b-606fe47f7ce1@gmail.com>
Date:   Fri, 5 Aug 2022 20:31:33 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v3] PCI: update the links for aer-inject git tree
Content-Language: en-US
To:     Huang Shijie <shijie@os.amperecomputing.com>, bhelgaas@google.com
Cc:     patches@amperecomputing.com, zwang@amperecomputing.com,
        darren@os.amperecomputing.com, corbet@lwn.net,
        yangyicong@hisilicon.com, linux-pci@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220805105238.345599-1-shijie@os.amperecomputing.com>
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <20220805105238.345599-1-shijie@os.amperecomputing.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/5/22 17:52, Huang Shijie wrote:
> The aer-inject tree has been moved to:
>     https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git
> Update the links.
> 
> Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com>
> ---
> v1 --> v2: Modified the commit message and the title.
> v2 --> v3: Change the commit message again.
> ---

The change log could have been before the diffstat below (so it won't be
displayed on git log when applied).

>  Documentation/PCI/pcieaer-howto.rst | 2 +-
>  drivers/pci/pcie/Kconfig            | 2 +-
>  drivers/pci/pcie/aer_inject.c       | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/PCI/pcieaer-howto.rst b/Documentation/PCI/pcieaer-howto.rst
> index 0b36b9ebfa4b..b31fc9a0edbc 100644
> --- a/Documentation/PCI/pcieaer-howto.rst
> +++ b/Documentation/PCI/pcieaer-howto.rst
> @@ -294,7 +294,7 @@ After reboot with new kernel or insert the module, a device file named
>  Then, you need a user space tool named aer-inject, which can be gotten
>  from:
>  
> -    https://git.kernel.org/cgit/linux/kernel/git/gong.chen/aer-inject.git/
> +    https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git/
>  
>  More information about aer-inject can be found in the document comes
>  with its source code.
> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> index 788ac8df3f9d..d6ea0fd9892d 100644
> --- a/drivers/pci/pcie/Kconfig
> +++ b/drivers/pci/pcie/Kconfig
> @@ -43,7 +43,7 @@ config PCIEAER_INJECT
>  	  error injection can fake almost all kinds of errors with the
>  	  help of a user space helper tool aer-inject, which can be
>  	  gotten from:
> -	     https://git.kernel.org/cgit/linux/kernel/git/gong.chen/aer-inject.git/
> +            https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git/
>  
>  #
>  # PCI Express ECRC
> diff --git a/drivers/pci/pcie/aer_inject.c b/drivers/pci/pcie/aer_inject.c
> index 2dab275d252f..262b06b0dc1d 100644
> --- a/drivers/pci/pcie/aer_inject.c
> +++ b/drivers/pci/pcie/aer_inject.c
> @@ -6,7 +6,7 @@
>   * trigger various real hardware errors. Software based error
>   * injection can fake almost all kinds of errors with the help of a
>   * user space helper tool aer-inject, which can be gotten from:
> - *   https://git.kernel.org/cgit/linux/kernel/git/gong.chen/aer-inject.git/
> + *   https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git/
>   *
>   * Copyright 2009 Intel Corporation.
>   *     Huang Ying <ying.huang@intel.com>

Otherwise looks OK.

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara