Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp1786351rwb; Fri, 5 Aug 2022 07:48:26 -0700 (PDT) X-Google-Smtp-Source: AA6agR6D2gRX9/QvFnW+6SCoPelGSvw/ov3nm3u7sooQ6KsJNVCqJiCN97kOYCRTXlJhLmEOR1xx X-Received: by 2002:a63:560e:0:b0:41c:590a:62ed with SMTP id k14-20020a63560e000000b0041c590a62edmr6204746pgb.250.1659710906240; Fri, 05 Aug 2022 07:48:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659710906; cv=none; d=google.com; s=arc-20160816; b=Z6/prqdOwm6yWY4Q7NYXcxULutDYsRNFqf6IyLPZmz7OKzZ3gFzepJHiYDarNH5Ve0 59zBXTD9vOcBI6OQ2SDj6tPPJ1Kj+ze0QYBd1qdb7t+fqV58BnZ6y57of7CWSLgBnF/7 jrRu9QeCItBYtUUhgPAzRTIugZwfO4PNpGLrOB5QdNICzLDgdC92lploLcAYAymjTnKA SOr4b33Uus2R8e7BKflululKBjCtpqvs5WvXd2VLVDSMDUB18eO2SHh+vLd7++nmW2lr O/2xsUiFtREgm1hxLkUE5+49/EMO3rWNhklkG3UefiGJs72TEUQdeomKoCVfTFRo+dsa gwrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=KBHblqB033On8iyxviJajlqGBNdVHnA7KT9CW2gE/Lw=; b=e/7DU9fLie/aL1RijNHNqTwt73Mbesw/zLWUk4ESeucnmYoH+61oaqYKvyCFVaXLj2 h1iFl/SBUFvq7pACVxdYdqHjY4VN5hNXkvVsgO18rjlyYDaaufUjUKo5YrNS5KjcvoZa DAcspIGJzq4T8yyCCJ9uZQ18bU6xfC0r/1fxbjv9qci86L9vSogF0uEENRBYpnm9l4x8 +yNvWbWSUOAGriAiEfb1khjb8hSV0hpb2yRWkCUyBPLgACZsJOHtOP3+DrzoKAG6GQIi OblCAkLQBEvHJLL9/0Q9rjThSP8a0rI2XsvpnNdAXUt+f+UafFzS4UXk+8Y7CGj0ec2F 6i6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=nmsuo8O3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mh16-20020a17090b4ad000b001f317742b05si4954014pjb.145.2022.08.05.07.48.10; Fri, 05 Aug 2022 07:48:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=nmsuo8O3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240663AbiHEOEj (ORCPT + 99 others); Fri, 5 Aug 2022 10:04:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230095AbiHEOEi (ORCPT ); Fri, 5 Aug 2022 10:04:38 -0400 Received: from mail.sberdevices.ru (mail.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B3351F2CE; Fri, 5 Aug 2022 07:04:36 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mail.sberdevices.ru (Postfix) with ESMTP id DA4E85FD06; Fri, 5 Aug 2022 17:04:34 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1659708274; bh=KBHblqB033On8iyxviJajlqGBNdVHnA7KT9CW2gE/Lw=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=nmsuo8O3gjphxB1Y+GR8qX5k5BykpoyJSqR+ckPCrQ5Cj979RpcfWQwAaD0ZD3Q40 XJ3/8drpy5pv699lF8DRllZvu6LPobl3Vfc1k9AHbQSzJqlux8AsCE3xOO8OBvtgPE GftZHWSXtpS4wAx9Bd7/Adj51D3qcr6ASlCCM2DEVhdrCp4ijyTXpTwndVfRaBD4/C vSJk1OZGGMXuW4QcZIjCnN21XQIe+P0SP3CcQd97dKCVr1qFKw1a8eJmnIygxINnnu cG2jlfmiK1e9kjrShzeLrebOSSE4MopfN2I2NhUMGyLNIgdf7NocCiEDmH309UtAPE Tt5nY+m4VEGSA== Received: from S-MS-EXCH02.sberdevices.ru (S-MS-EXCH02.sberdevices.ru [172.16.1.5]) by mail.sberdevices.ru (Postfix) with ESMTP; Fri, 5 Aug 2022 17:04:34 +0300 (MSK) From: Dmitry Rokosov To: Andy Shevchenko CC: "robh+dt@kernel.org" , "stano.jakubek@gmail.com" , "shawnguo@kernel.org" , "jic23@kernel.org" , "lars@metafoo.de" , "stephan@gerhold.net" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , kernel , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 2/3] iio: add MEMSensing MSA311 3-axis accelerometer driver Thread-Topic: [PATCH v4 2/3] iio: add MEMSensing MSA311 3-axis accelerometer driver Thread-Index: AQHYpzqIoQnaRj7vNkq2cXUUGjAB/62dQgeAgAAYQICAAYHbgIAAA5UAgAFIGQA= Date: Fri, 5 Aug 2022 14:04:06 +0000 Message-ID: <20220805140430.c773smfzxg5zcj4b@CAB-WSD-L081021.sigma.sbrf.ru> References: <20220803131132.19630-1-ddrokosov@sberdevices.ru> <20220803131132.19630-3-ddrokosov@sberdevices.ru> <20220803191621.tzrmndkygfe7nlpx@CAB-WSD-L081021.sigma.sbrf.ru> <20220804181723.4bljpxcwkj6cnn2f@CAB-WSD-L081021.sigma.sbrf.ru> In-Reply-To: Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-Type: text/plain; charset="us-ascii" Content-ID: <2569579201B2C14EB99D8D1151005A20@sberdevices.ru> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/08/05 06:43:00 #20054623 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 04, 2022 at 08:30:12PM +0200, Andy Shevchenko wrote: > > > > > + dev_err(dev, "cannot %s register %u from debugfs = (%d)\n", > > > > > + readval ? "read" : "write", reg, err); > > > > > > > > You may consider taking [1] as a precursor here and use str_read_wr= ite(). > > > > > > > > [1]: https://lore.kernel.org/linux-i2c/20220703154232.55549-1-andri= y.shevchenko@linux.intel.com/ > > > > > > Oh, really... Thank you for suggestion! > > > > I have taken it closer, and it's really helpful and nice, but looks lik= e > > it's not merged to linux-next. > > Please advise how I can use it in the driver. Should I provide > > "Depends-On:" tag as I did for my HZ units patchset? >=20 > No, just take that patch into your series. Do you mean include your patch to this reply-thread through the message-id linking? If my understanding is correct, maybe also it's better = to include HZ units series to the current series? I mean patch series on below link: https://lore.kernel.org/linux-iio/20220801143811.14817-1-ddrokosov@sberdevi= ces.ru/ --=20 Thank you, Dmitry=