Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com, Shenwei Wang <shenwei.wang@nxp.com>,
        Nicolas Diaz <nicolas.diaz@nxp.com>
Subject: [PATCH v2 1/1] serial: fsl_lpuart: RS485 RTS polariy is inverse
Date:   Fri,  5 Aug 2022 09:45:29 -0500
Message-Id: <20220805144529.604856-1-shenwei.wang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qx/iWtlWVyLE3li/lssuB5TqF+dLKh0NjmIqByrURHrWgOlVJagrIWuFYlL9?=
 =?us-ascii?Q?j9xyS1aUp41N3VAdj91JelfvS2HGPFOzsFNWlg/a8OO8I8LB4sP+CFC+qmZi?=
 =?us-ascii?Q?f0TYdAE1dnjwZHNIurkSzBZpOkJQCG19RkCXwNoUlD0i44/bieeLPDfS4hgg?=
 =?us-ascii?Q?Fkf4+sprkTIY/aRpZoTGCjqR2gcXqdyZUT5CFiyZ02bMYJRARBqF8xjzVNfa?=
 =?us-ascii?Q?wftlVLi2+rdFXFYYDfhaTKcXdo+Z/4nP/2DLQt1+ysXswVpqXcopVPwR6SzP?=
 =?us-ascii?Q?ThYStitBp9skEX7VAHqIjmy6FCF20ohWKmvCdsvT+aRgv14Gho8wJBt56hoi?=
 =?us-ascii?Q?6++2eM5RhQ/A1KznS3DqphmIxQnmGyRLezaPzzY37EMqbFBbzGve+TGCQE48?=
 =?us-ascii?Q?XfnXLoNt82WP/VlmZoHnjP8hYhCTfZR9R9fWUeswU03coeAWpJs3mpYeM08m?=
 =?us-ascii?Q?981E40TDUTMho5OVDV73z1x0vwsuZjMf3EFdIGsN/Q3OIj2xmVD3QxBOYe+9?=
 =?us-ascii?Q?GVRY9HZclg4ntnStas0nd4AFvK0DjB46tIa2k442k3SPdXCpTZCIp6+k5TVx?=
 =?us-ascii?Q?l3lybAPalKlaORgmP/JWujULeAJzxdTGYxbr1YJT9y/nw7aRzV60MQ7ShfPx?=
 =?us-ascii?Q?Rn4nOFOdeH+ETGZ8lmaUJ2o1uoiFdMPX34yuAnYVXcmVg4IzsxeMjmVj74QW?=
 =?us-ascii?Q?WumaStgZFgW225TVhEhIPWmX5ITZda01jQs4/8t0YS+Rp/1iT5mLX0s+cB0R?=
 =?us-ascii?Q?JRnDgjRL97fl63jn8fHQaOiGC/TZYywa6BkK/R4iM/UvBFW1l+njAevqs0dX?=
 =?us-ascii?Q?qlFFoLgJ0CE45aT74FBXK0wYlOq0Bi20wnvw1J567mustR7UEqQwp1Rax6RI?=
 =?us-ascii?Q?ZTfw8WT8u6C6bpH5pFbFKXkPz47Z9tmcsqETvF0rwieGLOj06BaWAEW9Zvj+?=
 =?us-ascii?Q?zyGfH23D64jdPE95YfxJc0demMqb6yRfICdmptIK+yjzwkVolM3AYTe1W1sg?=
 =?us-ascii?Q?PGwXJXMIP83XRkWLngdjMwPhTCL3XIkORopwP3RJg/RAx1fz6YNk3fqASIIh?=
 =?us-ascii?Q?VLToJscNzNUHtNUXr61tp2qYa5FKf2WuX+HW6e5EODe/4NuDcRtc2steWYU4?=
 =?us-ascii?Q?jBvTvYSMbXQS2/yK+qR0wUHy+fmHB4JJiPCkoyq8HzPa+3t61+Uem5SgRyD1?=
 =?us-ascii?Q?GyTtFPfL9sG4R+oAANBoWvylL7PnO+eYYZPINVcBFzywVES1yMJ965fExyfT?=
 =?us-ascii?Q?MRxmboy1vwQwEX1UP86MES9I6ZkzzLkgH2LZxqbS2Lf07Rv/uP/q+A9cqBo/?=
 =?us-ascii?Q?yNRhHUN+a0cdcNvq+Hn7/+9QH6mfNrQ7/woMkUV7Z7Pyzy60V98dHgWQAX0z?=
 =?us-ascii?Q?dwCNyP+m+yU/z0rmBjF+OUtJEr5KgB430alMVajw/vB4Q1JIOg4zDpUbgG7M?=
 =?us-ascii?Q?5zraYGxvS+35IZ3aGv3JfIYAWheMGAuT4TMV3wsaOoWixRpGXQ1H1p0JCoJe?=
 =?us-ascii?Q?scPOIwYStu8EauYoH+CadzNpzOmKABPT3orTY7nB0MSfrQJdAqhS4ChvVfCt?=
 =?us-ascii?Q?hGcBBB8TOtLaGSuB8uVQJ6kzJP/cma+HEDrmXbKjhbdX2qpPGKCye0RIq++m?=
 =?us-ascii?Q?Gg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3d39de2-27e8-4cf5-62d9-08da76f13285
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8274.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2022 14:45:53.5020
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pGXCj8y96XGIHE7z3pOoGJ4QCVC4p0PBeWqBdjxN7yR+53gmHCA7HRhre9WLoTB8c6v8DwcOkCQcxzhgnv/nhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6811
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The setting of RS485 RTS polarity is inverse in the current driver.

When the property of 'rs485-rts-active-low' is enabled in the dts node,
the RTS signal should be LOW during sending. Otherwise, if there is no
such a property, the RTS should be HIGH during sending.

Fixes: 03895cf41d18 ("tty: serial: fsl_lpuart: Add support for RS-485")

Signed-off-by: Nicolas Diaz <nicolas.diaz@nxp.com>
Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>

---
changes in v2:
- add the fix tag

 drivers/tty/serial/fsl_lpuart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index afa0f941c862..abc3a3674bc3 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1394,9 +1394,9 @@ static int lpuart_config_rs485(struct uart_port *port, struct ktermios *termios,
 		 * Note: UART is assumed to be active high.
 		 */
 		if (rs485->flags & SER_RS485_RTS_ON_SEND)
-			modem &= ~UARTMODEM_TXRTSPOL;
-		else if (rs485->flags & SER_RS485_RTS_AFTER_SEND)
 			modem |= UARTMODEM_TXRTSPOL;
+		else if (rs485->flags & SER_RS485_RTS_AFTER_SEND)
+			modem &= ~UARTMODEM_TXRTSPOL;
 	}

 	writeb(modem, sport->port.membase + UARTMODEM);
--
2.25.1