Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9fb73284-7572-5703-93d3-f83a43535baf@amd.com>
Date:   Fri, 5 Aug 2022 11:32:33 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: mainline build failure for x86_64 allmodconfig with clang
Content-Language: en-US
To:     Nathan Chancellor <nathan@kernel.org>,
        Arnd Bergmann <arnd@kernel.org>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>
Cc:     clang-built-linux <llvm@lists.linux.dev>,
        David Airlie <airlied@linux.ie>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>
References: <YuwRyQYPCb1FD+mr@debian>
 <CAHk-=whptVSSZL=wSUQJdRBeVfS+Xy_K4anQ7eQOky7XUrXhUQ@mail.gmail.com>
 <CAK8P3a2bEaExue0OtNeLa2CVzBx-1dE9w2HZ2PAV5N8Ct9G=JQ@mail.gmail.com>
 <YuwvfsztWaHvquwC@dev-arch.thelio-3990X>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <YuwvfsztWaHvquwC@dev-arch.thelio-3990X>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFNYM0l3dE45R0d2MFFBbS9Qb3JCaEdETjkxNDZndGJiUkRCVkJuenRDelRu?=
 =?utf-8?B?Z1ZGdEdrVE1rbmM5VEtIV2NVVXJaV3hjZ1IxMnB3dHdxS256VXRHV1o0NGFY?=
 =?utf-8?B?Z21uVm9hZlllMHl5cGFEeXhwTUxhRVJtUWpha1dlcnZZdis5M29EZHVPdUZE?=
 =?utf-8?B?S0luL056M1JCOEdCVjVwVmYvOFFFNHozWnhoeHAzQ3lHckFaM3NWd0tFL3gz?=
 =?utf-8?B?dEl0UHBRK0VkNFlmSTkvNWV3RUlGTGFhU3hpMkxGZ1RFTklvc3NCSXFNSC94?=
 =?utf-8?B?anFBOTRBbW9zdElhR1Y5NVdxdkpwSVNCZ0RQV1FOb2toOTQwQnhBM29nQ0NI?=
 =?utf-8?B?cUt6dmg5V2UvTXp4cGJaL2lQTUVNTGxlTkJ1TlFMcTlDMnpKeE1SakEzR3J6?=
 =?utf-8?B?N0JPSEdFMFVWQ1JuTzZxWU1VblVmTUdMWHVRaXVIVWFjNEc3OWNjc0dFbFJk?=
 =?utf-8?B?K1B4ZVZ4R1NBRFVheHJpRWlyaE5rOWhNRThub2F2TDRwUW4xdHhRVEJyK1V5?=
 =?utf-8?B?TmhsTW15YVdWUTdVMTZyYjBPUmtPOVYwUytybE12ekhVZUVWQXNTSjJzUjFU?=
 =?utf-8?B?ZEtLaEl5Ymg1YUJUL3E5ZTdLbUF4ZUI4ZEZkWGpRbWRvS3ZLeGZSQlB0NjBC?=
 =?utf-8?B?QS9vMjNRUis3ZzJRVVdIczVRdnc0Y1FDSDhHVloxNFpCdWEzRU0xUm1TYU5l?=
 =?utf-8?B?Qm5aZWhSUUdTKzhDZ29FeTRBNHdMWWhGWnhYUlNIY2JEWmV4cWZ0UDBzdDNJ?=
 =?utf-8?B?NUw1N1RNYnVNc3lmZUFsNVBTSDljWUttWEhIMlU1cUxQc0x4RmdjeWFIWVlF?=
 =?utf-8?B?Wk1iNUZKdDJnR1cyVlp0VkpmQ1lJd2pCVWEreXhGZEp3dHoyNmdybm9RUE5M?=
 =?utf-8?B?eTMyVlZBZ2FkVkJNcWIxbXRINk9XUzR1eUpuWDk1SFNqWHVUYUxDaUJZdFVn?=
 =?utf-8?B?aEpNd09yNkpvNXoxSm1WVGtYd0ZQMGYwdWlqKyswWmg5bHdJLzhxdFdaNEpa?=
 =?utf-8?B?dHZsVkEyaFdIS3BuZmVQRFVEczAvZ1pSaFdJbTNqSFphbi9RUWZYSkpQSXRn?=
 =?utf-8?B?RUdhMzNhQzdrZkcwWnBZY3JhS2ZMcHBhKyszKzhQQTN5VWRiZUYvKzhMZFNC?=
 =?utf-8?B?L2w1TTJmSTF5NEE0R1pxOXp5bk5sdHREeEFlRU01dmw0T3I5T2hEU0FMZGpn?=
 =?utf-8?B?aHIxL1NlS1pFanR5amdXU01GNVlxeGNzR2R4dXg1T1UrMWdTWXpYSmdXSlkr?=
 =?utf-8?B?c3hHSlpNRkZlWGdnODNvZnlCQS9ZdU5uSk9SM0lydWRRZ3praDVSZ2t1eHBu?=
 =?utf-8?B?Y1JIbWZ2a3VkOHhBalhzZ1lvOWRHbXlva2oxNUZ3TFZBWU1BU1gwTVBRVE1N?=
 =?utf-8?B?bGJjeGNtSkE3VTFJRmhpVTFBUnZTRWtKSWJ4S01hME5aWG9HQ29QT1NJV0ZR?=
 =?utf-8?B?VVk4eitZTk9jaFFQNytMT3JFTmhSL0RoaGlyUkJpazlRKzhvREY2U2lmeTRJ?=
 =?utf-8?B?YytBUDdVbEYzY2xOVCt2aTFhZVMyeDJJeENmZjhVbVVFQlFlak1nTmVpaE96?=
 =?utf-8?B?RTVGQnErZ2EvSXlZN1pteVJvM2llOS9oOUY1S1I3NFNNelFweWVabzg4bEk4?=
 =?utf-8?B?K2MvNTVPTzl4MW9acmViVFhEckhNTFNobmNGd3JEZHBEL3VQWUdXS0taS3VE?=
 =?utf-8?B?WTE4TTNuelRkYTZNdWVOb2pvaTJMSHJ1VS82OVFzaWw2V2JkZmhySXpOSW0z?=
 =?utf-8?B?c0dLd1llSlZuaDFESzFvbUR0Zk10VTRVRk1pY1ROMWhTK3RmOVF4M2NRY3FL?=
 =?utf-8?B?ZHliK2c3NjRIYnc0VitqT2JlRmFFQlBXMkFOcVpzVFFLS2hpbThpUzZYVUhG?=
 =?utf-8?B?QzNjbEt4WXlrNXUzcFh2LytDWE9kejUwck45ZU85Mi9HdmtGazRQL0MrVE5N?=
 =?utf-8?B?Zm5XdXl5U0xXVzF6Ry9XcXJKOUhiL1NSWVAzb3VlV2pkSUdCalgyUS9vcS9Z?=
 =?utf-8?B?S0R2RVhpS2U1VVRZNWl2T1RpeUpoYXlqRW1EaEhob0ludDJQNFJGWDRUZzBh?=
 =?utf-8?B?djdWeHdWTjZCaUlaYVNzT091aEVUUlVFTjZYeEJ1a1pXNVNJS3lJbFlFWmlV?=
 =?utf-8?Q?78WXxl1fFIdK8bz/oFuZMsMlX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5439a39a-c8e3-46f0-be19-08da76f7b996
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2022 15:32:37.1665
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EaVVBpccmC5z+gQw3qi8ranypnllouM0UVcLBmdHjypl0MMG473Nk+rkYpgPIBcjk0JmiJCsThb47Wqx5Hn+kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3163
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-08-04 16:43, Nathan Chancellor wrote:
> On Thu, Aug 04, 2022 at 09:24:41PM +0200, Arnd Bergmann wrote:
>> On Thu, Aug 4, 2022 at 8:52 PM Linus Torvalds
>> <torvalds@linux-foundation.org> wrote:
>>>
>>> On Thu, Aug 4, 2022 at 11:37 AM Sudip Mukherjee (Codethink)
>>> <sudipm.mukherjee@gmail.com> wrote:cov_trace_cmp
>>>>
>>>> git bisect points to 3876a8b5e241 ("drm/amd/display: Enable building new display engine with KCOV enabled").
>>>
>>> Ahh. So that was presumably why it was disabled before - because it
>>> presumably does disgusting things that make KCOV generate even bigger
>>> stack frames than it already has.
>>>
>>> Those functions do seem to have fairly big stack footprints already (I
>>> didn't try to look into why, I assume it's partly due to aggressive
>>> inlining, and probably some automatic structures on stack). But gcc
>>> doesn't seem to make it all that much worse with KCOV (and my clang
>>> build doesn't enable KCOV).
>>>
>>> So it's presumably some KCOV-vs-clang thing. Nathan?
> 
> Looks like Arnd beat me to it :)
> 
>> The dependency was originally added to avoid a link failure in 9d1d02ff3678
>>  ("drm/amd/display: Don't build DCN1 when kcov is enabled") after I reported the
>> problem in https://lists.freedesktop.org/archives/dri-devel/2018-August/186131.html>>>
>> The commit from the bisection just turns off KCOV for the entire directory
>> to avoid the link failure, so it's not actually a problem with KCOV vs clang,
>> but I think a problem with clang vs badly written code that was obscured
>> in allmodconfig builds prior to this.
> 
> Right, I do think the sanitizers make things worse here too, as those get
> enabled with allmodconfig. I ran some really quick tests with allmodconfig and
> a few instrumentation options flipped on/off:
> 
> allmodconfig (CONFIG_KASAN=y, CONFIG_KCSAN=n, CONFIG_KCOV=y, and CONFIG_UBSAN=y):
> 
> warning: stack frame size (2216) exceeds limit (2048) in 'dml30_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> warning: stack frame size (2184) exceeds limit (2048) in 'dml31_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> warning: stack frame size (2176) exceeds limit (2048) in 'dml32_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> 
> allmodconfig + CONFIG_KASAN=n:
> 
> warning: stack frame size (2112) exceeds limit (2048) in 'dml32_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> 
> allmodconfig + CONFIG_KCOV=n:
> 
> warning: stack frame size (2216) exceeds limit (2048) in 'dml30_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> warning: stack frame size (2184) exceeds limit (2048) in 'dml31_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> warning: stack frame size (2176) exceeds limit (2048) in 'dml32_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> 
> allmodconfig + CONFIG_UBSAN=n:
> 
> warning: stack frame size (2584) exceeds limit (2048) in 'dml30_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> warning: stack frame size (2680) exceeds limit (2048) in 'dml31_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> warning: stack frame size (2352) exceeds limit (2048) in 'dml32_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> 
> allmodconfig + CONFIG_KASAN=n + CONFIG_KCSAN=y + CONFIG_UBSAN=n:
> 
> warning: stack frame size (2504) exceeds limit (2048) in 'dml30_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> warning: stack frame size (2600) exceeds limit (2048) in 'dml31_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> warning: stack frame size (2264) exceeds limit (2048) in 'dml32_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> 
> allmodconfig + CONFIG_KASAN=n + CONFIG_KCSAN=n + CONFIG_UBSAN=n:
> 
> warning: stack frame size (2072) exceeds limit (2048) in 'dml31_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than]
> 
> There might be other debugging configurations that make this worse too,
> as I don't see those warnings on my distribution configuration.
> 
>> The dml30_ModeSupportAndSystemConfigurationFull() function exercises
>> a few paths in the compiler that are otherwise rare. On thing it does is to
>> pass up to 60 arguments to other functions, and it heavily uses float and
>> double variables. Both of these make it rather fragile when it comes to
>> unusual compiler options, so the files keep coming up whenever a new
>> instrumentation feature gets added. There is probably some other flag
>> in allmodconfig that we can disable to improve this again, but I have not
>> checked this time.
> 
> I do notice that these files build with a non-configurable
> -Wframe-large-than value:
> 
> $ rg frame_warn_flag drivers/gpu/drm/amd/display/dc/dml/Makefile
> 54:frame_warn_flag := -Wframe-larger-than=2048

Tbh, I was looking at the history and I can't find a good reason this
was added. It should be safe to drop this. I would much rather use
the CONFIG_FRAME_WARN value than override it.

AFAIK most builds use 2048 by default anyways.

> 70:CFLAGS_$(AMDDALPATH)/dc/dml/dcn30/display_mode_vba_30.o := $(dml_ccflags) $(frame_warn_flag)
> 72:CFLAGS_$(AMDDALPATH)/dc/dml/dcn31/display_mode_vba_31.o := $(dml_ccflags) $(frame_warn_flag)
> 76:CFLAGS_$(AMDDALPATH)/dc/dml/dcn32/display_mode_vba_32.o := $(dml_ccflags) $(frame_warn_flag)
> 
> I suppose that could just be bumped as a quick workaround? Two of those
> files have a comment that implies modifying them in non-trivial ways is
> not recommended.
> 
> /*
>  * NOTE:
>  *   This file is gcc-parsable HW gospel, coming straight from HW engineers.
>  *
>  * It doesn't adhere to Linux kernel style and sometimes will do things in odd
>  * ways. Unless there is something clearly wrong with it the code should
>  * remain as-is as it provides us with a guarantee from HW that it is correct.
>  */
> 
> I do note that commit 1b54a0121dba ("drm/amd/display: Reduce stack size
> in the mode support function") did have a workaround for GCC. It appears
> clang will still inline mode_support_configuration(). If I mark it as
> 'noinline', the warning disappears in that file.
> 

That'd be the best quick fix. I guess if we split out functions to fix
stack usage we should mark them as 'noinline' in the future to avoid
agressive compiler optimizations.

Harry

> Cheers,
> Nathan