Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
 pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Date:   Fri, 5 Aug 2022 16:46:24 +0100
From:   Brian Starkey <brian.starkey@arm.com>
To:     Olivier Masse <olivier.masse@nxp.com>
Cc:     sumit.semwal@linaro.org, benjamin.gaignard@collabora.com,
        christian.koenig@amd.com, linux-media@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
        linux-kernel@vger.kernel.org, clement.faure@nxp.com, nd@arm.com,
        robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: reserved-memory: add linaro,secure-heap
Message-ID: <20220805154624.qhrao5p3gwywl3xr@000377403353>
References: <20220805135330.970-1-olivier.masse@nxp.com>
 <20220805135330.970-3-olivier.masse@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220805135330.970-3-olivier.masse@nxp.com>
MIME-Version: 1.0
NoDisclaimer: true
X-Microsoft-Antispam-Message-Info-Original: H1uHJ2kie9Frpo6Pbo77eF5lMdXUXrXzwQa4o2e/YA1zqYVFecxNtE5hiH6CGi36jX1ZssLbd91fC2JnOcaVIo5Pa74fwf+jx03ZaBV0a2ofUbx4GO5MSjXp6mPU0vuYpXC+6c+KNunmbrOrxWi40xkjR6JFoWxNflGjZhJ/5iDLiyB9NYND66RW1X/goXwJBFjXuAc+3sXF5ZqVXuWZHsNracwdInsTU651ubFtGiM2fA4YSQ8xjHpRMq8ME5SF0dJZsMbI4/+AG8KRf6tJ0UOgyQs7zX4c/l44B+VY8ocgtws4iFy7+LHCTLymuCjiBLDoql/anBlkeMcGmeuH0ht2cnqyvdJZRY2RI0EMrXYqLPtnGUrbDEKSPg4UXk1dpvwu8iPCM9ie21nHJy+dAITWtLqEmiPQtE6ut2XZYOg3eKiNJyxY7G6vGlw7t9e9cTkDGtGFZul/MAyyIOtGVOaDSOwpZSjr4nil2QMfU32cY+Iz2K2B6IUQVbW35jd1y1X37C4c6RnAYTK3uLLw/rr3i7JV+VDqRkCt+U36wUV2NVgVZCk/aPsy21rhyTYKs2lmAWWk+vq+8RT4N9pFsV8F5jXeuj0jOQwLlqYo6NrOdocTsgLCqnEtO++nf/x77m5NkNwjYIVv/cISwEn//o/teRae1H+DldtCt9eKGIDuqGtQDxh76tyuNyfjkgX2XwI1ZXmy9fK+gMn3WFFZ60yF3+TBmoDJEkd+XxS083++/MMlD5GvXCEUcisHSYt2jgXHE5xXw2V57GAnxbp+VnaNIO8g9akDB7GiwgtH8eIwDbh/JKYLDmk+/zX5JlvB
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6805.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(4636009)(136003)(346002)(366004)(396003)(39860400002)(376002)(8676002)(83380400001)(4326008)(66556008)(66946007)(1076003)(186003)(66476007)(8936002)(7416002)(2906002)(5660300002)(44832011)(6916009)(6506007)(966005)(478600001)(6486002)(6666004)(86362001)(9686003)(316002)(41300700001)(26005)(6512007)(38100700002)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8061
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 20e93066-289d-4fc1-3f75-08da76f9a884
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: iXkU76E9TYrjn7Z5a8CksxzKdmBaiYWPYZrD43WhGcP6akyTH+V0HkDAYkXwyODmEefZ/rdl5u4heSYgSBxsPPffgmVc8D2Io9wQkqwdVr1rgAbSOWBZY3Sg59h+DRAjRIJp4oMttB7h6kf/0Hj5A0GYVBOh18Ozqfh7E5BjjYZ499ZV3/L4ELTfW1MMChY2ORSRtx/la2c6ZXypv4fffKLeLuJETDhKIVC+volQq6qA/h98b6gHvoSIhkxP//LjHRliYjsIJk3KkWMIkbbM3/jYaeFLQf/ow2e8XwQdarKlIsuKUoYM4F4SGnrhTqIl5ATS/+8EWRZHS7zsE++vbFcaHYOcdnFjnSJWtQTJpAdSN/RgTpRm0ERcu7CKJTPqRLuhMv5p4nhJMo5I8BgJTt5b6CzlV0D2wtjzbRa9x3AiKgrZviB217pYOGXwMzkub80oXIiTo4iFcPJSwOMOW3sP/FXcGjkKVkFBU2AoYHhmmrV20seF29tqBtCbXFT2Z1rlaxic4eDBIGEHGD9N3aKpdx2YL1uLxoU3BCBow0IdUce0NttCUuCnRap/M0OKioFFmXmfX1UEjhX0mbX/npGzme4q5R15rsCQoDni4OEuitiau7hwptulPmPBzD+/2tUDzrd6YFGLKpY7foC6dwHF0WSmx/5QJZjH5J3m/7FBXDr5zNt/9tCNmb0NPx6GDv7wusuO3lGnqpzr/hNRMnztY3UoQSpZSMUQ8JenFqA8gKiXv/nv8a3aWnGG80wrJZfyza5ccxaQkPSvCK7ErZI9+/Fhchdp/j59iBUCU2iIbDN9I8RCLYdTyjgwQObcJzYwdCl41GkDOJcxqP6TQpaeTdnrs70y8jS7bnTmhJSWObQ6A+fDv1cES93VEu4m
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(7916004)(396003)(346002)(136003)(376002)(39860400002)(46966006)(36840700001)(40470700004)(5660300002)(47076005)(1076003)(336012)(40480700001)(82310400005)(186003)(4326008)(70586007)(8676002)(44832011)(450100002)(6666004)(6512007)(41300700001)(6486002)(9686003)(966005)(70206006)(26005)(33716001)(83380400001)(478600001)(36860700001)(356005)(6506007)(81166007)(2906002)(40460700003)(86362001)(82740400003)(6862004)(8936002)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2022 15:46:36.6357
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a008c739-fdab-4769-7874-08da76f9ae1e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5063
X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+Rob and devicetree list.

I don't know if this should be "linaro" or something more generic,
and also where previous discussions got to about DMA heaps in DT.

Cheers,
-Brian

On Fri, Aug 05, 2022 at 03:53:29PM +0200, Olivier Masse wrote:
> DMABUF Reserved memory definition for OP-TEE SDP feaure.
> 
> Signed-off-by: Olivier Masse <olivier.masse@nxp.com>
> ---
>  .../reserved-memory/linaro,secure-heap.yaml   | 56 +++++++++++++++++++
>  1 file changed, 56 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/reserved-memory/linaro,secure-heap.yaml
> 
> diff --git a/Documentation/devicetree/bindings/reserved-memory/linaro,secure-heap.yaml b/Documentation/devicetree/bindings/reserved-memory/linaro,secure-heap.yaml
> new file mode 100644
> index 000000000000..80522a4e2989
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reserved-memory/linaro,secure-heap.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reserved-memory/linaro,secure-heap.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Linaro Secure DMABUF Heap
> +
> +maintainers:
> +  - Olivier Masse <olivier.masse@nxp.com>
> +
> +description:
> +  Linaro OP-TEE firmware needs a reserved memory for the
> +  Secure Data Path feature (aka SDP).
> +  The purpose is to provide a secure memory heap which allow
> +  non-secure OS to allocate/free secure buffers.
> +  The TEE is reponsible for protecting the SDP memory buffers.
> +  TEE Trusted Application can access secure memory references
> +  provided as parameters (DMABUF file descriptor).
> +
> +allOf:
> +  - $ref: "reserved-memory.yaml"
> +
> +properties:
> +  compatible:
> +    const: linaro,secure-heap
> +
> +  reg:
> +    description:
> +      Region of memory reserved for OP-TEE SDP feature
> +
> +  no-map:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Avoid creating a virtual mapping of the region as part of the OS'
> +      standard mapping of system memory.
> +
> +unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - no-map
> +
> +examples:
> +  - |
> +  reserved-memory {
> +    #address-cells = <2>;
> +    #size-cells = <2>;
> +
> +    sdp@3e800000 {
> +      compatible = "linaro,secure-heap";
> +      no-map;
> +      reg = <0 0x3E800000 0 0x00400000>;
> +    };
> +  };
> -- 
> 2.25.0
>