Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762225AbXFGOhg (ORCPT ); Thu, 7 Jun 2007 10:37:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751813AbXFGOh1 (ORCPT ); Thu, 7 Jun 2007 10:37:27 -0400 Received: from mx.melware.net ([217.91.97.190]:1428 "EHLO mx.melware.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540AbXFGOh0 (ORCPT ); Thu, 7 Jun 2007 10:37:26 -0400 Date: Thu, 7 Jun 2007 16:06:17 +0200 (CEST) From: Armin Schindler X-X-Sender: armin@phoenix.one.melware.de To: Linux Kernel Mailinglist Subject: [PATCH] Leak in eicon/idifunc.c Message-ID: Organization: Cytronics & Melware MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 888 Lines: 24 Hi, coverity spotted a possible leak in the idifunc.c file (bug id #1252), in um_new_card(), if the diva_user_mode_idi_create_adapter() fails, we dont free the memory allocated for card Signed-off-by: Eric Sesterhenn Acked-by: Armin Schindler --- linux-2.6/drivers/isdn/hardware/eicon/idifunc.c.orig 2007-05-22 00:22:02.000000000 +0200 +++ linux-2.6/drivers/isdn/hardware/eicon/idifunc.c 2007-05-22 00:22:52.000000000 +0200 @@ -106,6 +106,7 @@ static void um_new_card(DESCRIPTOR * d) } else { DBG_ERR(("could not create user mode idi card %d", adapter_nr)); + diva_os_free(0, card); } } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/