Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8b0a61dc-1d30-2731-4497-a69fff57cd2b@gmail.com>
Date:   Fri, 5 Aug 2022 18:43:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2 0/4] staging: r8188eu: cleanup some metadata issues
Content-Language: en-US
To:     Grzegorz Szymaszek <gszymaszek@short.pl>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Greg KH <gregkh@linuxfoundation.org>,
        Phillip Potter <phil@philpotter.co.uk>,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
References: <cover.1659715931.git.gszymaszek@short.pl>
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <cover.1659715931.git.gszymaszek@short.pl>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/5/22 18:27, Grzegorz Szymaszek wrote:
> This patchset tries to improve the r8188eu driver metadata. Some
> hardcoded values are replaced with proper macros, some unnecessary
> macros are removed.
> 
> Changes for v2:
> - added a cover letter and a base tree reference;
> - added Philipp Hortmann's Tested-by;
> - replaced the second and the third patch with different ones, per Greg
>    Kroah-Hartman's suggestions to make better use of existing kernel
>    macros and remove unnecessary ones.
> 
> Grzegorz Szymaszek (4):
>    staging: r8188eu: set firmware path in a macro
>    staging: r8188eu: use KBUILD_MODNAME instead of a string constant
>    staging: r8188eu: drop the DRV_NAME macro
>    staging: r8188eu: drop the DRIVERVERSION macro
> 
>   drivers/staging/r8188eu/core/rtw_fw.c       | 2 +-
>   drivers/staging/r8188eu/include/drv_types.h | 4 +---
>   drivers/staging/r8188eu/os_dep/os_intfs.c   | 3 +--
>   drivers/staging/r8188eu/os_dep/usb_intf.c   | 2 +-
>   4 files changed, 4 insertions(+), 7 deletions(-)
> 
> 
> base-commit: 9de1f9c8ca5100a02a2e271bdbde36202e251b4b
> prerequisite-patch-id: 79964bd0bcd260f1df53830a81e009c34993ee6f


Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150