Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 5 Aug 2022 10:09:15 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Rik van Riel <riel@surriel.com>, Ingo Molnar <mingo@kernel.org>,
        <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel-team@fb.com>, "Dave Hansen" <dave.hansen@intel.com>
Subject: Re: [PATCH v3] x86,mm: print likely CPU at segfault time
Message-ID: <Yu1OuwMhaoF6DQiu@iweiny-desk3>
References: <20220805101644.2e674553@imladris.surriel.com>
 <Yu0o3J2T5QwKtoan@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Yu0o3J2T5QwKtoan@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aX5o32ugwsWUe5Y9vKusqnBaa+y7FMZgJLdPskNxUi4y8aadkwovpEXmoo9/?=
 =?us-ascii?Q?+g1u9FwrcCo7u839nzKWAwLPP2eBCBmOAl12T59ygWHqxyDRD5xRAP1q9xBB?=
 =?us-ascii?Q?IUK2OipStReY6hcinaDuO2vTupkgHWvIE4eQbgDHUqIxEuxQ6aRFr7ko59CU?=
 =?us-ascii?Q?oI7Rb1m3C+HjvUCCitrGws9wFtAw6TQRes3rQKSgVNKAB270ij7Pcac1Gfuv?=
 =?us-ascii?Q?Z8Q2xVxuyh9+XLDFXJO+rYGqquJRGguY3UEK3hiEVml4NeZR2Rif3EG1kwsP?=
 =?us-ascii?Q?oATIsK9LqhGt2z3nVVnm3C5zPNfXvr0O4SWVhROymta/Afaidc2m8pUafV7k?=
 =?us-ascii?Q?ee0K5Wy+yABTLjH/L09jREjmujy+GeVAsDgnIuXt3xwDcTx/wm64iGpQcFb6?=
 =?us-ascii?Q?9rNkrpTA4Xycb6vEvI7nFwjYm24jYJMsJa38/JiKTLJ/zHE+lbb5UHFGRcpD?=
 =?us-ascii?Q?otQi0EIC24cIJZ7BjJSB7VcjF6dY4iirSQB+3fBU4j/knfXLOFXx88JC23TP?=
 =?us-ascii?Q?rSCMyUFcSIGtgd4LyobzeuPORVs3NMFEZMDTZfGh7fFan5swffQxk44U/Vkr?=
 =?us-ascii?Q?a5KMDMjqQHHkg9eAH6WFT/4xXCWERdAMVo4HmId9YotpjbVvnrwA7cj82F5a?=
 =?us-ascii?Q?t+MDl24bihjAQyBArTRITPGWwQZ7WYRgTx/6j53/4l03Gv1e/Sz4RkDrxZh+?=
 =?us-ascii?Q?SSF1Mhz4fVhq7WbZzyT5HKb3pToc++WXVMCeZ96ydqfex7iL9oiN+82OXsD4?=
 =?us-ascii?Q?v/KRJdROoH7YcmTpovO7RIY2KBJRjpqtDktqE0Uz7QFqrwptZZmipNxFw4WC?=
 =?us-ascii?Q?I3N2po2Wnb5zPondTz/+CpZwrS2sd27kRVVNki4hag7yKlDg9jnhDWuShaHZ?=
 =?us-ascii?Q?CBmOh8a0SDBjbzoUu1ipDX06XOK9ktql+85gt2O+N3vm2mq81VCmR1NyFXvg?=
 =?us-ascii?Q?aylLNobSfEJDCTsR5A9ooYln2+Ly1ObzJQn8hJUqZAFCZwTrbaFH8MNNFSDy?=
 =?us-ascii?Q?54/qvq2weoI1e+KSitXs5yjq9SZkz55Uxrz1XkOIUZXcu0tXts5R42WdJ7b7?=
 =?us-ascii?Q?frYIlAcwdnmc+frfH4jVeTsi/o9P6TOLb2tFlUfXUVvW2E/UewzFFj1JwzyW?=
 =?us-ascii?Q?PvVqOvMlgltyoV4wGL+GVUtAPmyrcNE15pvO88oNNfTuqak+PlXOqUUVs2Qd?=
 =?us-ascii?Q?oHosDn8eoFI4K6XxPXyd4Y09pwqOakfgQk5+34Pr9Uv7PEyP56RM8Solrgd3?=
 =?us-ascii?Q?lWzBVdR48l3r+uWcO2VUKSCbF+UwRviN2f3ZSBMBuXw0X+b7yJZtk4Duf2+n?=
 =?us-ascii?Q?tsDhY6LoyB3XaSno21/u/WTW4YIhUOoEzp/994FwSBNS5KLOWK52JGWfTiyJ?=
 =?us-ascii?Q?Ys1kuXK6yC6tdzdsPGSF5mMyVGjtrGgk0FLwHEEDkzWVCzb9jV5TOqzSLfvb?=
 =?us-ascii?Q?bv0LUYpOHc5Vwyd4GBqWzZbf15HBjs3s5jUpt9hx5pa7FMy1ZmmnH+mvPfvr?=
 =?us-ascii?Q?Y1ITAbqEXHzrUuci+Grka/aZ9LMVgdxlFe8TZgmxMuE1+qllDmGHZHqZEA4U?=
 =?us-ascii?Q?cBufEWTZSgi+OwM+UI2qeMf7fX49rd2sco+OVJNa?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 960080a9-0df6-4d52-bb42-08da77053d2e
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2022 17:09:21.2767
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zimIWpvR7yTtmMur5tWn3vZWI4ZBJ1VDnbzNBC/jEbzgPmBpuSpunwfMS+YIEY6NrJqvhJxU2G1OgyxNZRi+MQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5664
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 05, 2022 at 04:27:40PM +0200, Borislav Petkov wrote:
> On Fri, Aug 05, 2022 at 10:16:44AM -0400, Rik van Riel wrote:
> > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
> > index fad8faa29d04..c7a5bbf40367 100644
> > --- a/arch/x86/mm/fault.c
> > +++ b/arch/x86/mm/fault.c
> > @@ -769,6 +769,8 @@ show_signal_msg(struct pt_regs *regs, unsigned long error_code,
> >  		unsigned long address, struct task_struct *tsk)
> >  {
> >  	const char *loglvl = task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG;
> > +	/* This is a racy snapshot, but it's better than nothing. */
> > +	int cpu = raw_smp_processor_id();
> 
> Please read this in exc_page_fault() and hand it down to helpers.
> 
> Alternatively, I'm being told there's a patchset in the works which
> will allow for any exception handler to pass in additional information
> downwards through an extended pt_regs. Then, saving the CPU number on
> which the handler is running would work generically everywhere.

Indeed that was part of the PKS series.[1]

I've thrown together a quick RFC with the relevant patches from that series and
Rik's code in show_signal_msg().

I'll post it shortly,
Ira

[1] https://lore.kernel.org/lkml/20220419170649.1022246-18-ira.weiny@intel.com/

> 
> Thx.
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette
>