Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f253a352-caf3-49fb-17d3-0265b472d4c6@amd.com>
Date:   Fri, 5 Aug 2022 12:29:34 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] rtc: rtc-cmos: Do not check ACPI_FADT_LOW_POWER_S0
Content-Language: en-US
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Alessandro Zummo <a.zummo@towertech.it>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux ACPI <linux-acpi@vger.kernel.org>,
        Zhang Rui <rui.zhang@intel.com>, linux-rtc@vger.kernel.org,
        Linux PM <linux-pm@vger.kernel.org>
References: <4771532.31r3eYUQgx@kreacher>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <4771532.31r3eYUQgx@kreacher>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGQvSzNQRUxpR2ZIZjg5TUF5RjI3ZVRhRzhCV2dmS3FReE9nQmdIRllHd1Z6?=
 =?utf-8?B?SnlSYTZETzROZWJiREVGeXJpbVg5MTJ1V3JvT3BINXNSZ3M5TWpLRWVuNDFB?=
 =?utf-8?B?aE9MV3owbWRvOUsyWFJ4V0dUcE8wY21tWGQxeFBxbFhzMDJPQTdCd3ZrZjhm?=
 =?utf-8?B?eEsxTFRHeDNvOS8yanMrNk83cGxNMnplb1lSZkdJUHY0UWFHbmFlangrMWhh?=
 =?utf-8?B?YXJWQ2VDN2JnMW1OdTdTY01NeURBa3NJdEZXQzV1MkdnRjVLTDN1ZWEvbEp1?=
 =?utf-8?B?d2FrcGwrR0h5RXpaZHhMYTdQZlhNK1dPWW8xcHVtelNUVk9oMlJVaExKWHV3?=
 =?utf-8?B?WmZzaDJCdDVsMUsrMDRLZmxhdHFiekRSVm9rRnNlS3o5OTlFQVdQMXZTZEQ5?=
 =?utf-8?B?d25lOWZuTEhXYWRSNkcxNFgxQjRmWis2Q1B6amNDaDArazFIM1g3bTJnc3U5?=
 =?utf-8?B?RUhidys0ZU8rRTZtZVZiSzhyYndEZkNGdmlsMXVLSGw5cWRhSm9uOC82blQw?=
 =?utf-8?B?MXFBdE1JbGprbWU1UnpWeXdpTUN4MzRIMmF4TkxQK0hDK3pUT0pHNDR4TFNt?=
 =?utf-8?B?dldwalYwbTNMYzR3WjlReE9pVXIzZnYrdWdHRm4vOEFpZGFJbkZkSVlESGZ6?=
 =?utf-8?B?YUFwcE9DMGhPdW9pZUxtd2xiVGJFeUFkNmlDbE9JUStYc2dxWXU1L1RORUFn?=
 =?utf-8?B?SlZNVkNPVHFaVUhiM2RSWkFiL3NYOUIrRVVqSWtjRk0rSTcwYlUzbjlzaW52?=
 =?utf-8?B?NkZXZHlwcGRibWhIQlN3N2plZjI3TkJ1SUFvVFRlTGFvR0pkckFnNmk2NFZi?=
 =?utf-8?B?d3dyZXRaRTlmaTlabW8vQnovVFVadDd5ZnB4bHoxQ01UMlFtakFoMkVoVEgx?=
 =?utf-8?B?eW5TdFplK0ROclZ1WUVYTFJVenpmallDdUE5QW5DR1ZpMVlVaWo0LzArdlJz?=
 =?utf-8?B?Vm5zZlhDNmliQ240QXkyT3ZFTGphWnNOdUpldHc5UXdPekNsTDBIb2o3L2N6?=
 =?utf-8?B?TGtzdmUyYVo0UHB0T3BjVzFjcEdOVHk2RDZ1WUM1d0F5SHlvR2lCOEFhWVpT?=
 =?utf-8?B?ZjlhNHZXUnJVSTRMQW5uc0NjN2UraElvWUZ0ZWhUMk5JN3VxZGZLWmsySVcy?=
 =?utf-8?B?VVQybjc1UmZ4aEhEamk5UzZxWDZpRG01OXlZWXJ6NjRTSkU1ZXVmaTNnVzFj?=
 =?utf-8?B?d2pWbHFYRXlqQ0RNMkxteVFLRVVBckJyWVFFaFJjdDZKWHIyTDFyMEpQUkVE?=
 =?utf-8?B?MTI1dGlaMmZhL2lxK3U1eS9hcUh0MFQrRVlQMzJEeU5HNXRZelNSQUUrdEhZ?=
 =?utf-8?B?aVg0eW9HMm45RkpZZUE5dFhETWZqcVoxNnFnSk5XdGhSdzRjeitHM1g5RGRQ?=
 =?utf-8?B?UGJoeitkU1h1enp1TjBIU2tNL0g1L2pFdU5mWmVRT2tpdkp1Q2t5YjNTblJu?=
 =?utf-8?B?N1dYQVI4SFc2enlySk1ZVFI2dlVFNm5uMWRyUlNYVkt2N0h0UWNUU2dqTmVW?=
 =?utf-8?B?M3dIcWtUNjk1THZ1azhkNUlRb2J0bWJaOHFHRWNjYmhvTDdod3I2bWtoT2Fk?=
 =?utf-8?B?UmNHaEVmdFA4SDN0UUJqbFVSa2E4cUFkQm9uVFhBY3pnWEJhbFNzd2t3alRM?=
 =?utf-8?B?WEpEZHBwNU9rcFd5OVVvZXJkWmFXV0lSTmxKRklOcG5MaE9DRjIrRGs0UG9h?=
 =?utf-8?B?L1dFTkRtMWJDeEpNRW5Ga0lyYVU0anV6Y2o2WFExZjJ0alNPZFRiZ0NWUWJD?=
 =?utf-8?B?bzlUaGZPSnVEaW1IcEVxVXBEZkxTblpJZlhVTzZPSGVJZ2NCcFBGR0JXcU5L?=
 =?utf-8?B?NXlWS2pncitrMWxneFdOenorRnJyc2lDVmVNYTROdTl3TDZrNm9PL3NOU1Bq?=
 =?utf-8?B?S0tmQ0JFRjYxejNqVVZEQytucjRQVXJKU0RGdzNCTC91UjRWTEtHNytMMjFQ?=
 =?utf-8?B?YVZraDlHT2JseWN6SUY1Ym9sMC9aRzlZVnZmYkVkQkJ1SzRxV2ZlMVhhZGJ1?=
 =?utf-8?B?b09vMVArdXh3SnBvNXRraHNKdDhYSjJWMXJqaVh1RHlOVHBpMjJEc2dVYkI4?=
 =?utf-8?B?R2lRVm8zVk5tS29yQkdhTjBod3lDdUVUVVlBTmhZWENJdzdhekVpSE5FS0Zw?=
 =?utf-8?Q?rOExe6gKQv6ikKOGsn6kRckoI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4aa752a1-510a-45ab-5a15-08da770811b8
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2022 17:29:36.8178
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: scISQqz7jl82EZUbmTw8NvV5Bj/UzSBGwiu2ezM8U60d871Md+PIxYvAc/jCTqqppKLcxOIIQ4S3aj9VGY9W7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB4681
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/5/2022 12:27, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The ACPI_FADT_LOW_POWER_S0 flag merely means that it is better to
> use low-power S0 idle on the given platform than S3 (provided that
> the latter is supported) and it doesn't preclude using either of
> them (which of them will be used depends on the choices made by user
> space).
> 
> For this reason, there is no benefit from checking that flag in
> use_acpi_alarm_quirks().
> 
> First off, it cannot be a bug to do S3 with use_acpi_alarm set,
> because S3 can be used on systems with ACPI_FADT_LOW_POWER_S0 and it
> must work if really supported, so the ACPI_FADT_LOW_POWER_S0 check is
> not needed to protect the S3-capable systems from failing.
> 
> Second, suspend-to-idle can be carried out on a system with
> ACPI_FADT_LOW_POWER_S0 unset and it is expected to work, so if setting
> use_acpi_alarm is needed to handle that case correctly, it should be
> set regardless of the ACPI_FADT_LOW_POWER_S0 value.
> 
> Accodringly, drop the ACPI_FADT_LOW_POWER_S0 check from

s/Accodringly/ ccordingly/

> use_acpi_alarm_quirks().
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/rtc/rtc-cmos.c |    3 ---
>   1 file changed, 3 deletions(-)
> 
> Index: linux-pm/drivers/rtc/rtc-cmos.c
> ===================================================================
> --- linux-pm.orig/drivers/rtc/rtc-cmos.c
> +++ linux-pm/drivers/rtc/rtc-cmos.c
> @@ -1260,9 +1260,6 @@ static void use_acpi_alarm_quirks(void)
>   	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
>   		return;
>   
> -	if (!(acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0))
> -		return;
> -
>   	if (!is_hpet_enabled())
>   		return;
>   
> 
> 
>