Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 5 Aug 2022 11:07:04 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Terry Bowman <terry.bowman@amd.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Wolfram Sang <wsa@kernel.org>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Lee Jones <lee.jones@linaro.org>, katie.morris@in-advantage.com
Subject: Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512
 chip via spi
Message-ID: <Yu1cSLlkXAr/t5ho@euler>
References: <20220803054728.1541104-1-colin.foster@in-advantage.com>
 <20220803054728.1541104-10-colin.foster@in-advantage.com>
 <Yu1W8DMaP8xlyyr5@euler>
 <CAHp75VcVD4XxydmYkgybjpCKsh=0KS5+GnDGK5CJX-qZwJ06Cg@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75VcVD4XxydmYkgybjpCKsh=0KS5+GnDGK5CJX-qZwJ06Cg@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?djo1DK1p8Zkz58KuYw3JQNsU6vDpfjmdd268s6dBap+hMALmwJK0xG0knX7/?=
 =?us-ascii?Q?X2eqAE0i9gN71H+ym3Apr24WAq1Dy01p95Euy5IIKCMZHtYvdF0ed3jF6Bnm?=
 =?us-ascii?Q?qHc8gGbX5z32A4eEVg8eW1tnAknv3RrnIjonO1DjHTsEVLzNejFudJqIYsiy?=
 =?us-ascii?Q?/QojP+y4luN4tmrGs6885pHu7F4ba99UAuJixp+pF6UBrxLJLbQJirItUCfK?=
 =?us-ascii?Q?EvpLsXESF2z7uVxs5QYgrVdXDL2/3IidKm1HqSY9TLg6BHmDNvuY5jrjMoWH?=
 =?us-ascii?Q?M+Nk48vKjaaqu2NP9jv/A2yXhbk+2ZVsWwgGqRZ4gxF6nVTNy3h/2euezhvQ?=
 =?us-ascii?Q?fDm0mlSXzU/vpqK6vJNYKAkUQlOtFhnHySkap+T9Mt4YvlQhM+66Y0q8ZqRS?=
 =?us-ascii?Q?jqN/e4U7auvMgEUh2RKNGmtaFoyyyr5QB84rUpxpTazyVXfadrEo64KzPpJA?=
 =?us-ascii?Q?yx3vbovq9FlvYlWUQDc5ayEtVIeMPonFGeYOIjXRRwOvWzcVd1mm2ma4+83Z?=
 =?us-ascii?Q?/K1AgeEicWiF6/ziUayYDbwvmxOWxAhnuOTnU+HavsmyHBf4UmYnZddYBIFD?=
 =?us-ascii?Q?2GOSEExI2+ojrVfAZtO8zHZMoQp6tYFZx10X2sUO78ugTWmyYxw1IbrPFFAc?=
 =?us-ascii?Q?DDx6HYe7rLkF1o0HeZJhOqNepF0Wjj27CkNpUFeH5CzhDSRyP0hsrzOSMBHn?=
 =?us-ascii?Q?I2iBRJ1bhZYp6+pDYiuHmB80hlQtcjAQtPykotRaNnF3cXlwPrS/MOqJLOi7?=
 =?us-ascii?Q?8Hw2tQ3eoVfdyCNE31Z7OAbyFyDwSKZk9AMBho9hXwxFvQ8rC4IFDEIyzPRQ?=
 =?us-ascii?Q?fQPki9p0iwrUNb+6czf38Ws+kR0Zag09OLjghSz2P6pbQ2fsjf51VuR13s1f?=
 =?us-ascii?Q?K/owcskyLaoqfWbnCIAM4UqfgSnZmsqgStHFwPvOXqonFKPYjxlOQJgioTOo?=
 =?us-ascii?Q?yl+QMrsR93H+Sawj2GlDytT/t6eJHkfah2QvBwKDT6bPDwDHzOpLv9W3nGJr?=
 =?us-ascii?Q?mSEdr9IglPKI+o2XcKO4NN2Dzc7kwpnE65I3M9xXOoIzG2B04sLaEmQLb0jd?=
 =?us-ascii?Q?DWaUYixT8W8VcTjV2gszttFIe3grKgQZwz2xSIWr1IH5zMUa/eJyDMxCV1Bs?=
 =?us-ascii?Q?yz7Ak5zcup3nydnWrbDbAuQwxMxAJ5JbZl/NWV7OO5TE5n44vUjhejIB+asA?=
 =?us-ascii?Q?FoqVSRPimevdBwMWyp5j74ZY4jLZaGO7ASdJwA2uwFac5KPnFQfoFI578o7P?=
 =?us-ascii?Q?Ku2L/e8U5tCuHSeRhcewQ2w04Lx4bbcGU1lHXA7eSmB4GLbKJiQfrd86DG90?=
 =?us-ascii?Q?Ln7b3xhI52s/D+5hledNlx8SPBZ99lk4gFAKvAyQEum1T2yxzZoV5uqxoJSB?=
 =?us-ascii?Q?MIRT1mYb5zkBDWgyKPh+rw5n5zlLVtcv+USLAR+KBZGHfpR1QmduoWHtSQ3V?=
 =?us-ascii?Q?8MNiSsMZmL+H4y4i6EvneJVtdJM/pZze4M4levIPpytwJ9FHwhmsI7Altd30?=
 =?us-ascii?Q?e0fhoRRswbTD855mJGRByacVFGzek+KYJR4fqZ5NYx8Pa5BAIwsBEQgm/WCZ?=
 =?us-ascii?Q?de3MwHksAWbbQdtb11CTnW+/Qbh7gthqtS4fpQujELKNcqYLhan5nEgZNe3Y?=
 =?us-ascii?Q?yWQBQ67RHRLgdSk2i+rnULs=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23d1ae7b-de76-4b07-0f69-08da770d4fd7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2022 18:07:08.6152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P3p5PEwszPsx8Zz6c1zemJcdaCU8798ATS+8IdjOVzHnViHBwtDXOT633eVovJ15Lhhu+aiwF9xNVLCKx8fhgT45TnJOpo+okDLrhUPTL0U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4970
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 05, 2022 at 07:58:06PM +0200, Andy Shevchenko wrote:
> On Fri, Aug 5, 2022 at 7:44 PM Colin Foster
> <colin.foster@in-advantage.com> wrote:
> >
> > As I'm going through Andy's suggestions, I came across a couple more
> > include changes / misses:
> >
> > On Tue, Aug 02, 2022 at 10:47:28PM -0700, Colin Foster wrote:
> 
> ...
> 
> > > +int ocelot_chip_reset(struct device *dev)
> >
> > #include <linux/device.h>
> 
> Nope,
> 
> struct device;
> 
> ...
> 
> > > +static int ocelot_spi_initialize(struct device *dev)
> >
> > #include <linux/device.h>
> 
> Ditto.

ocelot-spi.c uses devm_kzalloc, so that should still be included.

ocelot-core.c uses dev_get_drvdata.

So I think I still want the includes... but for different reasons.

> 
> -- 
> With Best Regards,
> Andy Shevchenko