Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp2026930rwb; Fri, 5 Aug 2022 11:50:37 -0700 (PDT) X-Google-Smtp-Source: AA6agR6L4JMLNbdtHps7Qwb+H/JKTQatwse9hxeEk9GeVk7y4QCAN3/nM/gqmdvNXEu78pkyls0s X-Received: by 2002:a05:6a00:842:b0:52e:2515:d657 with SMTP id q2-20020a056a00084200b0052e2515d657mr7895592pfk.31.1659725437222; Fri, 05 Aug 2022 11:50:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659725437; cv=none; d=google.com; s=arc-20160816; b=OJRq1Erq3xlIju2Q6ssnE9Jp2hNkzAo69WgypDUX+IZ0KEYlHeHATJqvIsEPLRgJ09 +knXjCA9zp4GfCk+Eu+22bp2CPEwe7SjMvXtPYfyDz8IZ14Iw+OhTVgLXT8PYTwL8yo+ TuYVlWqOVPejWF3SiF7q8F88x+nHAbW2YDEOiO7PBVr/uGamT0GyqoCknnA3akdvYALW B/VWneivtK+fcLsMQQXd3fWNUQ+D0B/HktlE0p4ZSWEaG42k+EZ/aTFjJ95AGga/L6Xu HhCt64blUxQIrzFuk8qV2oEAFUpIc+vMSNfZYnJEknZWnuJu8OtgpRJThKnU/Bit4Bmq gHsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+Fshx35gKDbhEKNA9+vyw6D6TRNrCJyr6eaykLEZRdc=; b=g0KJFAOulRNB+Pzc5V3oxnMWmY5AoRX72BzBLbKnZQ7EnJG40+eSQkC2k+f6hnAxYs KbbxkQ4HYwVU4QHWQWTRTiCY9PynX00o0Ndc16wai/fU5Izq/eruHKlrcWnCJVqtD//7 Git/BPiEbHFox5xxcxOdcrw2RVX6rbSu+jg3wQJ1QvIY4iY9dr/cK0XDtFwAuAEDDxRT fWtg8LmIn3x0kviHpi8ojI88ARPuDh8uOs87PDopy4H5NNo5mBZliBHmt7H9RI0v7INg YWy3niVFsTKHtY5KvoPwO03+PV/r8o6lmz9DPDURPRRkNrL6MnVI3w6TaZ/qSgTcDZBX PM/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@poorly.run header.s=google header.b=FJaZ6poK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 6-20020a630006000000b0041d0f0f3789si2152624pga.627.2022.08.05.11.50.23; Fri, 05 Aug 2022 11:50:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@poorly.run header.s=google header.b=FJaZ6poK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241372AbiHESec (ORCPT + 99 others); Fri, 5 Aug 2022 14:34:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbiHESe3 (ORCPT ); Fri, 5 Aug 2022 14:34:29 -0400 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C650A7AC25 for ; Fri, 5 Aug 2022 11:34:28 -0700 (PDT) Received: by mail-qv1-xf34.google.com with SMTP id ct13so2314138qvb.9 for ; Fri, 05 Aug 2022 11:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=+Fshx35gKDbhEKNA9+vyw6D6TRNrCJyr6eaykLEZRdc=; b=FJaZ6poKkiXH7Up/SOBvgoAB2hRHOPNTHRX8SYhdRLvAHkofQItlr14p5WTHsfy6gy Cr2JqeWzm0bls1wmYMFNJCCFJkmPt3DX3ewEjq3BEwR17NjKwoZ+vE9AH5XXE4++fXp/ hwHD3NUrZNuV+to2V9kKDcxS3S2SrDqemiY6X72EHbzsVrriJX8UhlXG46d4p2E4DuSj 9h2+k1KSV9h2zaDRwWS4rQXTNsVbe0afwo1lFplzyBJtrQgQQzB833IDoXx3EW1x/AON xI2l7rp7YDeq2ViHGwrbtI1HdQyxQd5vg4UAXfAfFrOLjfJp2Zz3/grzwZcCr1til7l/ DtwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=+Fshx35gKDbhEKNA9+vyw6D6TRNrCJyr6eaykLEZRdc=; b=wsyiJxqO5aw5AFL7MfDpcAvIUW4tJOjEMlJry9lKWhFttqwQ+0L87XzLI1Bn7ktNxI /NlemrrJ85e6UkQpiw6wK2Bs5zzRbnmISI+v7B3H2olLPUQVNnXdlzoPXg/CP2Xf5sEQ uq2Ex7VRwebmd4R4qHY1WHknYcu7Q7XnS4bDg8zrETgsQxmno9BHTD6+ll3IgxL4zWtD o/qawBqzJan3thNfP7PFJaBBBmjxMwRp4SnqwLlSvBr9+FOAWyGnScR81eSTncJ//tWl 2o2q+dM1j7eYNdrPD24pGumUCdJNjhCP7NCbaX/hROasKVxXE/dpsrBX/uk/o7ep8Ueu c8Ng== X-Gm-Message-State: ACgBeo0k1WmMF0JIdn3T/0tp/rL5BQoK33qNas4zYM71H3VazbSHHD4Y 3MdPo+maDmOOKwtQca5X9mn/HOIZTDExaqjU X-Received: by 2002:a0c:b39d:0:b0:473:9292:d4ec with SMTP id t29-20020a0cb39d000000b004739292d4ecmr6875240qve.66.1659724467955; Fri, 05 Aug 2022 11:34:27 -0700 (PDT) Received: from localhost (48.230.85.34.bc.googleusercontent.com. [34.85.230.48]) by smtp.gmail.com with ESMTPSA id j10-20020a05620a410a00b006a65c58db99sm3555519qko.64.2022.08.05.11.34.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 11:34:27 -0700 (PDT) Date: Fri, 5 Aug 2022 18:34:27 +0000 From: Sean Paul To: Jim Shargo Cc: jshargo@google.com, Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] drm/vkms: Support multiple objects (crtcs, etc.) per card Message-ID: References: <20220722213214.1377835-1-jshargo@chromium.org> <20220722213214.1377835-4-jshargo@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 05, 2022 at 06:27:08PM +0000, Sean Paul wrote: > On Fri, Jul 22, 2022 at 05:32:10PM -0400, Jim Shargo wrote: > > This is a small refactor to make ConfigFS support easier. > > > > We now store the vkms_device statically, and maintain a list of > > "cards", each representing a different virtual DRM driver. > > > > We also make it clear when a card is "default", that is created at > > initialization, and not. This is because, due to limitations on what we > > can do with the configfs API, the default card won't be reflected in > > configfs and is initialized in a unique way. > > > > Since we're only managing a single card, this should be a no-op. > > > > Signed-off-by: Jim Shargo /snip What a mess, I replied to the wrong patch. The review here is targeting PATCH 2/5 despite the title and reply-to.