Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   William Kucharski <william.kucharski@oracle.com>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>
CC:     Hugh Dickins <hughd@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] shmem: Update folio if shmem_replace_page() updates the
 page
Thread-Topic: [PATCH] shmem: Update folio if shmem_replace_page() updates the
 page
Thread-Index: AQHYpAsmmbDT6gJKuEORFdp5TP+PXK2g0leA
Date:   Fri, 5 Aug 2022 20:52:15 +0000
Message-ID: <0BAD35F3-C90F-4425-ADEE-B39E507D4AE0@oracle.com>
References: <20220730042518.1264767-1-willy@infradead.org>
In-Reply-To: <20220730042518.1264767-1-willy@infradead.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MStqyYc8Jtj4ZLUjKWMkYYakH7eyR5IkOuaRQZ+mzPc6OA4hpeWbRIZhVZ3j?=
 =?us-ascii?Q?LApBTG71f5JJ8r7bPrnI4MIHHfKNHHwIpiM0P4xbQ9bvaaVxRLx437YrGnoQ?=
 =?us-ascii?Q?V6z7bSWqGoszVLgIXSL1yeFpk4KOHbIvbyrUssu85k1xSMtUDnuDfKXE1oGs?=
 =?us-ascii?Q?7XdgCNnES75QhLh5nJgHi15PPv0J0s3k1inTP0v07MtpSAXD9SCv7IRXhSOU?=
 =?us-ascii?Q?h9XFXPW141DM4439n/JDQyvVECYZ379wzzIyhJhMRsKps2s2LyfSKYUisVUc?=
 =?us-ascii?Q?fMCsLlx6qGHgZhHZktxJ5cLkfxulTYM87JTzBKiYfrzSxjyTP20hdAuj4EBx?=
 =?us-ascii?Q?sydzD6+cSwxYXMbuWOVX2SAsZSiJ2AboovN85Vrgu0LtcA3E0vEJtk0FkLA8?=
 =?us-ascii?Q?JKIE760nh4owIu2qK/+2L1JseSmXebROKVEnlbgfkKvtM1mlXWu1Q5+D8+oK?=
 =?us-ascii?Q?Wu45QWIlI7XcOQqRVGAQfnt73B/rvCaD/RKNNFl6bR8wrri3HuxPpxLKphcb?=
 =?us-ascii?Q?BiY+bn3acvusLe7xjE+InrYBjbgWrjmKsYVYw1Tsf6YGA65Zu+Jo0usUUf2f?=
 =?us-ascii?Q?R633+8o754Jg7MBUzft95V3zts5bkAOmpB81Q3hBFiDfEOc4NnLd495MnM8A?=
 =?us-ascii?Q?PK7ldbGiAjzT7lrJUaAizBlvwUnlfIz52ZZKlORyVUEVnXhIf+jJbjqX6AdV?=
 =?us-ascii?Q?lZ084rfWgCk+eJqgams1WVMV3M7jyI+9yWU+cva0ho+73p6TO9x9ap5crucb?=
 =?us-ascii?Q?TDeYeZhKfQ85oV2IpRQJ7WvemSI0obn3wLIKJ+8NrKGBDAVFhiKaEjmr/LFX?=
 =?us-ascii?Q?tIaUifrBmrI6usURfl2ZkFbpFy+iMJrO256lKfgERPg68CJ0K+Y8SUwUvdyV?=
 =?us-ascii?Q?+9FiNHvSs9Xt7G1UMs0rtcafpxEm9y6tyechc7E564bB/LkumTHesiJffnZq?=
 =?us-ascii?Q?AA3RM1++LzNsCkGZDZ/a/Mw3/js8We8Hvg6nxvDtYVqIfYThD26Qp14g3BZT?=
 =?us-ascii?Q?ssQfJaDK+QXWI/ySmZFZTWOuIMIs0QRjJr8RfPShlP1wrnxTo7C0ctqlEWoz?=
 =?us-ascii?Q?FGuyxxTVkIFCbJlpdV0IeKw53foRjsMWFQDa1F88JKNHnULRmYzD+s64Xnbc?=
 =?us-ascii?Q?NbLeQRJYHGhwEiAh71Qkwr1UKTdK0kI6NwUTK0NhS3eYImbYFES0GuEenQCO?=
 =?us-ascii?Q?TisOnVoYvNCpQBr9cVjf15jsmUCbzDjmEp5FsUnjnm/OqWW/AJ+89LsvmhJD?=
 =?us-ascii?Q?jhFcj6WxIxWrQjQGpYbngdwTwbtOeJR4YFks/lNvVu9HneKI2ds418is+4Gt?=
 =?us-ascii?Q?kOD/esQ3qdCYT/yTXGLFIu13+1it2UEyGc0qUmsibnMzikLfGLW/SHHjvxT0?=
 =?us-ascii?Q?gh/Tm3MRo1OW90s1DJllNTKcMjogmQN5YuJ8QTyhMskAhuqpJ33kLo6V7N8C?=
 =?us-ascii?Q?m4HOepn2jDLlhmVEMyx7IMwdEkLU63CshdwDII1NcJMGLM6OoKjQe4XSP067?=
 =?us-ascii?Q?kUmAXtBNS94P4bAoD/J9CesPPMsU4iAlqsnAzakWuzYjud+sHfbtKGi1wVSj?=
 =?us-ascii?Q?8qfE2ovJVQd7Sen4Q7iok5bvDsCw8iJgv32jzMXrDS2neLD7NYL5EKh29gqG?=
 =?us-ascii?Q?+JtzycW2Tgu2QoYWPu985HQaDORCfUfvP7LnxcjbC3NI?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2FA4CED649D4FA438DD7688A3EF76FF0@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN4PR10MB5559.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a01c55d-0941-4fcf-42ef-08da77246136
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2022 20:52:15.9195
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wx9ALKEhkBWOxVIc9Ft6u8o2qqwjWDLATJEgL/S6E59YrjK6IivpSCXEwbgEPRS7GyJwggGNexmh/7lti49ZDY7tk3wBMlQCuL6BJEazVTI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5881
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-05_11,2022-08-05_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2208050091
X-Proofpoint-GUID: 93Czjeimj5cMWV1u9tw7ygTTgWg2QQS7
X-Proofpoint-ORIG-GUID: 93Czjeimj5cMWV1u9tw7ygTTgWg2QQS7
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good.

Reviewed-by: William Kucharski <william.kucharski@oracle.com>


> On Jul 29, 2022, at 10:25 PM, Matthew Wilcox (Oracle) <willy@infradead.or=
g> wrote:
>=20
> If we allocate a new page, we need to make sure that our folio matches
> that new page.  This will be solved by changing shmem_replace_page()
> to shmem_replace_folio(), but this is the minimal fix.
>=20
> Fixes: da08e9b79323 ("mm/shmem: convert shmem_swapin_page() to shmem_swap=
in_folio()")
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> mm/shmem.c | 1 +
> 1 file changed, 1 insertion(+)
>=20
> diff --git a/mm/shmem.c b/mm/shmem.c
> index a6f565308133..bcc0a3c7b5bf 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -1771,6 +1771,7 @@ static int shmem_swapin_folio(struct inode *inode, =
pgoff_t index,
>=20
> if (shmem_should_replace_folio(folio, gfp)) {
> error =3D shmem_replace_page(&page, gfp, info, index);
> + folio =3D page_folio(page);
> if (error)
> goto failed;
> }
> --=20
> 2.35.1