Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp2480751rwb; Fri, 5 Aug 2022 23:11:52 -0700 (PDT) X-Google-Smtp-Source: AA6agR7yidVi7zhrSDGH5XgCEiFiFgss2Od2RxyAx96kqjSIFSdRDlE5jvKZPWqKdj3kSmIwDwC8 X-Received: by 2002:a50:fc85:0:b0:43d:2284:1ea5 with SMTP id f5-20020a50fc85000000b0043d22841ea5mr9626392edq.105.1659766312403; Fri, 05 Aug 2022 23:11:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659766312; cv=none; d=google.com; s=arc-20160816; b=Dv03eYaS94wfg3pS6NAUimyPBGapGFDkD1AKLEGUrNPg87rhpgo3MZaRAL6juZpzUw 8AeGKyNzokzooqN04rK6GuTYN+dt58+rqyRX850vLqOs2ERf8ATZzlPdS/V1QK6HJ6uN kQRs5qw+d2kZcCXGcxD+eCLZb1y87oDYwkXN/1WSUoO++PwJtQLK0nZ0KUzOwbjSr2Vw vWz6e6tdLVGfLufH8vBHoO22/HRKEDfAi5qzwGPr2RdZbUSyImV4bhM0mjHzTb+CAGPf 9zLZ8Vd1RtQC9oxD1zSA2Zm+F+uUJAnoTeNU3TYWRHha5Y6rT+WjGmeIRJy5SZfEY2up AY6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=YtJ75+HVlC0mG8j4WSdeItU5SNH77E4yFyaCsnSsr8w=; b=sQPIaNHi5kcLLC6VMUAsWeLcmNWMaFm2YM8kM8jsmrP3drmJky8iZ4uyAZvr+bcpsJ R6GdjD/AMXbd1ab/6hU+KWeS+IuDFORjJAA7Oulem0Cdi6K8cTbcKyZtuCaT/uMboCIb qd75RGfrNX/oaUCu92y/Qlcuf7wqsbIzGTWW2IArX1Qigj43lqOdt0lbdZFDxhXqloka kNfe+LXIZEarhX6K7S6De8izXG79Y4vdVDptMF5CY61JE88JPBvzQseF66LhRKqVdPPv Ok0vadOqJjJnSGpclDliRmNAZ8upSnnN7uv5Wtw4JUGAa/aEOZP7HzBrSZJ7FGENtZvK +K0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga16-20020a1709070c1000b00730c4cca3e7si2700725ejc.147.2022.08.05.23.11.27; Fri, 05 Aug 2022 23:11:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239171AbiHFFT7 (ORCPT + 99 others); Sat, 6 Aug 2022 01:19:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231974AbiHFFT6 (ORCPT ); Sat, 6 Aug 2022 01:19:58 -0400 Received: from smtp.smtpout.orange.fr (smtp-19.smtpout.orange.fr [80.12.242.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBEE513F69 for ; Fri, 5 Aug 2022 22:19:55 -0700 (PDT) Received: from pop-os.home ([90.11.190.129]) by smtp.orange.fr with ESMTPA id KCE2oIRdG0UP7KCE2ofqLM; Sat, 06 Aug 2022 07:19:53 +0200 X-ME-Helo: pop-os.home X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Sat, 06 Aug 2022 07:19:53 +0200 X-ME-IP: 90.11.190.129 From: Christophe JAILLET To: Greg Kroah-Hartman , Chunfeng Yun Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-usb@vger.kernel.org Subject: [PATCH] usb: common: usb-conn-gpio: Simplify some error message Date: Sat, 6 Aug 2022 07:19:49 +0200 Message-Id: <7705a9dff8e097070c492d6f4f8aafaaa890f049.1659763173.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dev_err_probe() already prints the error code in a human readable way, so there is no need to duplicate it as a numerical value at the end of the message. Fixes: ddaf0d6dc467 ("usb: common: usb-conn-gpio: use dev_err_probe() to print log") Signed-off-by: Christophe JAILLET --- drivers/usb/common/usb-conn-gpio.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb/common/usb-conn-gpio.c b/drivers/usb/common/usb-conn-gpio.c index b39c9f1c375d..44c5127175b7 100644 --- a/drivers/usb/common/usb-conn-gpio.c +++ b/drivers/usb/common/usb-conn-gpio.c @@ -208,10 +208,9 @@ static int usb_conn_probe(struct platform_device *pdev) if (PTR_ERR(info->vbus) == -ENODEV) info->vbus = NULL; - if (IS_ERR(info->vbus)) { - ret = PTR_ERR(info->vbus); - return dev_err_probe(dev, ret, "failed to get vbus :%d\n", ret); - } + if (IS_ERR(info->vbus)) + return dev_err_probe(dev, PTR_ERR(info->vbus), + "failed to get vbus\n"); info->role_sw = usb_role_switch_get(dev); if (IS_ERR(info->role_sw)) -- 2.34.1