Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp2567688rwb; Sat, 6 Aug 2022 01:32:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR5oLMTR9wQSg/0NsJFeFbK0gu7yP4tgBjacuIpJ2FzPZEofBarPpSQXzbZq61OLEJxHZPW1 X-Received: by 2002:a63:c158:0:b0:41a:6685:59de with SMTP id p24-20020a63c158000000b0041a668559demr8806304pgi.95.1659774731423; Sat, 06 Aug 2022 01:32:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659774731; cv=none; d=google.com; s=arc-20160816; b=XPF9V4Hk9EN4wPyJe0OSOxjGYV/1uJRQlpAlaF/f7GpDxsUPRWT0eh0tyGBK601ucd 6P22N2cFP7PPP8vOUTPYNGveusXamamsDeC+lb78p2VhFouKzW8/fhgLD2Mqs5unvzMF JmsJz2gKKgUyUsYvSIsslEUOL/NFNLVLJwPjajzbUCcC83UQ9/0oukuGzgSRibQZ/gNn xakIY0E29Lvb7NX+iMlRj1gMbwaw4b5WeMHL5wt3OoLJvV8YgPh2o11QFsqlKOMlomI4 BTODRo+uvVMa7kaQWaGJFvxyjwVKnTC3JUIG4SUcBTneyk+wb5PW3mEuu0NEp47sIKev Y2dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=k8UmK+Thqsvym4mmtink5O9lRMicTDQwBOnB8ntzrps=; b=pWNi7yd1a1aogP1gDT1yYxPNjpQP6EEjLqnikS39/XhNnyxt7Zen1iS1Zx5WQftmSA HPauWhg/WIof/EiZ8DJXpTmCpm20YgVsGQ+eCvNil+n9LIBK+/Vfd2402o61SRlr4FQR aDE5Mbb/iGKG03VlygwHiaNtTH4vrq/FGHw9m8DEokjLrRYnaThunuAL/DyVupw/3SON J11ZwPeJ+yFIYhEiCfXvjt0KxeyTMsl9ZXnhGOh8cJ0FCWtqs49UrzQSvw7MBb0mSJc1 S7UD5qyZZ4q77eC73o5XscM5S5gjyuo4TYueJthWrai36sXAlYlT46c8g6i3R8+zDg+U uP8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=jb4L7NzQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z12-20020a170903018c00b0016d2b3ddaaasi7307841plg.9.2022.08.06.01.31.49; Sat, 06 Aug 2022 01:32:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=jb4L7NzQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241596AbiHFI05 (ORCPT + 99 others); Sat, 6 Aug 2022 04:26:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229685AbiHFI04 (ORCPT ); Sat, 6 Aug 2022 04:26:56 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23DA515A07 for ; Sat, 6 Aug 2022 01:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=k8UmK+Thqsvym4mmtink5O9lRMicTDQwBOnB8ntzrps=; b=jb4L7NzQF5zkPqeU+Qjhdlil9l jWDA+jLDufuAIg/c0LJ2QdMuzR8zKgafeyplR7sGzFLeohJqlpegNDMAJe+T5T1kshgv71WWbVRjV RAcq/4d3vF5SkVXFUbmkeQwOzM1/Sm569ey4NviOUs+Zn1vwZtsvBLIxy2APAgfgmeiw8EJPbhtZf BbtL+/QVTpp6bv/ntS9gvzXh6O4DO7K8tA5EmAruK0GbJGrK8bYQGuCnZ15vLSlnHw1i8a61l0k48 onj82Y0+eZZIAm5hNuMqAUSlKFlaeEYsepYo5TnDEKhZlxcgDcRsP8eXmzTq/eTbcm3C8u+d6wY4O WvurDN+Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oKF90-006VN1-8e; Sat, 06 Aug 2022 08:26:50 +0000 Date: Sat, 6 Aug 2022 01:26:50 -0700 From: Christoph Hellwig To: Chao Gao Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, hch@infradead.org, m.szyprowski@samsung.com, robin.murphy@arm.com, konrad.wilk@oracle.com, jxgao@google.com Subject: Re: [PATCH] swiotlb: avoid potential left shift overflow Message-ID: References: <20220805114438.102085-1-chao.gao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220805114438.102085-1-chao.gao@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 05, 2022 at 07:44:38PM +0800, Chao Gao wrote: > The second operand passed to slot_addr() is declared as int or unsigned int > in all call sites. The left-shift to get the offset of a slot can overflow > if swiotlb size is larger than 4G. > > Fixes: 26a7e094783d ("swiotlb: refactor swiotlb_tbl_map_single") > Signed-off-by: Chao Gao Can you just convert it to an inline function? That will take care of the typing in a much cleaner way than a cast.