Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp2583730rwb; Sat, 6 Aug 2022 01:59:46 -0700 (PDT) X-Google-Smtp-Source: AA6agR6go3+nfQ7+oRYDfFZHUiTcoXw1qLmi1oQN74Ce8XMX+fmTm0DctbtbBzIgdcUkOHDTyMho X-Received: by 2002:a05:6a00:23d0:b0:52e:74be:d52 with SMTP id g16-20020a056a0023d000b0052e74be0d52mr10422982pfc.62.1659776386494; Sat, 06 Aug 2022 01:59:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659776386; cv=none; d=google.com; s=arc-20160816; b=cSNp886w1mtYLWjdu16C1FOfF+8xiAvibzS2szqB7Sy8547FF15WQYZsyUAvxDAi1R iXAic8b5kWwDOLlZRylvM7TwW1gOsSMkm+31je4Q+p8atfoUXqvPeRrnP1lsk43JcRzv QGqzI1Zp1v3p4w7eiDgCsu/VwAlsl6O2QDup/zYTK4KhlYwtFyLyXpHBXglxpUf8S2GX /jrDgUAW4ZZWFiKZo4kTrvblI26lqTf8SVHngUR1fs2a4dsF87R8KNDAMZlQlbbGkdS6 vxuHEXzrtvbJE129uHbN/uiJi68H3eVKK2ieTyOs0XW1lvgr4D8t6L/M+ECl/oNvZl6l CAgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:to:dkim-signature:dkim-signature:from; bh=jD62rE7HTpABv1viMwh70H2T9Lk2mqB4lZpeEUAn7rs=; b=zroVBf6Cmw5CsE0Gbb/2ik3tzcyDiKNCrIGyGXn3TP8Xu4r9fWLolwmrI0VQCby3rG 21r7UeU8Yy1Bv/S/BQ6/QBsS4vCytFD6WgwneGmh85JIGplCBjd4ITuHm/LVpuR8eOyp C/kjHbZuJapfzVeIMKDYpcgTUIog+DqLGcyWqlu5R+gRV7y+S6G0e8UpSSDvivZUCcwD PvBMbKqkOm4sD/gJFKXb1BaKcr6Emmt2RySfH3begJ4GBEH/EmbR4Sbq9IH2eW9CI5Di OC71KI8Jx4tlv7ToX+ZVCg2DNlTkaQKDi3hePZ7RtQ8JvLWMCLMYzws4IewK0Fm2z58w 8lTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=E1CMU6Dl; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=+4GPKoy6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p187-20020a6229c4000000b0052ade51b8a7si6131803pfp.361.2022.08.06.01.59.32; Sat, 06 Aug 2022 01:59:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=E1CMU6Dl; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=+4GPKoy6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230054AbiHFIa7 (ORCPT + 99 others); Sat, 6 Aug 2022 04:30:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229685AbiHFIa6 (ORCPT ); Sat, 6 Aug 2022 04:30:58 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71298E0E5; Sat, 6 Aug 2022 01:30:56 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1659774653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jD62rE7HTpABv1viMwh70H2T9Lk2mqB4lZpeEUAn7rs=; b=E1CMU6Dl6hEHJsFFfONIFG26dG22lAy7Is0O1sAUYTeZ1srkiAZEe7JFtbZNyesMnJfwOG hUl5AvC0Q8mnm7GZzQ3J9/Iia437hi/gbtkY9hUoRA2lsMHbLgyX0UVJfWQtPEGx9PIkOy rVD4sGRedtJ32HjEjEm9vP2eUpVmvdQFXNbNNIwQ5GRxdCI4/pWC1nCj+dC83MG0pvimJs CRA9OKRL9jFO8rI43SoZSPV0YOAncDpoI6HG3tT/L+O7pxrJWFyCgdOHNayh2shIlZhFXa efXnddpctbWVUHH8KUnM/OgSzjMbs4JEdGxiriLaW5qE/huno18y5Yk2LZPGoQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1659774653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jD62rE7HTpABv1viMwh70H2T9Lk2mqB4lZpeEUAn7rs=; b=+4GPKoy6VlEqy5c/lQ6BDMSTFeovlKihb/Hs4NPgW3pr8Uvtc+BYZDVGQyr5zslyvGvo1n CF9bgtDm4R23oZCA== To: Yury Norov , linux-kernel@vger.kernel.org, Alexander Lobakin , Alexei Starovoitov , Alexey Klimov , Andrew Morton , Andrii Nakryiko , Andy Shevchenko , Ben Segall , Christoph Lameter , Dan Williams , Daniel Borkmann , Daniel Bristot de Oliveira , Dennis Zhou , Dietmar Eggemann , Eric Dumazet , Frederic Weisbecker , Guenter Roeck , Ingo Molnar , Isabella Basso , John Fastabend , Josh Poimboeuf , Juergen Gross , Juri Lelli , KP Singh , Kees Cook , Martin KaFai Lau , Mel Gorman , Miroslav Benes , Nathan Chancellor , "Paul E . McKenney" , Peter Zijlstra , Randy Dunlap , Rasmus Villemoes , Sebastian Andrzej Siewior , Song Liu , Steven Rostedt , Tejun Heo , Valentin Schneider , Vincent Guittot , Vlastimil Babka , Yonghong Song , Yury Norov , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 11/16] time: optimize tick_check_preferred() In-Reply-To: <20220718192844.1805158-12-yury.norov@gmail.com> References: <20220718192844.1805158-1-yury.norov@gmail.com> <20220718192844.1805158-12-yury.norov@gmail.com> Date: Sat, 06 Aug 2022 10:30:53 +0200 Message-ID: <87fsi9rcxu.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18 2022 at 12:28, Yury Norov wrote: > tick_check_preferred() calls cpumask_equal() even if > curdev->cpumask == newdev->cpumask. Fix it. What's to fix here? It's a pointless operation in a slow path and all your "fix' is doing is to make the code larger. Thanks, tglx