Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3eacc364-90b7-7a5d-c936-1ed993428ef6@wanadoo.fr>
Date:   Sat, 6 Aug 2022 10:53:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Content-Language: en-US
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Question: dev_err_probe() vs Printk Index
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Janitors <kernel-janitors@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

When a driver is using dev_err(), part of it is inlined and it:
    - takes advantage of dev_fmt()  [1]
    - implements Printk Index       [2]

Printk Index works with some __builtin_constant_p() magic in it.
In case of a use in a probe, 99.99% of the time the log level and the 
format will be constant and the logic for Printk Index will be put in place.


In case dev_err_probe(), the format will be an argument passed to the 
function and will not be constant, so nothing will be generated in the 
'printk'_index section.


In case dev_err_probe(), a potential dev_fmt() defined in the drivers' 
file can't be taken into consideration.
(trusting my grep, we never use in files that define dev_fmt() in the .c 
file. I've not checked if it is true via #include "<something.h>")


Even if I've read [3], I don't fully understand the real need of this 
Printk Index mechanism (at least for my own needs :))


My questions are:
    - is my analysis right?
    - is the lack of these 2 functionalities (dev_fmt and Printk Index) 
expected, when dev_err_probe() is used?
    - if not, is it a issue?
    - should it be at least documented?


(not sure who to put in copy of this mail)

CJ

[1]: 
https://elixir.bootlin.com/linux/v5.19/source/include/linux/dev_printk.h#L143
[2]: 
https://elixir.bootlin.com/linux/v5.19/source/include/linux/dev_printk.h#L107
[3]: Documentation/core-api/printk-index.rst