Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp2628188rwb; Sat, 6 Aug 2022 03:04:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR5Jqvm7PPff5yi2aD5Rug8kyhY4ZMO6/wRMtHeeCnJSy0GlGAaiyE4RcdTObDWHGYNO/SzS X-Received: by 2002:a17:902:8343:b0:16d:d2ff:c91d with SMTP id z3-20020a170902834300b0016dd2ffc91dmr10206464pln.142.1659780295859; Sat, 06 Aug 2022 03:04:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659780295; cv=none; d=google.com; s=arc-20160816; b=nc3VOCKp3ti75oWwpjb1FJa4m+U3nm5+tZrT1MeIuIvetCOCZ1MNxZiB2BoCRJ9FrE YtbHFZUWMKE2s/YUKqzLmM/kp9WrL2m6kNx/EICvw3QeyfQOCO+RZeoLBmW5n6AKx/Vs 86sPn5uuRLiJp1ISBOlnwljg1ytMpCVH47UgCnFg644me4dj6mxwQvdO4KOSKdN90qX5 PMB+u694W3Fffwv3OIeMvxldNK02DkMuMJA5UaWRQzdW2tGS01iImbDfdDCzmGyoFpHV eofhw6087zqfoAJ5ESu4XLjIZa8dwKSQnx4lk4HHjS34CNZDJMGCpE57FnsS/08rgI2R 8PJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=tcz+EOVdYcZHlsH9SYESaKQOcLwMzzj4cFiUQj/3xW0=; b=uPDatSpd09N5oObKbNf4YoXV3IsxoJ4ymQNz6qer2KLI8AJ3rSk5wIPsy3IC7OkCyu cI5LXSk+se7ZlHXeJBEQe9TcSkaHXGiVNaKxD7nLyMMO9meDGNkQmi0mUS+pTi/w/5Uq iczjE5EYCEqHhAGCen3anJTS37FR81ou2JU2C++US122LUr0VvEsB8Rt11P4+4A6IskS gZiUqhjTBA8rEFMCsnProVMuKV9MpQHjfoHiB7nur//OdfF+ISKLXh2aAqBMYsYZeGHM NrfEEeRgAd/pRfJGH4cvEScCpEIz4Af0PgA7vXQchAgAjs+lCupzw4AS52ZrLdqa3/47 fPmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=FCdFFjbM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 1-20020a630c41000000b0041cb0d39714si5757443pgm.360.2022.08.06.03.04.40; Sat, 06 Aug 2022 03:04:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=FCdFFjbM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241807AbiHFKBc (ORCPT + 99 others); Sat, 6 Aug 2022 06:01:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241827AbiHFKBZ (ORCPT ); Sat, 6 Aug 2022 06:01:25 -0400 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 088F7E0DB; Sat, 6 Aug 2022 03:01:23 -0700 (PDT) Received: by mail-qv1-xf2d.google.com with SMTP id u8so3355010qvv.1; Sat, 06 Aug 2022 03:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=tcz+EOVdYcZHlsH9SYESaKQOcLwMzzj4cFiUQj/3xW0=; b=FCdFFjbMwMg/s6HFx790Az8w4ZCawOEL2oYxgHvlY9jWlQcfHubH99eC+GJTYsl0LZ F05lEQ0OFoM4ii6D0TT1dQIeoaLxS2qNN2BntpYQ5ogfLlatZHWZgevmDmA+hCqod7HB URI/PYi/Y2w0LZd/jYCGttSgkv4GyaTFcJyoyOHAY6W0DKjLCWaISBQbU4pUEd4R7HOk 8HB6dWygBdxYUGkAgmdeb5uH1ObJ4ULsPqC3ShK1CRTkU+MEFJVWe/yVIQv1kibjAaKc 4Xj8KZ2nur6QTsDH/e+DFATKdcIaCom0515NVDQhm7YUlrRcoe308JZ1uGTi9x7WPIyC w2KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=tcz+EOVdYcZHlsH9SYESaKQOcLwMzzj4cFiUQj/3xW0=; b=F0F4himsn4DLpxA+DDgMph1k3u6nvPv6kh3sIwAmYE9Imo7FBn/xlR5d3dEk0a7817 nbWbA0RrEQbb7HxaiITORynrnW+l1HGVmbGJxF71qtKi33klJ5lbgR1mPKphittxsrR9 VfXoz2KVzTU6akzRgyBko2c9s/X3RLUuOaMWEliKbcbNnkC0vEVVAJp24abgE5jIS3T7 Q+t1BqVnnE4z/RjIkb42kPzJAfpxlaVIMIIKBo5Oa83FK0wGb0Thhcryord3MTDVKEBj OmzM7Kjy31UzTWAWWo2V3J1lmmONdyFLC0CPyCRGMdvTxM+b/aLiL6HP10OtYPbeWZXS Dslw== X-Gm-Message-State: ACgBeo1Ww3sfkxSqg4t8/pGIoASVoSIUnZD1t9VM5fCpjo23TnPsHT9r ODT0kxgVCxoH09KpFgpn9lPPTy8Z35nUXVA0RyVvPNJ14Ak= X-Received: by 2002:ad4:5baf:0:b0:476:6a9e:b5e1 with SMTP id 15-20020ad45baf000000b004766a9eb5e1mr8933644qvq.64.1659780082142; Sat, 06 Aug 2022 03:01:22 -0700 (PDT) MIME-Version: 1.0 References: <20220805081909.10962-1-luke@ljones.dev> <20220805081909.10962-5-luke@ljones.dev> In-Reply-To: <20220805081909.10962-5-luke@ljones.dev> From: Andy Shevchenko Date: Sat, 6 Aug 2022 12:00:45 +0200 Message-ID: Subject: Re: [PATCH 4/5] asus-wmi: Document many of the undocumented API To: "Luke D. Jones" Cc: Hans de Goede , Mark Gross , Platform Driver , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 5, 2022 at 10:21 AM Luke D. Jones wrote: > Missed commit message. > Signed-off-by: Luke D. Jones ... > +Date: Dec 2022 I would be more optimistic here... > +KernelVersion: 5.17 ...and definitely this is the wrong version. I would suggest 6.0. Both comments are applicable for other similar cases. In case you are documenting new and old APIs, split this to two patches with different dates and kernel versions. And commit messages should be different. -- With Best Regards, Andy Shevchenko