Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 7 Aug 2022 13:44:06 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     carsten.haitzler@foss.arm.com
Cc:     linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
        suzuki.poulose@arm.com, mathieu.poirier@linaro.org,
        mike.leach@linaro.org, linux-perf-users@vger.kernel.org,
        acme@kernel.org
Subject: Re: [PATCH v5 12/14] perf test: Add unroll thread test shell script
Message-ID: <20220807054406.GJ34254@leoy-ThinkPad-X240s>
References: <20220728145256.2985298-1-carsten.haitzler@foss.arm.com>
 <20220728145256.2985298-13-carsten.haitzler@foss.arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220728145256.2985298-13-carsten.haitzler@foss.arm.com>
Precedence: bulk

On Thu, Jul 28, 2022 at 03:52:54PM +0100, carsten.haitzler@foss.arm.com wrote:
> From: "Carsten Haitzler (Rasterman)" <raster@rasterman.com>
> 
> This adds scripts to drive the unroll thread tests to compare perf
> output against a minimum bar of content/quality.
> 
> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
> ---
>  .../shell/coresight/unroll_loop_thread_10.sh   | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100755 tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh
> 
> diff --git a/tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh b/tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh
> new file mode 100755
> index 000000000000..f48c85230b15
> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh -e
> +# CoreSight / Unroll Loop Thread 10
> +
> +# SPDX-License-Identifier: GPL-2.0
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +
> +TEST="unroll_loop_thread"
> +. $(dirname $0)/../lib/coresight.sh
> +ARGS="10"
> +DATV="10"
> +DATA="$DATD/perf-$TEST-$DATV.data"
> +
> +perf record $PERFRECOPT -o "$DATA" "$BIN" $ARGS
> +
> +perf_dump_aux_verify "$DATA" 10 10 10

Just minor comments for checking the trace data quality:

The unroll program loops for 10000 times per thread, and this test
creates 10 threads; so if we pass the parameter "10 10 10" for
perf_dump_aux_verify, seems to me this is very conservative?

I would like hear Mike's opinion for these quality metrics; the
patch itself is fine for me, you could add my review tag:

Reviewed-by: Leo Yan <leo.yan@linaro.org>


P.s. it's off-topic, just want to remind to use the "b4" tool when you
spin for next version's patch set, e.g. you could use below commands:

  $ b4 am 20220728145256.2985298-1-carsten.haitzler@foss.arm.com
            ^
            ` I get the message ID from the page:
              https://lore.kernel.org/lkml/20220728145256.2985298-1-carsten.haitzler@foss.arm.com/
  $ git am ./v5_20220728_carsten_haitzler_a_patch_series_improving_data_quality_of_perf_test_for_coresight.mbx

We can benefit from this due "b4" can automatically append tags in
patches; this can help us to track which patches have been reviewed
and tested in previous versions.

Thanks,
Leo

> +
> +err=$?
> +exit $err
> -- 
> 2.32.0
>