Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp3477728rwb; Sat, 6 Aug 2022 23:47:27 -0700 (PDT) X-Google-Smtp-Source: AA6agR54HVniYOJ1QLGIOF1CVO2MEGRz4/+rA9tZo1Lns/+mvKdG1uLvHbXR15SPnKVsI+eZsXKG X-Received: by 2002:a05:6402:c47:b0:437:ce2d:c30d with SMTP id cs7-20020a0564020c4700b00437ce2dc30dmr13092360edb.395.1659854847218; Sat, 06 Aug 2022 23:47:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659854847; cv=none; d=google.com; s=arc-20160816; b=lAvGWElpLg0h4yZES4FNmTEwjewzktJ2vy4+RPKS0YkuvWMmUgrhEYj2JF9+slhSYr 4uuKdA1VeYcLva4RNjklyt/N8eGae0J2XQ+T9aVKcSl1NIXH8PZMNiZ9T2gx191X2Rid PViNtK0fteKVGiE/oD63mvCtV+jZYv4hgc0hzraoC6o3NoTDN5xv5VLvbh5HnsOI+xdZ IIUDlXUtPawymW91CNcz1AqbH5d/IyblvQSbchP1pracv7LStpm3F2W5TI3AK8d9FeIU ApB6Cinw253evkqXGcqvmLNaPTj/C6SwUnG8N2wHg1ejy64qlu2bBTnhsvjCQSKW3kB5 PSXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Gokc9LKWBZOdQKNpS5Em8+LXEGZMlphu0Qca2UPW+6g=; b=1D9w27Mfb/yv0dapU4LZ+RlDFFzc1l2UcFPe4C6luk7DmVeyIS0Sn5EBXD7On98a6O T3BENHM6wq2rwEB0pVpmczhMndQ7BMjV3esHHX8TlGIMC6leHFB7HCF6KTt/6Z0CjnOD qbwn3b8Y1iUHlOMBF7SsofMfohn93+7DGB32Q/6UKQLleJXG7DFkPmu3TEzc0jMvq7L/ 3aON+MOEaL9Ef1UNbapNdCN+ST0x9q542nxmOIeUU6ITewM3On8FMQTzey+3pFXkKDO1 eUTOFSbIU6KM7EvwqmVUK4nZIV4Ta1Jsn49bJH55NwYfQXKeoNfAm5craHrmil+t6XeZ NjwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=KS83bs0u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b19-20020a056402279300b004379c601345si3972828ede.569.2022.08.06.23.47.02; Sat, 06 Aug 2022 23:47:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=KS83bs0u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232830AbiHGGCH (ORCPT + 99 others); Sun, 7 Aug 2022 02:02:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232875AbiHGGCG (ORCPT ); Sun, 7 Aug 2022 02:02:06 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8433F1055B for ; Sat, 6 Aug 2022 23:02:05 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id x21so7922295edd.3 for ; Sat, 06 Aug 2022 23:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Gokc9LKWBZOdQKNpS5Em8+LXEGZMlphu0Qca2UPW+6g=; b=KS83bs0uJMS0Jd+OTiJ+DjO8PzMhL1EJ4+salp9t06ImJPRrX9dLLiBCsEf4EJnz8P WfCCVK7WDSqRyPYImOMFRVwu8v07haUcJ8F005OqKBph01Hlg3SgdpooKBsgxbjABF0B 18DQHEM9gvLXJ7HbVFK7q+P/08Of1dxybmqj+gbyZZ38GYMZBMguFlMkY4n4b3iE5vUf m/Vihiqpe3i2B/qzUuQ9iGTsWIj4dI92Vb+IsI32NSvVJpJckb5IKqwufXx0TRuI58mK N77TjlnqauxfbonZTAxwPmlxGZ4DSogjVgaJYNn0WYpErJSpUVq5EcT5LQsFg6ajRxjv 5zoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Gokc9LKWBZOdQKNpS5Em8+LXEGZMlphu0Qca2UPW+6g=; b=PJ9viqffXZUmtVP1Z3KdFxjAVspSdrbYOpXS5kjNSRZtTOxvj3W8x1hjQ5wi238WOL ugc9BoCiRx3E0sKrQ9Y0GnoNWp4kUlCejVnw6j5LLU2yOOJrOQgxDTCYZT/gbsAjITUh d/OdXg5l8HeGp85reIsE8YrAppeP4xmqj3I+SN6UzvyLL5UZ5wBfb1OmPCYpe5+09ZHO eZBvDkgekpoQegfeT5sPdybabtdkwjxNdaDmulNp13ncjYtjJrfIja/Zsy7L0TePefhf 4qxbRGysNOfvIZE1VeaZQrUzPes6Q++WVFA051aVH5uD71ep6HikDL8SH8ZH+6Tv07Rr udWA== X-Gm-Message-State: ACgBeo3cgQvsau6aMLpOtoRLHkwzocXby/lFsapyw93dfibej8V9u6fn l1SHdvaaoCotNek3VqtbSP4= X-Received: by 2002:a05:6402:11c8:b0:440:6513:be2c with SMTP id j8-20020a05640211c800b004406513be2cmr4405670edw.45.1659852124086; Sat, 06 Aug 2022 23:02:04 -0700 (PDT) Received: from [192.168.1.103] (p54a07b82.dip0.t-ipconnect.de. [84.160.123.130]) by smtp.gmail.com with ESMTPSA id y18-20020a1709063db200b00726c0e63b94sm3457071ejh.27.2022.08.06.23.02.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Aug 2022 23:02:03 -0700 (PDT) Message-ID: <2f7a15aa-c4bf-38e4-aca4-d3fa20a800e1@gmail.com> Date: Sun, 7 Aug 2022 08:02:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 00/13] staging: r8188eu: simplify endpoint configuration Content-Language: en-US To: Martin Kaiser , Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220806195540.777390-1-martin@kaiser.cx> From: Philipp Hortmann In-Reply-To: <20220806195540.777390-1-martin@kaiser.cx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/6/22 21:55, Martin Kaiser wrote: > This series contains cleanups for rtl8188eu_interface_configure and the > functions that it calls. I tried to fix the error handling and to > summarize small functions and common code. > > Martin Kaiser (13): > staging: r8188eu: Hal_MappingOutPipe should return an int > staging: r8188eu: process HalUsbSetQueuePipeMapping8188EUsb's return > value > staging: r8188eu: merge two small functions > staging: r8188eu: move endpoint init functions to usb_halinit.c > staging: r8188eu: summarize endpoint-related settings > staging: r8188eu: remove OutEpNumber > staging: r8188eu: remove comments about endpoint mapping > staging: r8188eu: summarize common Queue2Pipe settings > staging: r8188eu: simplify three_out_pipe > staging: r8188eu: simplify two_out_pipe > staging: r8188eu: remove _InitNormalChipOneOutEpPriority > staging: r8188eu: we always use HQ and NQ for two endpoints > staging: r8188eu: simplify _InitNormalChipTwoOutEpPriority > > drivers/staging/r8188eu/hal/hal_com.c | 110 ------------- > drivers/staging/r8188eu/hal/usb_halinit.c | 152 ++++++++---------- > drivers/staging/r8188eu/include/hal_com.h | 2 - > drivers/staging/r8188eu/include/hal_intf.h | 2 +- > .../staging/r8188eu/include/rtl8188e_hal.h | 1 - > drivers/staging/r8188eu/os_dep/usb_intf.c | 4 +- > 6 files changed, 75 insertions(+), 196 deletions(-) > Tested-by: Philipp Hortmann # Edimax N150