Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i5ec1447f:Fastmail
Date:   Sun, 07 Aug 2022 19:44:23 +1200
From:   Luke Jones <luke@ljones.dev>
Subject: Re: [PATCH 3/5] asus-wmi: Add support for TUF laptop keyboard states
To:     Pavel Machek <pavel@ucw.cz>
Cc:     hdegoede@redhat.com, markgross@kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Message-Id: <ZTI8GR.GMVLPPJWYEO53@ljones.dev>
In-Reply-To: <20220805120859.GB20036@duo.ucw.cz>
References: <20220805081909.10962-1-luke@ljones.dev>
        <20220805081909.10962-4-luke@ljones.dev> <20220805120859.GB20036@duo.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Precedence: bulk

Hi Pavel,

I'm sorry but can you direct me to a source file or other that shows 
use of "pattern trigger". I don't know what this means or what to look 
for. From your response it seems I should certainly be using it.

I've finished with all the feedback I've received so far, and this is 
the last piece.

Kind regards,
Luke.

On Fri, Aug 5 2022 at 14:08:59 +0200, Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>> 
>>  Adds two paths:
>>  - /sys/devices/platform/asus-nb-wmi/keyboard_rgb_state
>>  - /sys/devices/platform/asus-nb-wmi/keyboard_rgb_state_index
> 
> Patches 2-3 -- we already have pattern trigger. This should use it...
> 
> Best regards,
> 									Pavel
> --
> People of Russia, stop Putin before his war on Ukraine escalates.