Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 7 Aug 2022 10:34:38 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Guenter Roeck <linux@roeck-us.net>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
        linux-hwmon@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH v1 1/3] hwmon: (pwm-fan) Make use of device properties
Message-ID: <20220807083438.qqe3mzp43aytxbcl@pengutronix.de>
References: <20220806152517.78159-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cyr72olrnz2pj6sn"
Content-Disposition: inline
In-Reply-To: <20220806152517.78159-1-andriy.shevchenko@linux.intel.com>
Precedence: bulk


--cyr72olrnz2pj6sn
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

[dropped Bartlomiej Zolnierkiewicz from Cc:, the address bounced in the
past]

at a quick glance this looks nice. I wonder if it makes sense to split
the patch. For example the change

-	ctx->pwm =3D devm_of_pwm_get(dev, dev->of_node, NULL);
+	ctx->pwm =3D devm_pwm_get(dev, NULL);

could stand alone. Also I think this change is the relevant part in
patch #1 that makes patches #2 and #3 possible.

When this patch doesn't get split, the series needs some coordination,
as patch #1 is for hwmon and patches #2 and #3 are for pwm.

Splitting the series into:

	hwmon: (pwm-fan) Use of devm_pwm_get() instead of devm_of_pwm_get()
	pwm: core: Get rid of unused devm_of_pwm_get()
	pwm: core: Make of_pwm_get() static

for pwm and the remainder of this patch for hwmon might make application
of the changes here easier to coordinate.

But still: Thanks for your effort and
Acked-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--cyr72olrnz2pj6sn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLveRsACgkQwfwUeK3K
7AlYvAf9Fs6FxfhGO/8+92dqWG12KLB3savGpw7vewwC23P4tEeDe47oGyush1I+
dtNJIS7tOxBRoAFOHGkhSXVTW6tT/lDpA41tzt7mZ8mQvBpbeFR4UM1YeSEDs+m8
o0x680woxrqdtqmwNvNyOa7ssUuxL0VpNVIOCXAoUsjKlFPEljvG/0hEofXpWoSa
BG5t68iIXjTcAC60DpqPE8ww9Gk5qD/BnMqp//nNS20r0EfPO/BBooeKvV8Du1XZ
PqM4TqPpwZk1GlKrMS9OIFlyNCbD/Qya8AJKAKmKqCMzARw+Sm+0aTsI8bkK6jC5
UJbLdfFNuY2z4iKJ13TUo3ewsMQ1Tg==
=/6F+
-----END PGP SIGNATURE-----

--cyr72olrnz2pj6sn--