Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp3620034rwb; Sun, 7 Aug 2022 03:51:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR4zX3JppUBWHs1iJT06p8nMLbXkVlrts1nq8AYq8ckhiLX32kAOfGDLbY89F7f1ohY+LOFN X-Received: by 2002:a17:906:93f0:b0:730:6d4e:970c with SMTP id yl16-20020a17090693f000b007306d4e970cmr10855215ejb.188.1659869465450; Sun, 07 Aug 2022 03:51:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659869465; cv=none; d=google.com; s=arc-20160816; b=E36+IJhQ+BPI6cnl40hnK9FDdR8B0umWrJ/hkeBOUwwmeNpZmJXqSt/6/YwDP6cQ1N 7m82W3TbFtmOzGcP/cg6buzJSCVJJbuCJ1G3JZkT2/p/JcinENK5kMjRvFcj5tI0T4ua w3gDbjAgw9Awejc/VFt+OMeYdX1OA7owD5tk0AL2rEg1NuscAx9JcYiTH/5oOEi5ehuU ehGdgH5vDCHrG9awW1UKDANOHzei3aC0sorM1+I5e0Zyx62pfTohyfQ25X5OuizvT2op 7v1c9Yi2dD/6YPRKaaydeaw0ac3KbklakPTmyg9w9uJEsFtNtKYHTRylrrXCwkjO0R3g OqmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=q0iCh5uIlcUWx769Xlap9uF9I3kZ/wVQv4SF/RfY30c=; b=wjUpoT9I24zcomB5ZafRX6GdELhUB7QhbpT8oZlWfr0l4xuZKV/gyx6+23ta1Z8Cmu nBNxOVHz6+WFT5F9ZhP0SebBggQc8gLoLvh7+H6UmyRHJ7xGwIYwENuHKiA3f+NIjtmD VrUCE5ED3jI51v3TgYORbBLoDtqYfUg7/Ry42bsD4ZiaWnLh0ts/ghh2vOTSymtRjLm9 SlXLhzFUQ3/9jszTAfGbVyVftHIAG+3DrnDWn/LSXg9LjEVKrH1v/wPVCUuQaQHwvGuT c2X8d4F6cFBIgMFSFOmtafoO7cqy64m1Y3nmmSytlf8qp+t7T4igT2Lm6+ecbIOfGXYx OL3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=jBkPtZmL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho41-20020a1709070ea900b0072b4b8a0ce7si9581469ejc.946.2022.08.07.03.50.39; Sun, 07 Aug 2022 03:51:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=jBkPtZmL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233452AbiHGKks (ORCPT + 99 others); Sun, 7 Aug 2022 06:40:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232071AbiHGKkr (ORCPT ); Sun, 7 Aug 2022 06:40:47 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C840F22E; Sun, 7 Aug 2022 03:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1659868838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=q0iCh5uIlcUWx769Xlap9uF9I3kZ/wVQv4SF/RfY30c=; b=jBkPtZmLIjOBQMs6R/bHNoG+8VDe3eBGaXRXxMv6asYSibty24L+lnLis1EcqP/zcfRIe2 FAGlSVF8hsCld/vFy2zfLy30CHt3IsA1rbO5t9Bs6qvj3z8drKnZ+F8PGXF8lzNBXZ14W7 TqJ9hq7bBfhZIP1T3O1ht2HBU8VAQp4= From: Paul Cercueil To: Pavel Machek Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil Subject: [PATCH] leds: max8997: Don't error if there is no pdata Date: Sun, 7 Aug 2022 12:40:27 +0200 Message-Id: <20220807104027.10808-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver will works just fine if no platform data was supplied. Signed-off-by: Paul Cercueil --- drivers/leds/leds-max8997.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/leds/leds-max8997.c b/drivers/leds/leds-max8997.c index c0bddb33888d..c8d7f55c9dec 100644 --- a/drivers/leds/leds-max8997.c +++ b/drivers/leds/leds-max8997.c @@ -238,11 +238,6 @@ static int max8997_led_probe(struct platform_device *pdev) char name[20]; int ret = 0; - if (pdata == NULL) { - dev_err(&pdev->dev, "no platform data\n"); - return -ENODEV; - } - led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL); if (led == NULL) return -ENOMEM; @@ -258,7 +253,7 @@ static int max8997_led_probe(struct platform_device *pdev) led->iodev = iodev; /* initialize mode and brightness according to platform_data */ - if (pdata->led_pdata) { + if (pdata && pdata->led_pdata) { u8 mode = 0, brightness = 0; mode = pdata->led_pdata->mode[led->id]; -- 2.35.1