Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 7 Aug 2022 14:41:02 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Luke Jones <luke@ljones.dev>
Cc:     hdegoede@redhat.com, markgross@kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] asus-wmi: Add support for TUF laptop keyboard states
Message-ID: <20220807124102.GA32221@duo.ucw.cz>
References: <20220805081909.10962-1-luke@ljones.dev>
 <20220805081909.10962-4-luke@ljones.dev>
 <20220805120859.GB20036@duo.ucw.cz>
 <ZTI8GR.GMVLPPJWYEO53@ljones.dev>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="oyUTqETQ0mS9luUI"
Content-Disposition: inline
In-Reply-To: <ZTI8GR.GMVLPPJWYEO53@ljones.dev>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--oyUTqETQ0mS9luUI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> I'm sorry but can you direct me to a source file or other that shows use =
of
> "pattern trigger". I don't know what this means or what to look for. From
> your response it seems I should certainly be using it.

Trigger is at drivers/leds/trigger/ledtrig-pattern.c , you'd want to
do something similar to drivers/leds/rgb/leds-qcom-lpg.c .

> I've finished with all the feedback I've received so far, and this is the
> last piece.

Actually... you may want to submit version without patterns at
first. It will be easier to review.

Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--oyUTqETQ0mS9luUI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYu+y3gAKCRAw5/Bqldv6
8pvsAJ4yN0Qm5NRqNExZoBRtdHXPWcMD4gCgwOm4s4MRF5KY2Mms/Bp6hCZs9FY=
=fpCX
-----END PGP SIGNATURE-----

--oyUTqETQ0mS9luUI--