Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 7 Aug 2022 13:02:37 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Ingo Molnar <mingo@kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        "Rik van Riel" <riel@surriel.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [RFC PATCH 5/5] x86/entry: Store CPU info on exception entry
Message-ID: <YvAaXet3sBg3mRDe@iweiny-desk3>
References: <20220805173009.3128098-1-ira.weiny@intel.com>
 <20220805173009.3128098-6-ira.weiny@intel.com>
 <5d62c1d0-7425-d5bb-ecb5-1dc3b4d7d245@intel.com>
 <Yu4t0jkpIY4grgxL@gmail.com>
 <Yu4wON0MRGH7h5Jv@zn.tnic>
 <Yu+Nwbn4CZUmyD14@gmail.com>
 <Yu+VV8xFTYRh0D0a@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Yu+VV8xFTYRh0D0a@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qjhX9Uo3r715HwOjWXKcZDf0c+fMlsn/pOm2QyePo0QjLAvshzDbed3Uysny?=
 =?us-ascii?Q?Lk61kiBQBhyXkyLOcOKTxmS+lQGxoTU7gW+zvTvSSNNp/Jsol8CfT/uP9dy/?=
 =?us-ascii?Q?OyuKn2Aniw9WAphrwlka9dy59rVJrdEthFRrPsJRbktf4pc7tIjC+NZcGCQ2?=
 =?us-ascii?Q?egzh4ppPL80MxnmOQKzFiwP7BavkFC6XU9y9mlZw5OeTNu4XbbNb4mctWTen?=
 =?us-ascii?Q?RL3skf04IqoBLqFRowe2O/zbOTNkCZ0FBeWXTdYBIxCpY7YjouAL+mfVy2/5?=
 =?us-ascii?Q?Y0RyVNLasNo/oAvZVsGTuuQkmmlJ3A4enDtSf18OR3TQ6WjBMOdVV7Hrl0Qe?=
 =?us-ascii?Q?IIxjS7vuWwIP9q9uKDTZ89U1GoUg2b9mnjRVni9r0SAZkOfwLUXZCEV9xDq6?=
 =?us-ascii?Q?WsHWq+kRAeoKcARGKgamnQZK+usM7MXyoGwN/laDiskjk7YOJWOgJbuBnBk7?=
 =?us-ascii?Q?ZRDIg2Pc59eA7QNh3z4fzNu6wPg/Ve+WBfDaMhZxtZma+VuBxsgACSgGeeFW?=
 =?us-ascii?Q?O1Qr4Pm2krs+IYnA97mEcPnK29/hOl1Jvvcq9Az/bdB1MQFELhihAF7O/KYt?=
 =?us-ascii?Q?hdeT9rExGEa5ihlDQoTYnW/avBdQQbpK48Kg54qi1QwjY9wDqlasCGekeevX?=
 =?us-ascii?Q?MK7ghd0bmy6Qr3MojQlzuQMIQ0bAY4vpzCZqOhWZKxzV1vSUabRpacORSNwY?=
 =?us-ascii?Q?MLPNoN2i2yeT+bEJGbaAQkyw/arL571nYdRR5PakOgc/U0SrO6f46wpj/lmp?=
 =?us-ascii?Q?3A7HtJGk/s9BP7D7lPxUjH21cXCm721/ATFJfS/Y08hxv/bSmaGE3rW9cw+J?=
 =?us-ascii?Q?5M1i92XzJsVxv+O6FObKmc9fVojDoyQK6zrNnXE8SgdVil6n19ZI6yERuR1l?=
 =?us-ascii?Q?Oma7pNAnxN6Gnm46HC6EfCLw/p+T7gs3ktbWGz7TZndAo/2gb760MVBvstqV?=
 =?us-ascii?Q?2mmfEG8sy8KCRYyUiOUCUDFM3L6pRIUfbPqCpd6JcVa8/STCSLZBaISXz51+?=
 =?us-ascii?Q?eYZ129MnDE018M2N4czA2JofUIxrj1123OW8h/iBjH7IwJg6DWw5xQgHHVZR?=
 =?us-ascii?Q?H9Kxtp6F4MDXvUEqxywo6Q8N8wfKkAXjkQYB84sNTd3MEgOPhzI6l196fa8Z?=
 =?us-ascii?Q?pz+zEZTihkfsYqUpBb5l7MEJKzs7lUdbXBFrPI4Du7J9JKuNm2ziUAZWpbxJ?=
 =?us-ascii?Q?4iQVSfmNk8e7uJGuzGfNXs/f35aDJwWHmR1H7t/edHJYuc4gAUIg4UtcaZnp?=
 =?us-ascii?Q?dKK+TNJCrcqjOtgoGjDgdiwd8uZc1bn1wu0gg0GB0f+6MTec0yGk1SsVm7f2?=
 =?us-ascii?Q?3CXfGZ8cveBULYO9Dz7hUsXwtgOsPvLI6FPBhIzmm3o8MNQi8vwbG8GmNAMf?=
 =?us-ascii?Q?M6AQzm1Dx2LO+YtES1SU57TYjnpyBYMFfnUTNct56eBBNwwJjRe1P9i89/+5?=
 =?us-ascii?Q?nmE4J2xKA9XUFaotElZikVhAypWc3qEqJYE5NZk4FWyLylDc2x+KoEC+JyDx?=
 =?us-ascii?Q?rtbG9LdtJPu5zS/ORYgSX1GM++Grmh89MJk0w+DgyyRBgwQ8a0WBmqd+58qE?=
 =?us-ascii?Q?SF/9xW5+3FIFhsbwDCNw9LrqEtyMEGlQtza3enX4?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 68e83432-3b36-465b-5ad6-08da78afc959
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2022 20:02:42.2157
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eP+yPNow2bzfHyIdWNdvTmiukjNhyIAIEe6e2upCpXsEC3bup7R5LH6bN5e16eCtLXKOer4u6l3hrXaP9DQZQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5534
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Aug 07, 2022 at 12:35:03PM +0200, Borislav Petkov wrote:
> On Sun, Aug 07, 2022 at 12:02:41PM +0200, Ingo Molnar wrote:
> > * Borislav Petkov <bp@alien8.de> wrote:
> > > With the amount of logical cores ever increasing and how CPU packages
> > > (nodes, L3 sharing, you name it) get more and more complex topology,
> > > I'd say the 2 insns to show the CPU number in every exception is a good
> > > thing to do.
> > 
> > We can show it - I'm arguing against extracting it too early, which costs
> 
> Not early - more correct. We can say which CPU executed the exception
> handler *exactly*. Not which CPU executed the exception handler *maybe*.
> 
> > us 2 instructions in the exception fast path
> 
> 2 insns? They don't matter at all. FWIW, they'll pull in the per-CPU
> cacheline earlier which should be a net win later, for code which does
> smp_processor_id().

I agree with Boris; however I feel that I have to mention that in patch 3/5 you
also have 1 instruction on each of entry and exit to push the extra stack
space.  So all told it would cost 4 instructions.

Again, I don't believe this is too much overhead but I don't want people to say
it was not discussed.

Ira

> 
> > - while in 99.999999999% of the cases we don't use that field at all ...
> 
> See my text above about the ever-increasing complexity of CPU topology.
> 
> Thx.
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette