Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alan Maguire <alan.maguire@oracle.com>
To:     rostedt@goodmis.org
Cc:     corbet@lwn.net, mingo@redhat.com, shuah@kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org,
        Alan Maguire <alan.maguire@oracle.com>
Subject: [RFC tracing 0/4] tracing: support > 8 byte filter predicates
Date:   Sun,  7 Aug 2022 23:21:19 +0100
Message-Id: <1659910883-18223-1-git-send-email-alan.maguire@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oiBSvg2gWXvFfWdoLNApBKMeDgYcbbXgLt8+lsT/6GmT+Z05labn4w5UJDOp?=
 =?us-ascii?Q?9DdJ6gpteTu36lnyKvzMdLG4xhJAI0tB2ygQH+PkdLADIIrePsLAgmpkZTFy?=
 =?us-ascii?Q?1yP01bQSHi5Rk7kL/MJr100J6Bw1d3C2wdGYAj+wPjwFwrwD9WEk6mrOqxZf?=
 =?us-ascii?Q?9n1dp2Dit+H/COXkdHN73oe5SgxBxwBcf0xbPukCuSHLathk4w8ZOOedjDqU?=
 =?us-ascii?Q?vy1GAs9PeZOojKx87HAPwbZDHYlpGPplf8KwU5pHz/Q3K7eq4IwNcDh3xT3J?=
 =?us-ascii?Q?Nsdtog8P6A2EqMGo7ic+yCoRYoPrz6vuYACmhQuGb+s8wTgy5aQRXh9xpJGs?=
 =?us-ascii?Q?HOzo//C24zUZ2gD3lPy/PPi1W//1xcB5dggdraB6dibJcrXRuqidYI5KWjTK?=
 =?us-ascii?Q?a+d7GFOi1iqH7C19Bw8u0b2OIVmGxRTLrId2KMjRQvneDSDnRWrq1P5+FA5l?=
 =?us-ascii?Q?IFbV37DB55YC0BBpB1NNJLsZDxt/wjlGV6ltVVG9L5lUf0ce1h2hxvU9pHmU?=
 =?us-ascii?Q?OIOYkppMTYAOUdTTd2vBIUF60Cf5tnfMWilm59D7LQVrfaODEof6aDv7VxHp?=
 =?us-ascii?Q?rA5kVcCEjHCiz/m1RLiTCXz8QAln1fjbBeTzheZ+BCO+c+7pMJdLiBO/j8Hk?=
 =?us-ascii?Q?7mCtPoPOLckW+cm7G+X/74hdEhRmOe7r7+2yCHLeQDuwPz+uHDGNbVv+J7NK?=
 =?us-ascii?Q?g6S9juvxqVON9msCD1dE5lDNWz2anVPOe9BwNsc2Nrow1fPWJDymRhbF2/bW?=
 =?us-ascii?Q?kTDHI5+iA5SPTTBy6JSGphM5mumC6IjEAptXtI+u0hzs8X9bjPpyo/HgdheD?=
 =?us-ascii?Q?RTVcePvJ7BoQlaTx3qhB/6r40bTDYpacn8blP0z+humAyBTxDqsL+YfyUq6x?=
 =?us-ascii?Q?bVEvcEN0REQU9+K4pj8sttnMSUDA0BgWq+Ra99CRjVf/DOI3JiDGIgBLhI0q?=
 =?us-ascii?Q?DknerZesEVoBv0hTeKs5hVCcbwnAaQyGTqckIaQggPLl2x4LPrKvFW22ovEE?=
 =?us-ascii?Q?HfDjUBcj+wRMVXAaD+SG1O5sf4ZSTp9uaA9bckokSUdtjrJWjdQEL5Kbf+it?=
 =?us-ascii?Q?C83cR0pHn5KkjOqkoTtoNc2aAarkSMi1zgr0DRaDom5OzSOpXZ9Y9vacZrft?=
 =?us-ascii?Q?NQ5CR46W63bYoEo1e884PWyR/fy3jC8KfUH8CYcNseCsPPABqCRoI73RXCF+?=
 =?us-ascii?Q?cWCArglpQ9u+wtzK9WOlW5yB2ODqTXEVUFn2ydjklYpInQmaZR/YIIE0TtWm?=
 =?us-ascii?Q?Bqnh31VOAyc2BaR4k+5KC/EfN9wJxkj3bBLYAw1do2ZeiWD8a92UT8GAfLMz?=
 =?us-ascii?Q?qeH4TzXQp1J7k1nPTbZZe/ZMcjKeobyK+pvCN7D5Ti/mDbw8WRL8VKbx3aJU?=
 =?us-ascii?Q?C1jIrEOJRJIoz57EIVrRh76N3k+51qda4cEst4jzzv9birOYuoBXr7lqwPxX?=
 =?us-ascii?Q?S44xO6gMGS5g4R0n2qdcFGxDRZc837nmfGfhawhT7aLGmQTSO6bhcz+EeXZa?=
 =?us-ascii?Q?MRt4hAVVKBgDqYBp+t7VLF7PWD+rme61LDbpEt1jTaQ/b2LGSbzMEm7N4/m0?=
 =?us-ascii?Q?Lpcxg9hLoUW+OK3c2NTbSWnSTKnp9XGyCpPqBPQr?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3c4a8f0-8772-49c6-0843-08da78c33166
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5267.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2022 22:21:37.2509
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qtV8xiNUgk+qL1uC2v1TcNO2L14LHYx6aqz9SyCtQk6CUqiu2LZmtrp4IVtMo8GMdwwhXPIzI+FcYRPqCU7rLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2381
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-07_15,2022-08-05_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 mlxlogscore=999
 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2208070119
X-Proofpoint-ORIG-GUID: -gguk092FezLH8-VRd1zq-EAGljttw-v
X-Proofpoint-GUID: -gguk092FezLH8-VRd1zq-EAGljttw-v
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

For cases like IPv6 addresses, having a means to supply tracing
predicates for fields with more than 8 bytes would be convenient.
This series provides a simple way to support this by allowing
simple ==, != memory comparison with the predicate supplied when
the size of the field exceeds 8 bytes.  For example, to trace
::1, the predicate

	"dst == 0x00000000000000000000000000000001"

..could be used.

When investigating this initially, I stumbled upon a kernel
crash when specifying a predicate for a non-string field that is
not 1, 2, 4, or 8 bytes in size. Patch 1 fixes it.  Patch 2
provides the support for > 8 byte fields via a memcmp()-style
predicate.  Patch 3 adds tests for filter predicates, and patch 4
documents the fact that for > 8 bytes. only == and != are
supported.

Alan Maguire (2):
  tracing: predicate matching trigger crashes for > 8-byte arrays
  tracing: support > 8 byte array filter predicates

Oracle Public Cloud User (2):
  selftests/ftrace: add test coverage for filter predicates
  tracing: document > 8 byte numeric filtering support

 Documentation/trace/events.rst                |  9 +++
 kernel/trace/trace_events_filter.c            | 59 +++++++++++++++++-
 .../selftests/ftrace/test.d/event/filter.tc   | 62 +++++++++++++++++++
 3 files changed, 129 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/ftrace/test.d/event/filter.tc

-- 
2.31.1