Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965092AbXFGS54 (ORCPT ); Thu, 7 Jun 2007 14:57:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932687AbXFGS5q (ORCPT ); Thu, 7 Jun 2007 14:57:46 -0400 Received: from gw1.cosmosbay.com ([86.65.150.130]:52219 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932745AbXFGS5p (ORCPT ); Thu, 7 Jun 2007 14:57:45 -0400 Message-ID: <46685508.2070805@cosmosbay.com> Date: Thu, 07 Jun 2007 20:57:12 +0200 From: Eric Dumazet User-Agent: Thunderbird 1.5.0.12 (Windows/20070509) MIME-Version: 1.0 To: Davide Libenzi CC: Ulrich Drepper , Alan Cox , Linux Kernel Mailing List , Linus Torvalds , Andrew Morton , Ingo Molnar Subject: Re: [patch 7/8] fdmap v2 - implement sys_socket2 References: <20070606235906.72439d16@the-village.bc.nu> <20070607001932.35c9591c@the-village.bc.nu> <466741BD.20106@redhat.com> <20070607110432.73be7960@the-village.bc.nu> <4668155B.4020705@redhat.com> <20070607195659.c695c87d.dada1@cosmosbay.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gw1.cosmosbay.com [86.65.150.130]); Thu, 07 Jun 2007 20:57:18 +0200 (CEST) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 42 Davide Libenzi a ?crit : > On Thu, 7 Jun 2007, Eric Dumazet wrote: > >> accept2(int fd, ...) > > I don't see any reason to not have it inherit the non-sequential > characteristics of "fd". > > > >> pipe2(int *fds, int oflags); > > I think pipe+sys_nonseqfd should be OK for those. yes, but O_CLOEXEC/O_CLOFORK ? I was refering to Uli wanting to close races on multi-threading apps doing a fork() while a thread is doing : fd = open() <---- race here if another thread does a fork() ----> fcntl( CLOEXEC) > > > >> eventfd2(int count, int oflags); >> signalfd2(int ufd, sigset_t __user *user_mask, size_t sizemask, int oflags); >> timerfd2(int ufd, int clockid, int flags,const struct itimerspec __user *utmr, int oflags) ... > > Those I think we're still in time to change the interface. No? > Even if not, those are not perf-critical, so I think that > syscall+sys_nonseqfd is still fine. Same point here, non a nonseqfd problem. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/