Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 7 Aug 2022 22:51:13 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc:     linux-kernel@vger.kernel.org, pmladek@suse.com,
        Kent Overstreet <kent.overstreet@gmail.com>,
        Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v5 31/32] tracing: Convert to printbuf
Message-ID: <20220807225113.6a74b481@gandalf.local.home>
In-Reply-To: <20220808024128.3219082-32-willy@infradead.org>
References: <20220808024128.3219082-1-willy@infradead.org>
        <20220808024128.3219082-32-willy@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon,  8 Aug 2022 03:41:27 +0100
"Matthew Wilcox (Oracle)" <willy@infradead.org> wrote:

>  
> @@ -9826,20 +9821,8 @@ static struct notifier_block trace_die_notifier = {
>  void
>  trace_printk_seq(struct trace_seq *s)
>  {
> -	/* Probably should print a warning here. */
> -	if (s->seq.len >= TRACE_MAX_PRINT)
> -		s->seq.len = TRACE_MAX_PRINT;
> -
> -	/*
> -	 * More paranoid code. Although the buffer size is set to
> -	 * PAGE_SIZE, and TRACE_MAX_PRINT is 1000, this is just
> -	 * an extra layer of protection.
> -	 */
> -	if (WARN_ON_ONCE(s->seq.len >= s->seq.size))
> -		s->seq.len = s->seq.size - 1;
> -
>  	/* should be zero ended, but we are paranoid. */
> -	s->buffer[s->seq.len] = 0;
> +	printbuf_nul_terminate(&s->seq);
>  
>  	printk(KERN_TRACE "%s", s->buffer);
>  
> diff --g

Please remove the two tracing patches and the deletion of the seq_buf from
the series.

Thank you.

-- Steve