Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 Aug 2022 10:47:18 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     isaku.yamahata@intel.com
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        isaku.yamahata@gmail.com, Paolo Bonzini <pbonzini@redhat.com>,
        erdemaktas@google.com, Sean Christopherson <seanjc@google.com>,
        Sagi Shahar <sagis@google.com>
Subject: Re: [PATCH v8 000/103] KVM TDX basic feature support
Message-ID: <YvCHRuq8B69UMSuq@debian.me>
References: <cover.1659854790.git.isaku.yamahata@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha384;
        protocol="application/pgp-signature"; boundary="mo0AN5RiRVHwqA1Y"
Content-Disposition: inline
In-Reply-To: <cover.1659854790.git.isaku.yamahata@intel.com>
Precedence: bulk


--mo0AN5RiRVHwqA1Y
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Aug 07, 2022 at 03:00:45PM -0700, isaku.yamahata@intel.com wrote:
> From: Isaku Yamahata <isaku.yamahata@intel.com>
>=20
> KVM TDX basic feature support
>=20
> Hello.  This is v8 the patch series vof KVM TDX support.
> This is based on v5.19-rc8 + kvm/queue branch + TDX HOST patch series.
> The tree can be found at https://github.com/intel/tdx/tree/kvm-upstream
> How to run/test: It's describe at https://github.com/intel/tdx/wiki/TDX-K=
VM
>=20
> Major changes from v7:
> - Use xarray to track whether GFN is private or shared. Drop SPTE_SHARED_=
MASK.
>   The complex state machine with SPTE_SHARED_MASK was ditched.
> - Large page support is implemented. But will be posted as independent RF=
C patch.
> - fd-based private page v7 is integrated. This is mostly same to Chao's p=
atches.
>   It's in github.
>=20
> Thanks,
> Isaku Yamahata
>=20

Hi, thanks for the series.

When building htmldocs, I found new warnings:

Documentation/x86/tdx.rst:69: WARNING: Unexpected indentation.
Documentation/x86/tdx.rst:70: WARNING: Block quote ends without a blank lin=
e; unexpected unindent.
Documentation/virt/kvm/tdx-tdp-mmu.rst: WARNING: document isn't included in=
 any toctree

I have applied the fixup (also with line blocks to code blocks conversion):

diff --git a/Documentation/virt/kvm/index.rst b/Documentation/virt/kvm/inde=
x.rst
index cdb8b43ce7970a..ff2db9ab428d3c 100644
--- a/Documentation/virt/kvm/index.rst
+++ b/Documentation/virt/kvm/index.rst
@@ -20,3 +20,4 @@ KVM
    review-checklist
=20
    intel-tdx
+   tdx-tdp-mmu
diff --git a/Documentation/x86/tdx.rst b/Documentation/x86/tdx.rst
index 6c6b09ca6ba407..34f0b9e5ee5678 100644
--- a/Documentation/x86/tdx.rst
+++ b/Documentation/x86/tdx.rst
@@ -62,7 +62,7 @@ use it as 'metadata' for the TDX memory.  It also takes a=
dditional CPU
 time to initialize those metadata along with the TDX module itself.  Both
 are not trivial.  Current kernel doesn't choose to always initialize the
 TDX module during kernel boot, but provides a function tdx_init() to
-allow the caller to initialize TDX when it truly wants to use TDX:
+allow the caller to initialize TDX when it truly wants to use TDX::
=20
         ret =3D tdx_init();
         if (ret)
@@ -79,20 +79,20 @@ caller.
 User can consult dmesg to see the presence of the TDX module, and whether
 it has been initialized.
=20
-If the TDX module is not loaded, dmesg shows below:
+If the TDX module is not loaded, dmesg shows below::
=20
-|  [..] tdx: TDX module is not loaded.
+  [..] tdx: TDX module is not loaded.
=20
 If the TDX module is initialized successfully, dmesg shows something
-like below:
+like below::
=20
-|  [..] tdx: TDX module: vendor_id 0x8086, major_version 1, minor_version =
0, build_date 20211209, build_num 160
-|  [..] tdx: 65667 pages allocated for PAMT.
-|  [..] tdx: TDX module initialized.
+  [..] tdx: TDX module: vendor_id 0x8086, major_version 1, minor_version 0=
, build_date 20211209, build_num 160
+  [..] tdx: 65667 pages allocated for PAMT.
+  [..] tdx: TDX module initialized.
=20
-If the TDX module failed to initialize, dmesg shows below:
+If the TDX module failed to initialize, dmesg shows below::
=20
-|  [..] tdx: Failed to initialize TDX module.  Shut it down.
+  [..] tdx: Failed to initialize TDX module.  Shut it down.
=20
 TDX Interaction to Other Kernel Components
 ------------------------------------------
@@ -143,10 +143,10 @@ There are basically two memory hot-add cases that nee=
d to be prevented:
 ACPI memory hot-add and driver managed memory hot-add.  The kernel
 rejectes the driver managed memory hot-add too when TDX is enabled by
 BIOS.  For instance, dmesg shows below error when using kmem driver to
-add a legacy PMEM as system RAM:
+add a legacy PMEM as system RAM::
=20
-|  [..] tdx: Unable to add memory [0x580000000, 0x600000000) on TDX enable=
d platform.
-|  [..] kmem dax0.0: mapping0: 0x580000000-0x5ffffffff memory add failed
+  [..] tdx: Unable to add memory [0x580000000, 0x600000000) on TDX enabled=
 platform.
+  [..] kmem dax0.0: mapping0: 0x580000000-0x5ffffffff memory add failed
=20
 However, adding new memory to ZONE_DEVICE should not be prevented as
 those pages are not managed by the page allocator.  Therefore,

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--mo0AN5RiRVHwqA1Y
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iJUEABMJAB0WIQTsebsWCPCpxY9T92n/R0PGQ3AzwAUCYvCHOwAKCRD/R0PGQ3Az
wOKRAYDoUs/UsE1xGxTc3HJtDisFuUa8l2g1WXkFhZ3kO2GwJGXqaEalUVN8lVgc
pGzwr4oBgKV92B34ny7L+15t9Rwif9EYIhvPAVr1DisL9rWois+XSFEDpx8C8i3Q
fgB2HD60nw==
=nHRq
-----END PGP SIGNATURE-----

--mo0AN5RiRVHwqA1Y--