Date: Thu, 7 Jun 2007 21:51:51 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
       James Carter <jwcart2@tycho.nsa.gov>, Paul Moore <paul.moore@hp.com>,
       James Morris <jmorris@namei.org>
Subject: Re: [bug] very high non-preempt latency in
	context_struct_compute_av()
Message-ID: <20070607195151.GA30899@elte.hu>
References: <20070604112745.GA26350@elte.hu> <1181244850.11979.66.camel@moss-spartans.epoch.ncsc.mil>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1181244850.11979.66.camel@moss-spartans.epoch.ncsc.mil>
User-Agent: Mutt/1.5.14 (2007-02-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1378
Lines: 35


* Stephen Smalley <sds@tycho.nsa.gov> wrote:

> Can you try the patch below to see whether it helps?
> 
> In security_get_user_sids, move the transition permission checks 
> outside of the section holding the policy rdlock, and use the AVC to 
> perform the checks, calling cond_resched after each one.  These 
> changes should allow preemption between the individual checks and 
> enable caching of the results.  It may however increase the overall 
> time spent in the function in some cases, particularly in the cache 
> miss case.
> 
> The long term fix will be to take much of this logic to userspace by 
> exporting additional state via selinuxfs, and ultimately deprecating 
> and eliminating this interface from the kernel.
> 
> Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>

i have just tried your patch and it completely solves the issue! Without 
the patch, a simple script that keeps logging in on a box:

	while :; do ssh testbox true; done

would cause glxgears to get into a very jerky motion due to the 
latencies. With the patch it's 100%, totally smooth! Thanks!

Tested-by: Ingo Molnar <mingo@elte.hu>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/