Subject: Re: [BUG] sysrq-m oops
From: john stultz <johnstul@us.ibm.com>
To: Bob Picco <bob.picco@hp.com>
Cc: Chuck Ebbert <cebbert@redhat.com>, lkml <linux-kernel@vger.kernel.org>,
       Sripathi Kodi <sripathik@in.ibm.com>, Bernhard Walle <bwalle@suse.de>,
       acme@redhat.com, apw@shadowen.org
In-Reply-To: <20070607182122.GE11999@localhost>
References: <1181176035.6275.13.camel@localhost.localdomain>
	 <4668276E.4030504@redhat.com>  <20070607182122.GE11999@localhost>
Content-Type: text/plain
Date: Thu, 07 Jun 2007 12:54:41 -0700
Message-Id: <1181246081.7621.6.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1074
Lines: 32

On Thu, 2007-06-07 at 14:21 -0400, Bob Picco wrote:
> Chuck Ebbert wrote:	[Thu Jun 07 2007, 11:42:38AM EDT]
> > On 06/06/2007 08:27 PM, john stultz wrote:
> > > Hey All,
> > > 	With 2.6.21 and the current -git, we're seeing the following oops when
> > > we try sysrq-m:
> > > 
> > 
> > It's here in arch/x86_64/mm/init.c::show_mem():
> > 
> >         for_each_online_pgdat(pgdat) {
> >                for (i = 0; i < pgdat->node_spanned_pages; ++i) {
> This is probably with sparsemem? I'm working with acme@redhat.com to
> test a patch. Basically you need to validate the pfn because it
> could be in a hole. Most arches which support sparsemem perform this
> check.
> 
> 			if (!pfn_valid(pgdat->node_start_pfn + i))
> 				continue;


Yep. That catch avoids the issue! Sounds like a 2.6.21.x candidate.

thanks so much!
-john


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/