Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 Aug 2022 09:56:45 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Fedor Pchelkin <pchelkin@ispras.ru>
Cc:     Oleksij Rempel <o.rempel@pengutronix.de>,
        Robin van der Gracht <robin@protonic.nl>,
        kernel@pengutronix.de, Oliver Hartkopp <socketcan@hartkopp.net>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        ldv-project@linuxtesting.org,
        Alexey Khoroshilov <khoroshilov@ispras.ru>
Subject: Re: [PATCH] can: j1939: fix memory leak of skbs
Message-ID: <20220808075645.qtgwu64mjc2rxnuc@pengutronix.de>
References: <20220805150216.66313-1-pchelkin@ispras.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hiqec7dmmpfnqmy6"
Content-Disposition: inline
In-Reply-To: <20220805150216.66313-1-pchelkin@ispras.ru>
Precedence: bulk


--hiqec7dmmpfnqmy6
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 05.08.2022 18:02:16, Fedor Pchelkin wrote:
> We need to drop skb references taken in j1939_session_skb_queue() when
> destroying a session in j1939_session_destroy(). Otherwise those skbs
> would be lost.
>=20
> Link to Syzkaller info and repro: https://forge.ispras.ru/issues/11743.
>=20
> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
>=20
> Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> Suggested-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Added to can/master

Thanks,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--hiqec7dmmpfnqmy6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmLwwboACgkQrX5LkNig
010SAgf8DcRHAVx/USEkzkATwto/JOfRALIMKu8UHkPr+0JyLricXyQYn4NPMUjg
3dP3ZYZY3l5Pg5hCrto9W0T1tgn/9SxRR7ngIgqX46YNphbBgIr07DjWMOrB5Lv+
YnrdkYgWfBH2rx1f6BJfF+9Dmur3vLomVG7IpwemLDeWa4azE2f9gRnJwHLBbfGX
RuvaBIgA+F6qAMXdU9RZv8d4/NGlI3gHQdvzrmNIZA79NEIVZMQA3DrZroN/W8t1
Hf/mJncv4eRYt38RcDoihu/CKEbS3C4gq2olzLN4xA1h+jUDJsDNdBHDHfd0w1fo
/3KKaSQleo2KY+k8pFkGm3LivhmhQQ==
=TBCJ
-----END PGP SIGNATURE-----

--hiqec7dmmpfnqmy6--