Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp4467741rwb; Mon, 8 Aug 2022 01:08:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR5vlXqJEqgZKoB7J7jAihvTJUAQbK7qDibLSEYteklDOHHZ7kbtQ0GpAC497BXvWG3pSqYG X-Received: by 2002:a05:6402:5518:b0:43a:9e32:b6fc with SMTP id fi24-20020a056402551800b0043a9e32b6fcmr17584277edb.252.1659946082838; Mon, 08 Aug 2022 01:08:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659946082; cv=none; d=google.com; s=arc-20160816; b=cQQIl2M5PkDgpVaSIA9V9/2LgJDySzFc7pvTyocLHn4ietmKcN+bfqzLCiBtcZk7Sl mAAC1TZvX+xTKdCtdW5BypM253pskc0s/SHeuibmqWMaPNOY4y9hloKw9mduXHNYgZRC 0oE2MqQw6N/Mq8ZmLXT1zZQ9LsMGSEPHQPQyfb0TDwkH/TAXXPmAuWQFWCL3WV5OUrJM iLwrfbOFgtfZhnFUfKyf0nbrKXQ0CQKiFOIDQVDqpBmXfEFTMb6xlivjLiwqujEUDQwL 2MnyEJggM6/LU6fhVGUnGQxjuBZTrdQ97sgRW/pdMSAcY8JdPpV3R8j3UXGYo5LzHRs7 DCVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=U81WVpi/g0s8Z6FBU4NFoeeFG5Yzs6br3uXXDJjII9Q=; b=EAM/dE6b91UH20dpgr5z+o2C5km4+BdrhCPXrfxgL6j9vOK1qsxEZwrtSSiknElBtO 2jFdX6kjcEEIqpa+6ckSdE/m16Em8C6r0Bu190P2CAY+GtSNahTbIgf9W3mk48WW9Sj6 OTY2yoIYq9+7bkTvzcPNrgov8ZVIS+E9xvhYbMYrSpP6ocs0fSKWiLqmO3xAvO6EwF1u 4qeiMIlDHSJbO78ehEDxW6LttzjrrdYJcgvlHtWnJ77I76qyznoLSoNbtCxqMUU6HgxR XcI96VYFE/2gTT4rcaHRsOE2M2RGt9r03J73Ue2jiYUxsxMmlZJEvxOPcSWi05ndaB9g P8sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd21-20020a170907629500b00730a3c9aeffsi11085767ejc.302.2022.08.08.01.07.37; Mon, 08 Aug 2022 01:08:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242040AbiHHH5s (ORCPT + 99 others); Mon, 8 Aug 2022 03:57:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242055AbiHHH5n (ORCPT ); Mon, 8 Aug 2022 03:57:43 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C223613D39 for ; Mon, 8 Aug 2022 00:57:42 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oKxdm-000065-Br; Mon, 08 Aug 2022 09:57:34 +0200 Received: from pengutronix.de (unknown [IPv6:2a01:4f8:1c1c:29e9:22:41ff:fe00:1400]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id E59C9C45B4; Mon, 8 Aug 2022 07:57:32 +0000 (UTC) Date: Mon, 8 Aug 2022 09:57:32 +0200 From: Marc Kleine-Budde To: Christophe JAILLET Cc: Wolfgang Grandegger , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] can: rcar_canfd: Use dev_err_probe() to simplify code and better handle -EPROBE_DEFER Message-ID: <20220808075732.gue3p4d5lhsa4sse@pengutronix.de> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sbokewfw5xtt5aba" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sbokewfw5xtt5aba Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 07.08.2022 09:52:11, Christophe JAILLET wrote: > devm_clk_get() can return -EPROBE_DEFER, so use dev_err_probe() instead of > dev_err() in order to be less verbose in the log. >=20 > This also saves a few LoC. >=20 > While at it, turn a "goto fail_dev;" at the beginning of the function into > a direct return in order to avoid mixing goto and return, which looks > spurious. >=20 > Signed-off-by: Christophe JAILLET Added to can-next/testing. Thanks, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --sbokewfw5xtt5aba Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmLwweoACgkQrX5LkNig 012yDgf/VDv2f0dcYbhTF4sZWOuz4JarIS/2huEEeU7inNy2gjqWXvlWV5WLDrSP FfZYXJWFl/RDOERfC0mi3AGHMghOA9WAkkXgZEpz/9edR3yF94TWvHmQkRIBYYvg wiRR4O6VaSRfbW+2bHf9aROEx5xczf+jszHmmlZcqQpM9oTUqOxZiwg2KKQVM9oL fM9orCR8kGetnbE6B0AsDf2HulQNWkjMqA+AiSM/QwxvG3XlvfCD/QG5/wGXns0s FTNEyP6sf9iNfhiFFquKEbxv9JBOEV6Tar9Q5Xs7M3w0dfwbVYOiZ0lTT8Hkt8q2 hTvTcuS7m/0miL8xZvIBymTW7iz7Zg== =IjJ6 -----END PGP SIGNATURE----- --sbokewfw5xtt5aba--