Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 Aug 2022 14:07:14 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1 1/5] regmap: mmio: Don't unprepare attached clock
Message-ID: <YvEKgkhRWCKtXdD4@sirena.org.uk>
References: <20220805205321.19452-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="A2erhOPr7Nn4VMFi"
Content-Disposition: inline
In-Reply-To: <20220805205321.19452-1-andriy.shevchenko@linux.intel.com>
Precedence: bulk


--A2erhOPr7Nn4VMFi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Aug 05, 2022 at 11:53:17PM +0300, Andy Shevchenko wrote:
> The commit eb4a219d19fd ("regmap: Skip clk_put for attached clocks when
> freeing context") oexcluded clk_put() call on regmap freeing. But the
> same is needed for clk_unprepare() since the regmap MMIO users should
> call regmap_mmio_detach_clk() which does unprepare the clock. Update
> the code accordingly, so neither clk_put() nor clk_unprepare() would
> be called for the attached clock.

regmap_mmio_attach_clk() prepares the clock that's passed in, we should
undo that when detaching otherwise we're leaking a prepare (as we do in
the explicit detach).

--A2erhOPr7Nn4VMFi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLxCoIACgkQJNaLcl1U
h9CvSwf/Qv3iitGv9EmdB0qKYwzEDy202Tge7l+lsrA4FZOETyRY1VXNMvrdPDXo
ByM7ms+IuiwZeBnTC0ccK4Esu1se1vttawYi4XzUz47amGnAJdJCjstM75/MKgbX
kRTE3BUBw7sMJJIsPCv02WsVGnTDWEudD+iF024/1Cg0tC4FuIVoQ4U/O88EHA95
AXAbeX75MlJhxF/ux2CfLrepPzVgnlkXbDKfVCoA38ctyF/jm1RnnrCiqpjpSMhv
xvi11gqHixl79EJR2PWR0/49BK0opVo7500QxBSn0H+YHM8JIahbP8/YIKtoDfpJ
KwiZtKujCvwvZAhNw4t7dfku6Uzmkg==
=A+Is
-----END PGP SIGNATURE-----

--A2erhOPr7Nn4VMFi--