Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 Aug 2022 14:02:49 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1 2/5] regmap: mmio: Drop unneeded and duplicative
 checks around CLK calls
Message-ID: <YvEJefFk7bqW9EpZ@sirena.org.uk>
References: <20220805205321.19452-1-andriy.shevchenko@linux.intel.com>
 <20220805205321.19452-2-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cMx/71A40yRPJXOW"
Content-Disposition: inline
In-Reply-To: <20220805205321.19452-2-andriy.shevchenko@linux.intel.com>
Precedence: bulk


--cMx/71A40yRPJXOW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Aug 05, 2022 at 11:53:18PM +0300, Andy Shevchenko wrote:

> The commit 6b8e090ecc3d ("regmap: use IS_ERR() to check clk_get()
> results") assumes that CLK calls return the error pointer when clock
> is not found. However in the current code the described situation
> is simply impossible, because the regmap won't be created with
> missed clock if requested. The only way when it can be the case is
> what the above mentioned commit introduced by itself, when clock is
> not provided.

> Taking above into consideration, effectively revert the commit
> 6b8e090ecc3d and while at it, drop unneeded NULL checks since CLK
> calls are NULL-aware.

I don't understand the supposed benefit of this.  Yes, the clk API does
currently accept NULL as a valid clock and returns it as a dummy but
explicitly taking advantage of that in the way that this does just feels
more sloppy than the current behaviour.

--cMx/71A40yRPJXOW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLxCXgACgkQJNaLcl1U
h9DMOwf/eNFWkdchMn3cZkkl3lmpPaqIgqMyLV9N3izOdCxpfgwskCLw1iLwL9D6
jrVr/MMECyex1hR9ZyLn5FJh5NKH0Wban6igjr8Edj7KhqeL5fE6FmzBg4inkPq3
10r2wDq+DbS83GMFLyi+8TXSbHe75+fVBLvBddqObcoXMds//CbHU7v9YIWo6dZS
d20Xb6dMHRIbel0Qh2NJOGrDgh+DEPQWkUH2VMiCPQsj/xObDp6oRSWE7nNwn/XK
je/5TI9D6acRsfeil9L09QDqVX0DI8syrmxDCiiCll8CBtItWMuaj4fGWsc+0u2C
9q7TxR8oOl+03RxUZoRc9IGy33bqEg==
=+Nfn
-----END PGP SIGNATURE-----

--cMx/71A40yRPJXOW--