Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 Aug 2022 14:18:21 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1 5/5] regmap: mmio: Introduce IO accessors that can
 talk to IO port
Message-ID: <YvENHSRQuwAzfQJW@sirena.org.uk>
References: <20220805205321.19452-1-andriy.shevchenko@linux.intel.com>
 <20220805205321.19452-5-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="i9XU/Qm8+P/E2d47"
Content-Disposition: inline
In-Reply-To: <20220805205321.19452-5-andriy.shevchenko@linux.intel.com>
Precedence: bulk


--i9XU/Qm8+P/E2d47
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Aug 05, 2022 at 11:53:21PM +0300, Andy Shevchenko wrote:

> Currently regmap MMIO is inconsistent with IO accessors. I.e.
> the Big Endian counterparts are using ioreadXXbe() / iowriteXXbe()
> which are not clean implementations of readXXbe(). Besides that
> some users may use regmap MMIO for IO ports, and this can be done
> by assigning ioreadXX()/iowriteXX() and their Big Endian counterparts
> to the regmap context.

Have you validated that nothing is relying on whatever the problem is
with using the io versions?

> That said, reimplement current Big Endian MMIO accessors by replacing
> ioread()/iowrite() with respective read()/write() and swab() calls.
> While at it, add IO port support with a corresponding flag added.

This should be a separate patch.

> +			if (config->io_port) {
> +				ctx->reg_read = regmap_mmio_ioread8;
> +				ctx->reg_write = regmap_mmio_iowrite8;
> +			} else if (config->use_relaxed_mmio) {

If these options are mutually exclusive we should validate that they are
not simultaneously set.

--i9XU/Qm8+P/E2d47
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLxDRwACgkQJNaLcl1U
h9Cbcwf/Trad6vAcRYZP6BRpxuYj5WEIyFGx1k4EjxZRS0vbTYZAnyWY3H7OkYsq
BwmhYJQQrMT3ApfBnRIs+ZK+1XfSXIqCBO9hyBgf+ph8srUT3P2OeNVNTyCTj1vo
royXM6mSaKN/mxl+lVXYH2K2BR05jbWSiwYYMQMp7MflMMZBQlIiLTbW0gbfqDOR
HkYVneNc/ZA4mcRPdgfmNZyu1jLk9vfqHTRATHe4S6vzCvsllTYe62nmII1qWdgz
ztilIFFEaQSmvZUrMH58ZtXk1UR0zO7KJzY3ja3UvyUHds+21wtyZqW87wz0+ZZV
bXAewon/H7CcGW7DlrHmZCCFMUZEFg==
=y+ks
-----END PGP SIGNATURE-----

--i9XU/Qm8+P/E2d47--