Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f16afc86-520a-f0b1-a7ea-f02cfb1c21ed@linaro.org>
Date:   Mon, 8 Aug 2022 14:24:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 0/8] power: supply: Add driver for Qualcomm SMBCHG
Content-Language: en-US
To:     Yassine Oudjana <yassine.oudjana@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Sebastian Reichel <sre@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Yassine Oudjana <y.oudjana@protonmail.com>,
        Alejandro Tafalla <atafalla@dnyon.com>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, phone-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220808073459.396278-1-y.oudjana@protonmail.com>
 <a233730b-6ac3-2cb9-cc5c-21ca6289fadc@linaro.org>
 <BUIAGR.NIMOFVJH9GVZ1@gmail.com>
From:   Caleb Connolly <caleb.connolly@linaro.org>
In-Reply-To: <BUIAGR.NIMOFVJH9GVZ1@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 08/08/2022 10:39, Yassine Oudjana wrote:
> 
> On Mon, Aug 8 2022 at 11:41:26 +03:00:00, Krzysztof Kozlowski 
> <krzysztof.kozlowski@linaro.org> wrote:
>> On 08/08/2022 10:34, Yassine Oudjana wrote:
>>>  From: Yassine Oudjana <y.oudjana@protonmail.com>
>>>
>>>  This series adds a driver for the switch-mode battery charger found on PMICs
>>>  such as PMI8994, and referred to in the vendor kernel[1] as smbcharger or
>>>  SMBCHG. More details on this block can be found in the last patch message.
>>>
>>>  This driver currently supports the charger blocks of PMI8994 and PMI8996.
>>>  PMI8950 was also to be supported, but it was dropped due to some last minute
>>>  issues, to be brought back at a later time once ready.
>>>
>>>  The OTG regulator remains unused on devices where the charger is enabled in
>>>  this series due to lack of a consumer. Applying a patch[2] adding vbus-supply
>>>  to DWC3 allows it to enable the OTG regulator making USB host without
>>>  external power possible.
>>>
>>>  [1] 
>>> https://github.com/android-linux-stable/msm-3.18/blob/kernel.lnx.3.18.r34-rel/drivers/power/qpnp-smbcharger.c 
>>>
>>>  [2] 
>>> https://lore.kernel.org/linux-usb/20200805061744.20404-1-mike.looijmans@topic.nl/ 
>>>
>>
>> How is it different from PMI8998? I expect not that much, so this should
>> be based on existing work:
>> https://lore.kernel.org/linux-arm-msm/20220706194125.1861256-1-caleb.connolly@linaro.org/ 
>>
>>
>> Unless they are different, but then please create common parts and
>> explain the differences.
>>
>> Best regards,
>> Krzysztof
> 
> This driver has been in slow developement for a long time before that one 
> existed, which was why no initial attempt at a common driver was made. With that 
> said however, I've been watching its development even before it was sent for 
> review, and It seems that the hardware is actually quite different. For example, 
> the original charger entirely lacks the type-c functionality that exists on the 
> second gen one. There are a couple of similar registers like CMD_APSD (same 
> address and function) CHGR_CFG2 (same/similar function, different address), but 
> other than that there don't seem to be any major similarities. While I guess it 
> would technically be possible to force them into one driver with multiple 
> register tables and separate functions for most tasks, I think it would just 
> unnecessarily complicate things. One thing that is common however is the secure 
> register unlock sequence, which I have separated in patch 6 to allow for its use 
> in other drivers (the fuel gauge block has secure registers too so it will also 
> be used in an upcoming fuel gauge driver).

Yes, we took the shared approach for the still work in progress fuel gauge 
driver, and whilst there are more similarities in that block for basic 
functionality at least, more complicated components differ quite a lot as far as 
I'm aware.

Even for the fuel gauge, separate handlers are needed for a lot of things still:
https://gitlab.com/sdm845-mainline/linux/-/blob/sdm845/5.19-release/drivers/power/supply/qcom_fg.c#L792
So I don't think trying to create a common driver here is the right approach.

Perhaps some abstraction is possible for the overall similarities like handling 
the APSD, dealing with current limiting, cable detection etc, perhaps some of 
this common code could be pulled out into a shared "helper"?

Maybe this is something worth reconsidering as and when we look at adding 
support for some of the more complicated features this hardware supports.
> 
> 

-- 
Kind Regards,
Caleb (they/he)