Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 Aug 2022 09:37:50 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Kent Overstreet <kent.overstreet@gmail.com>
Cc:     "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        linux-kernel@vger.kernel.org, pmladek@suse.com,
        Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v5 31/32] tracing: Convert to printbuf
Message-ID: <20220808093750.4dd24af2@gandalf.local.home>
In-Reply-To: <8e1df054-062f-63c9-16b4-38143f3e7983@gmail.com>
References: <20220808024128.3219082-1-willy@infradead.org>
        <20220808024128.3219082-32-willy@infradead.org>
        <20220807225113.6a74b481@gandalf.local.home>
        <8e1df054-062f-63c9-16b4-38143f3e7983@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 7 Aug 2022 23:32:01 -0400
Kent Overstreet <kent.overstreet@gmail.com> wrote:

> > Please remove the two tracing patches and the deletion of the seq_buf from
> > the series.  
> 
> Well, that's not really an option, as Christoph already (rightly) 
> pointed out.

These are the last patches of the series. There's no dependency on them.
You should be able to simply drop them. If others find that these patches
are worth their while then by all means, let them have them.

> 
> If you've got actual engineering concerns that you'd care to articulate 
> I'd (still) like to try to work with you - otherwise, I don't think this 
> is something I can accommodate you on.

Here's my technical reason. These are non trivial changes that are replacing
code that has been stable for 8 years that the tracing infrastructure
highly depends on. I do not have the time to sit down and review this code
as it is not a priority. My time is extremely limited (as my wife keeps
complaining to me about, as I'm not spending enough time with the family).

This change is likely to cause subtle regressions for no benefit to the
tracing subsystem. Hence, when it comes to risk vs reward, I see none.

I'm not NACKing the series, just the changes to the tracing subsystem.

When this code is mature enough, I may reconsider my stance on this.

-- Steve