Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp4764463rwb; Mon, 8 Aug 2022 06:45:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR5QRGQdIhiHtyrp4XmoGXTXyNKuWYzUqGDL90TToGjv+dCfJqI39HGLomlroH6aze7bELYX X-Received: by 2002:a05:6a00:16c1:b0:520:6ede:24fb with SMTP id l1-20020a056a0016c100b005206ede24fbmr19023481pfc.7.1659966313623; Mon, 08 Aug 2022 06:45:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659966313; cv=none; d=google.com; s=arc-20160816; b=CummmNaKaH07a8nAB0X+bSUaGRUqfmvzCzG38Tc6JNfK+7ahm7OO6KkCIIj3F/PaGJ b7EQjDBATUD2u3MXOPolLkdwEjTg6EhLxTPB7CeVOG8ntmb4Sg0Oi/PaLG7Fs2En53Ao MZj5Y/rGsLj7Xi/GUiH9J9+PVm4dazhkVDPnHGSEUcva7i+sumCh45ezjkie5upOGCkN +0E0IzKl8FhDGgz+DItsoBWM8+kQ927zCihkQn+KlRKvsOnzgbhV3kXI8XaigYAiO/xB MeSOO4XXyyWfa89FVZzJuy6dO6BM/v2+79D90OXcsIvA4SnOGIju45toc+1n5VUhOzLV G0dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lh5b+wXhWQhQ3U5iiLGr0TKMnieEmb/i7YcCONXQCG8=; b=qmkDHppyKJR4Jcx7FfwqoIDyLcZT6VYDnGfiK6k6bwVATk4AKPeUnN9SnhuuqTk2ZG Gi+wS9DsOzZyI7FuvIRjY4MK6FITfKNzMOs751W9SG7YrFurFB55lUDC6EIsuvz6MzzB n7R6W6WxZIydBUtqqxWSvGpr9m7/JyobS6hLBrNbCUun/y5c5b1mOKoUIIpwZqal5TUy qjeUgW6dAIevN1qE7NtPvq1LikMMZeRvAJgfotAqDMr9h9ogiSAS77+qKrtoymFNQwtM NJgeTw9BQOUvwQbzM3JfNDO8GgfFFxF5elG/UqR5GENu4cr4bVGMzcihIQ38h25HCIRl e3Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="NuDhuwm/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z12-20020aa79f8c000000b0052ae8f0c52fsi11702064pfr.152.2022.08.08.06.44.57; Mon, 08 Aug 2022 06:45:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="NuDhuwm/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243290AbiHHNaK (ORCPT + 99 others); Mon, 8 Aug 2022 09:30:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242628AbiHHNaG (ORCPT ); Mon, 8 Aug 2022 09:30:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1C75BC26; Mon, 8 Aug 2022 06:30:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D5B06121F; Mon, 8 Aug 2022 13:30:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B98EC433C1; Mon, 8 Aug 2022 13:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659965404; bh=a11PrFr0QU2TMyjEjHd+D+4ZCEi56EIcD/sVdbPA3TI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NuDhuwm/QcTsNh0is7t//3B9+WHiIeVx3ZPjdyJFyhaQIlDI9bkrYIfyqbntMFhS9 M1YTVKshagYN9BdY3hHlXibw4YOp61AipofX35bPepSo40/IN9bDHAS9t8aTLSNEoQ /maE81f8ccwW5SFOO0BcZyUWwOqDhNurpW1QDIuxpYRHokbBZAzYF9UWSBZHIVaMnY CEke5nKo+Ny0U0wWF8mx35fHbr4/w7cEXyCoHk+1J0j2n8mFj+Hh4JP8Gym42dBttp 2dpxkEUoBOJ5qyISKDmA9HpORWlZlvBQV8+POdgMOeVsi2Hl1yLSejntcmCQvTres3 H4UmlRnhvB2Kw== Date: Mon, 8 Aug 2022 14:29:59 +0100 From: Mark Brown To: patrice.chotard@foss.st.com Cc: Alexandre Torgue , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, christophe.kerello@foss.st.com, devicetree@vger.kernel.org Subject: Re: [PATCH 2/3] spi: stm32_qspi: Add transfer_one_message() spi callback Message-ID: References: <20220808074051.44736-1-patrice.chotard@foss.st.com> <20220808074051.44736-3-patrice.chotard@foss.st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cLMWiIMhBnFRWQta" Content-Disposition: inline In-Reply-To: <20220808074051.44736-3-patrice.chotard@foss.st.com> X-Cookie: Flee at once, all is discovered. X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cLMWiIMhBnFRWQta Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 08, 2022 at 09:40:50AM +0200, patrice.chotard@foss.st.com wrote: > + ret = pm_runtime_get_sync(qspi->dev); > + if (ret < 0) { > + pm_runtime_put_noidle(qspi->dev); > + return ret; > + } Use the core runtime PM, there should be no need to open code. --cLMWiIMhBnFRWQta Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLxD9YACgkQJNaLcl1U h9B5sgf+In74ixHnCRZMTBmlDnGq0rbz2vl15eopttvjouYl8KTYKUmRnu8dfafd nscthycpSYVRecbPtNW3Q1PoEOg9x5iEwUtC7uEPmk2oWD/c2Ck2691Zd5aUA18r aOPa0BO3D/TPDhAwWfI6jPIcNbrPYksSL2yFSRogAeBhq3ze/USWI+6IOspS6IR9 uvkG/XI2gA6b5CcJBXQsK40bZNX97y4QnKtzWLERmPDe3s+ljYTdJf0+djVVQg24 Oi67dvkkT8FFu8Je4S/bStR8rNvksD40FnM7RYU7Z+200TzNcRd/NCBrfAx5xSuD BAaW4TcV9hF2egVdRVLL+xLtZR63Ew== =y3IU -----END PGP SIGNATURE----- --cLMWiIMhBnFRWQta--