Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220807104027.10808-1-paul@crapouillou.net>
In-Reply-To: <20220807104027.10808-1-paul@crapouillou.net>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 8 Aug 2022 15:16:48 +0200
Message-ID: <CAHp75VeafLqtdhasZ2mnk2sYv++a-HirHSePCcxteqPqBBy_uw@mail.gmail.com>
Subject: Re: [PATCH] leds: max8997: Don't error if there is no pdata
To:     Paul Cercueil <paul@crapouillou.net>
Cc:     Pavel Machek <pavel@ucw.cz>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Aug 7, 2022 at 12:40 PM Paul Cercueil <paul@crapouillou.net> wrote:
>
> The driver will works just fine if no platform data was supplied.

s/works/work/
  ...or...
s/will//

With the above fix,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  drivers/leds/leds-max8997.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/leds/leds-max8997.c b/drivers/leds/leds-max8997.c
> index c0bddb33888d..c8d7f55c9dec 100644
> --- a/drivers/leds/leds-max8997.c
> +++ b/drivers/leds/leds-max8997.c
> @@ -238,11 +238,6 @@ static int max8997_led_probe(struct platform_device *pdev)
>         char name[20];
>         int ret = 0;
>
> -       if (pdata == NULL) {
> -               dev_err(&pdev->dev, "no platform data\n");
> -               return -ENODEV;
> -       }
> -
>         led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL);
>         if (led == NULL)
>                 return -ENOMEM;
> @@ -258,7 +253,7 @@ static int max8997_led_probe(struct platform_device *pdev)
>         led->iodev = iodev;
>
>         /* initialize mode and brightness according to platform_data */
> -       if (pdata->led_pdata) {
> +       if (pdata && pdata->led_pdata) {
>                 u8 mode = 0, brightness = 0;
>
>                 mode = pdata->led_pdata->mode[led->id];

-- 
With Best Regards,
Andy Shevchenko